From: Wathsala Wathawana Vithanage <wathsala.vithanage@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Dhruv Tripathi <Dhruv.Tripathi@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
Nick Connolly <Nick.Connolly@arm.com>,
Vinod Krishna <Vinod.Krishna@arm.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
nd <nd@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics
Date: Wed, 3 Jul 2024 16:19:06 +0000 [thread overview]
Message-ID: <AM0PR08MB5073B95DD43586B2BEA79A629FDD2@AM0PR08MB5073.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <859956985.pAmPZ1aGmH@thomas>
> > > > +uint8_t wfet_en;
> > >
> > > It should be made static probably.
> > > This variable will be unused in some cases, needs #ifdef.
> > >
> >
> > This variable is used in all cases. It's 1 when WFET is available, 0 when it's not.
>
> It would be 0 if you make it static yes.
No need to make it static to set it to 0, it will be placed in BSS section as is hence
will always be initialized to 0.
Static only limits its scope to this file, has nothing to do with initialization to 0.
prev parent reply other threads:[~2024-07-03 16:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 4:44 [PATCH 1/2] config/arm: adds Arm Neoverse N3 SoC Wathsala Vithanage
2024-06-04 4:44 ` [PATCH 2/2] eal: add Arm WFET in power management intrinsics Wathsala Vithanage
2024-06-04 15:41 ` Stephen Hemminger
2024-06-19 6:45 ` [PATCH v2 1/2] config/arm: adds Arm Neoverse N3 SoC Wathsala Vithanage
2024-06-19 6:45 ` [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics Wathsala Vithanage
2024-06-27 15:30 ` Thomas Monjalon
2024-07-01 21:34 ` Wathsala Wathawana Vithanage
2024-07-02 8:29 ` Thomas Monjalon
2024-07-03 13:27 ` Wathsala Wathawana Vithanage
2024-07-03 13:33 ` Thomas Monjalon
2024-07-03 16:58 ` Wathsala Wathawana Vithanage
2024-07-04 10:55 ` Pavan Nikhilesh Bhagavatula
2024-07-04 14:14 ` Thomas Monjalon
2024-07-04 14:55 ` Stephen Hemminger
2024-07-04 18:59 ` Thomas Monjalon
2024-07-05 16:10 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-07-05 16:01 ` Wathsala Wathawana Vithanage
2024-07-05 16:11 ` Pavan Nikhilesh Bhagavatula
2024-07-05 16:25 ` Wathsala Wathawana Vithanage
2024-07-03 16:19 ` Wathsala Wathawana Vithanage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB5073B95DD43586B2BEA79A629FDD2@AM0PR08MB5073.eurprd08.prod.outlook.com \
--to=wathsala.vithanage@arm.com \
--cc=Dhruv.Tripathi@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Nick.Connolly@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=Vinod.Krishna@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jack.bond-preston@foss.arm.com \
--cc=nd@arm.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).