From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, Gavin Hu <Gavin.Hu@arm.com>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v7 03/17] test/ring: add functional tests for rte_ring_xxx_elem APIs
Date: Thu, 9 Jan 2020 05:15:24 +0000 [thread overview]
Message-ID: <AM0PR08MB5138D05219583F571A78266A98390@AM0PR08MB5138.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB2558F1D5B48103AB6753063D9A3F0@SN6PR11MB2558.namprd11.prod.outlook.com>
<snip>
> Subject: RE: [PATCH v7 03/17] test/ring: add functional tests for
> rte_ring_xxx_elem APIs
>
> > > > Add basic infrastructure to test rte_ring_xxx_elem APIs. Add test
> > > > cases for testing burst and bulk tests.
> > > >
> > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > > > ---
<snip>
> > > > diff --git a/app/test/test_ring.h b/app/test/test_ring.h new file
> > > > mode
> > > > 100644 index 000000000..19ef1b399
> > > > --- /dev/null
> > > > +++ b/app/test/test_ring.h
> > > > @@ -0,0 +1,203 @@
> > > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > > + * Copyright(c) 2019 Arm Limited
> > > > + */
> > > > +
> > > > +#include <rte_malloc.h>
> > > > +#include <rte_ring.h>
> > > > +#include <rte_ring_elem.h>
> > > > +
> > > > +/* API type to call
> > > > + * N - Calls default APIs
> > > > + * S - Calls SP or SC API
> > > > + * M - Calls MP or MC API
> > > > + */
> > > > +#define TEST_RING_N 1
> > > > +#define TEST_RING_S 2
> > > > +#define TEST_RING_M 4
> > > > +
> > > > +/* API type to call
> > > > + * SL - Calls single element APIs
> > > > + * BL - Calls bulk APIs
> > > > + * BR - Calls burst APIs
> > > > + */
> > > > +#define TEST_RING_SL 8
> > > > +#define TEST_RING_BL 16
> > > > +#define TEST_RING_BR 32
> > > > +
> > > > +#define TEST_RING_IGNORE_API_TYPE ~0U
> > > > +
> > > > +#define TEST_RING_INCP(obj, esize, n) do { \
> > > > + /* Legacy queue APIs? */ \
> > > > + if ((esize) == -1) \
> > > > + obj = ((void **)obj) + n; \
> > > > + else \
> > > > + obj = (void **)(((uint32_t *)obj) + \
> > > > + (n * esize / sizeof(uint32_t))); \ }
> > > while (0)
> > > > +
> > > > +#define TEST_RING_CREATE(name, esize, count, socket_id, flags, r) do
> { \
> > > > + /* Legacy queue APIs? */ \
> > > > + if ((esize) == -1) \
> > > > + r = rte_ring_create((name), (count), (socket_id), (flags)); \
> > > > + else \
> > > > + r = rte_ring_create_elem((name), (esize), (count), \
> > > > + (socket_id), (flags)); \
> > > > +} while (0)
> > > > +
> > > > +#define TEST_RING_ENQUEUE(r, obj, esize, n, ret, api_type) do { \
> > > > + /* Legacy queue APIs? */ \
> > > > + if ((esize) == -1) \
> > > > + switch (api_type) { \
> > > > + case (TEST_RING_N | TEST_RING_SL): \
> > > > + ret = rte_ring_enqueue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_SL): \
> > > > + ret = rte_ring_sp_enqueue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_SL): \
> > > > + ret = rte_ring_mp_enqueue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BL): \
> > > > + ret = rte_ring_enqueue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BL): \
> > > > + ret = rte_ring_sp_enqueue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BL): \
> > > > + ret = rte_ring_mp_enqueue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BR): \
> > > > + ret = rte_ring_enqueue_burst(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BR): \
> > > > + ret = rte_ring_sp_enqueue_burst(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BR): \
> > > > + ret = rte_ring_mp_enqueue_burst(r, obj, n, NULL); \
> > > > + } \
> > > > + else \
> > > > + switch (api_type) { \
> > > > + case (TEST_RING_N | TEST_RING_SL): \
> > > > + ret = rte_ring_enqueue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_SL): \
> > > > + ret = rte_ring_sp_enqueue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_SL): \
> > > > + ret = rte_ring_mp_enqueue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BL): \
> > > > + ret = rte_ring_enqueue_bulk_elem(r, obj, esize, n, \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BL): \
> > > > + ret = rte_ring_sp_enqueue_bulk_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BL): \
> > > > + ret = rte_ring_mp_enqueue_bulk_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BR): \
> > > > + ret = rte_ring_enqueue_burst_elem(r, obj, esize, n, \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BR): \
> > > > + ret = rte_ring_sp_enqueue_burst_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BR): \
> > > > + ret = rte_ring_mp_enqueue_burst_elem(r, obj, esize,
> > > n, \
> > > > + NULL); \
> > > > + } \
> > > > +} while (0)
> > > > +
> > > > +#define TEST_RING_DEQUEUE(r, obj, esize, n, ret, api_type) do { \
> > > > + /* Legacy queue APIs? */ \
> > > > + if ((esize) == -1) \
> > > > + switch (api_type) { \
> > > > + case (TEST_RING_N | TEST_RING_SL): \
> > > > + ret = rte_ring_dequeue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_SL): \
> > > > + ret = rte_ring_sc_dequeue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_SL): \
> > > > + ret = rte_ring_mc_dequeue(r, obj); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BL): \
> > > > + ret = rte_ring_dequeue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BL): \
> > > > + ret = rte_ring_sc_dequeue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BL): \
> > > > + ret = rte_ring_mc_dequeue_bulk(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BR): \
> > > > + ret = rte_ring_dequeue_burst(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BR): \
> > > > + ret = rte_ring_sc_dequeue_burst(r, obj, n, NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BR): \
> > > > + ret = rte_ring_mc_dequeue_burst(r, obj, n, NULL); \
> > > > + } \
> > > > + else \
> > > > + switch (api_type) { \
> > > > + case (TEST_RING_N | TEST_RING_SL): \
> > > > + ret = rte_ring_dequeue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_SL): \
> > > > + ret = rte_ring_sc_dequeue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_SL): \
> > > > + ret = rte_ring_mc_dequeue_elem(r, obj, esize); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BL): \
> > > > + ret = rte_ring_dequeue_bulk_elem(r, obj, esize, n, \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BL): \
> > > > + ret = rte_ring_sc_dequeue_bulk_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BL): \
> > > > + ret = rte_ring_mc_dequeue_bulk_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_N | TEST_RING_BR): \
> > > > + ret = rte_ring_dequeue_burst_elem(r, obj, esize, n, \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_S | TEST_RING_BR): \
> > > > + ret = rte_ring_sc_dequeue_burst_elem(r, obj, esize, n,
> > > \
> > > > + NULL); \
> > > > + break; \
> > > > + case (TEST_RING_M | TEST_RING_BR): \
> > > > + ret = rte_ring_mc_dequeue_burst_elem(r, obj, esize,
> > > n, \
> > > > + NULL); \
> > > > + } \
> > > > +} while (0)
> > >
> > >
> > > My thought to avoid test-code duplication was a bit different.
> > Yes, this can be done multiple ways. My implementation is not complicated
> either.
> >
> > > Instead of adding extra enums/parameters and then do switch on them,
> > > my
> > The switch statement should be removed by the compiler for the
> performance tests.
>
> I am sure the compiler will do its job properly.
> My concern is that with all these extra flags, it is really hard to read and
> understand what exactly function we are calling and what we are trying to
> test.
There are just 2 flags - 1) representing single/bulk/burst 2) representing default/single/multiple threads. This is the way the rte_ring APIs are also organized (rte_ring_<sp/mp or sc/mc>_enqueue_<bulk/burst>).
If we want to keep the code flexible, we have to keep these 2 flags that can be varied.
Your proposal considers only the element size as a variable. It does not consider the above mentioned variables. This results in code duplication. This is visible in patch 10/17.
> Might be just me, but let say in original version for enqueue_bulk() we have:
>
> const uint64_t sp_start = rte_rdtsc();
> for (i = 0; i < iterations; i++)
> while (rte_ring_sp_enqueue_bulk(r, burst, size, NULL) == 0)
> rte_pause();
> const uint64_t sp_end = rte_rdtsc();
>
> const uint64_t mp_start = rte_rdtsc();
> for (i = 0; i < iterations; i++)
> while (rte_ring_mp_enqueue_bulk(r, burst, size, NULL) == 0)
> rte_pause();
> const uint64_t mp_end = rte_rdtsc();
>
> Simple and easy to understand.
> Same code after the patch doesn't that straightforward anymore:
>
> const uint64_t sp_start = rte_rdtsc();
> for (i = 0; i < iterations; i++)
> do {
> if (flag == 0)
> TEST_RING_ENQUEUE(r, burst, esize, bsize, ret,
> TEST_RING_S | TEST_RING_BL);
> else if (flag == 1)
> TEST_RING_DEQUEUE(r, burst, esize, bsize, ret,
> TEST_RING_S | TEST_RING_BL);
Would it help if the #define names are better?
May be convert
TEST_RING_SL to TEST_ELEM_SINGLE
TEST_RING_BL to TEST_ELEM_BULK
TEST_RING_BR to TEST_ELEM_BURST
and
TEST_RING_N to TEST_THREAD_DEFAULT
TEST_RING_S to TEST_THREAD_SPSC
TEST_RING_M to TEST_THREAD_MPMC
> if (ret == 0)
> rte_pause();
> } while (!ret);
> const uint64_t sp_end = rte_rdtsc();
>
> Another thing - if tomorrow we'll want to add perf tests for elem_size==4/8,
> etc. - we'll need to do copy/paste for all test-case invocations, as you did for
> 16B (or some code reorg).
This is a mistake on my side. Looking at the code, 'test_ring_perf' can be simplified to avoid the copy/paste. 'test_ring_perf' can be changed to call another function (that contains the test cases) with different element sizes. I will make this change.
The only issue would be the wrappers 'dequeue_bulk', 'dequeue_bulk_16B' etc. However, the wrappers are simple enough to maintain.
>
> >
> > > intention was something like that:
> > >
> > > 1. mv test_ring_perf.c test_ring_perf.h 2. Inside test_ring_perf.h
> > > change rte_ring_ create/enqueue/dequeue function
> > > calls to some not-defined function/macros invocations.
> > > With similar name, same number of parameters, and same semantics.
> > > Also change 'void *burst[..]' to 'RING_ELEM[...]'; 3. For each
> > > test configuration we want to have (default, 4B, 8B, 16B)
> > > create a new .c file where we:
> > > - define used in test_ring_perf.h macros(/function)
> > > - include test_ring_perf.h
> > > - REGISTER_TEST_COMMAND(<test_name>, test_ring_perf);
> > >
> > > As an example:
> > > test_ring_perf.h:
> > > ...
> > > static int
> > > enqueue_bulk(void *p)
> > > {
> > > ...
> > > RING_ELEM burst[MAX_BURST];
> > >
> > > memset(burst, 0, sizeof(burst));
> > > ....
> > > const uint64_t sp_start = rte_rdtsc();
> > > for (i = 0; i < iterations; i++)
> > > while (RING_SP_ENQUEUE_BULK(r, burst, size, NULL) == 0)
> > > rte_pause();
> > > const uint64_t sp_end = rte_rdtsc();
> > >
> > > const uint64_t mp_start = rte_rdtsc();
> > > for (i = 0; i < iterations; i++)
> > > while (RING_MP_ENQUEUE_BULK(r, burst, size, NULL) == 0)
> > > rte_pause();
> > > const uint64_t mp_end = rte_rdtsc();
> > > ....
> > >
> > > Then in test_ring_perf.c:
> > >
> > > ....
> > > #define RING_ELEM void *
> > > ...
> > > #define RING_SP_ENQUEUE_BULK(ring, buf, size, spc) \
> > > rte_ring_sp_enqueue_bulk(ring, buf, size, spc) ....
> > >
> > > #include "test_ring_perf.h"
> > > REGISTER_TEST_COMMAND(ring_perf_autotest, test_ring_perf);
> > >
> > >
> > > In test_ring_elem16B_perf.c:
> > > ....
> > > #define RING_ELEM __uint128_t
> > > #define RING_SP_ENQUEUE_BULK(ring, buf, size, spc) \
> > > rte_ring_sp_enqueue_bulk_elem(ring, buf, sizeof(RING_ELEM), size,
> > > spc) ....
> > > #include "test_ring_perf.h"
> > > REGISTER_TEST_COMMAND(ring_perf_elem16B_autotest, test_ring_perf);
> > >
> > > In test_ring_elem4B_per.c:
> > >
> > > ....
> > > #define RING_ELEM uint32_t
> > > #define RING_SP_ENQUEUE_BULK(ring, buf, size, spc) \
> > > rte_ring_sp_enqueue_bulk_elem(ring, buf, sizeof(RING_ELEM), size,
> > > spc) ....
> > > #include "test_ring_perf.h"
> > > REGISTER_TEST_COMMAND(ring_perf_elem4B_autotest, test_ring_perf);
> > >
> > > And so on.
This will result in additional test files.
> > >
> > > > +
> > > > +/* This function is placed here as it is required for both
> > > > + * performance and functional tests.
> > > > + */
> > > > +static __rte_always_inline void * test_ring_calloc(unsigned int
> > > > +rsize, int esize) {
> > > > + unsigned int sz;
> > > > + void *p;
> > > > +
> > > > + /* Legacy queue APIs? */
> > > > + if (esize == -1)
> > > > + sz = sizeof(void *);
> > > > + else
> > > > + sz = esize;
> > > > +
> > > > + p = rte_zmalloc(NULL, rsize * sz, RTE_CACHE_LINE_SIZE);
> > > > + if (p == NULL)
> > > > + printf("Failed to allocate memory\n");
> > > > +
> > > > + return p;
> > > > +}
> > > > --
> > > > 2.17.1
next prev parent reply other threads:[~2020-01-09 5:15 UTC|newest]
Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 14:46 [dpdk-dev] [PATCH 0/5] lib/ring: templates to support custom element size Honnappa Nagarahalli
2019-08-28 14:46 ` [dpdk-dev] [PATCH 1/5] lib/ring: apis to support configurable " Honnappa Nagarahalli
2019-08-28 14:46 ` [dpdk-dev] [PATCH 2/5] lib/ring: add template to support different element sizes Honnappa Nagarahalli
2019-10-01 11:47 ` Ananyev, Konstantin
2019-10-02 4:21 ` Honnappa Nagarahalli
2019-10-02 8:39 ` Ananyev, Konstantin
2019-10-03 3:33 ` Honnappa Nagarahalli
2019-10-03 11:51 ` Ananyev, Konstantin
2019-10-03 12:27 ` Ananyev, Konstantin
2019-10-03 22:49 ` Honnappa Nagarahalli
2019-08-28 14:46 ` [dpdk-dev] [PATCH 3/5] tools/checkpatch: relax constraints on __rte_experimental Honnappa Nagarahalli
2019-08-28 14:46 ` [dpdk-dev] [PATCH 4/5] lib/ring: add ring APIs to support 32b ring elements Honnappa Nagarahalli
2019-08-28 14:46 ` [dpdk-dev] [PATCH 5/5] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2019-08-28 15:12 ` [dpdk-dev] [PATCH 0/5] lib/ring: templates to support custom element size Jerin Jacob Kollanukkaran
2019-08-28 15:16 ` Pavan Nikhilesh Bhagavatula
2019-08-28 22:59 ` Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 0/6] " Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 1/6] lib/ring: apis to support configurable " Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support different element sizes Honnappa Nagarahalli
2019-09-08 19:44 ` Stephen Hemminger
2019-09-09 9:01 ` Bruce Richardson
2019-09-09 22:33 ` Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 3/6] tools/checkpatch: relax constraints on __rte_experimental Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 4/6] lib/ring: add ring APIs to support 32b ring elements Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 5/6] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2019-09-06 19:05 ` [dpdk-dev] [PATCH v2 6/6] lib/eventdev: use ring templates for event rings Honnappa Nagarahalli
2019-09-09 13:04 ` [dpdk-dev] [PATCH v2 0/6] lib/ring: templates to support custom element size Aaron Conole
2019-10-07 13:49 ` David Marchand
2019-10-08 19:19 ` [dpdk-dev] [PATCH v3 0/2] lib/ring: APIs " Honnappa Nagarahalli
2019-10-08 19:19 ` [dpdk-dev] [PATCH v3 1/2] lib/ring: apis to support configurable " Honnappa Nagarahalli
2019-10-08 19:19 ` [dpdk-dev] [PATCH v3 2/2] test/ring: add test cases for configurable element size ring Honnappa Nagarahalli
2019-10-09 2:47 ` [dpdk-dev] [PATCH v3 0/2] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2019-10-09 2:47 ` [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable " Honnappa Nagarahalli
2019-10-11 19:21 ` Honnappa Nagarahalli
2019-10-14 19:41 ` Ananyev, Konstantin
2019-10-14 23:56 ` Honnappa Nagarahalli
2019-10-15 9:34 ` Ananyev, Konstantin
2019-10-17 4:46 ` Honnappa Nagarahalli
2019-10-17 11:51 ` Ananyev, Konstantin
2019-10-17 20:16 ` Honnappa Nagarahalli
2019-10-17 23:17 ` David Christensen
2019-10-18 3:18 ` Honnappa Nagarahalli
2019-10-18 8:04 ` Jerin Jacob
2019-10-18 16:11 ` Jerin Jacob
2019-10-21 0:27 ` Honnappa Nagarahalli
2019-10-18 16:44 ` Ananyev, Konstantin
2019-10-18 19:03 ` Honnappa Nagarahalli
2019-10-21 0:36 ` Honnappa Nagarahalli
2019-10-21 9:04 ` Ananyev, Konstantin
2019-10-22 15:59 ` Ananyev, Konstantin
2019-10-22 17:57 ` Ananyev, Konstantin
2019-10-23 18:58 ` Honnappa Nagarahalli
2019-10-18 17:23 ` David Christensen
2019-10-09 2:47 ` [dpdk-dev] [PATCH v4 2/2] test/ring: add test cases for configurable element size ring Honnappa Nagarahalli
2019-10-17 20:08 ` [dpdk-dev] [PATCH v5 0/3] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2019-10-17 20:08 ` [dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support configurable " Honnappa Nagarahalli
2019-10-17 20:39 ` Stephen Hemminger
2019-10-17 20:40 ` Stephen Hemminger
2019-10-17 20:08 ` [dpdk-dev] [PATCH v5 2/3] test/ring: add test cases for configurable element size ring Honnappa Nagarahalli
2019-10-17 20:08 ` [dpdk-dev] [PATCH v5 3/3] lib/ring: copy ring elements using memcpy partially Honnappa Nagarahalli
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 0/6] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 1/6] test/ring: use division for cycle count calculation Honnappa Nagarahalli
2019-10-23 9:49 ` Olivier Matz
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 2/6] lib/ring: apis to support configurable element size Honnappa Nagarahalli
2019-10-23 9:59 ` Olivier Matz
2019-10-23 19:12 ` Honnappa Nagarahalli
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 3/6] test/ring: add functional tests for configurable element size ring Honnappa Nagarahalli
2019-10-23 10:01 ` Olivier Matz
2019-10-23 11:12 ` Ananyev, Konstantin
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 4/6] test/ring: add perf " Honnappa Nagarahalli
2019-10-23 10:02 ` Olivier Matz
2019-10-21 0:22 ` [dpdk-dev] [RFC v6 5/6] lib/ring: copy ring elements using memcpy partially Honnappa Nagarahalli
2019-10-21 0:23 ` [dpdk-dev] [RFC v6 6/6] lib/ring: improved copy function to copy ring elements Honnappa Nagarahalli
2019-10-23 10:05 ` Olivier Matz
2019-10-23 9:48 ` [dpdk-dev] [RFC v6 0/6] lib/ring: APIs to support custom element size Olivier Matz
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 00/17] " Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 01/17] test/ring: use division for cycle count calculation Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size Honnappa Nagarahalli
2020-01-02 16:42 ` Ananyev, Konstantin
2020-01-07 5:35 ` Honnappa Nagarahalli
2020-01-07 6:00 ` Honnappa Nagarahalli
2020-01-07 10:21 ` Ananyev, Konstantin
2020-01-07 15:21 ` Honnappa Nagarahalli
2020-01-07 15:41 ` Ananyev, Konstantin
2020-01-08 6:17 ` Honnappa Nagarahalli
2020-01-08 10:05 ` Ananyev, Konstantin
2020-01-08 23:40 ` Honnappa Nagarahalli
2020-01-09 0:48 ` Ananyev, Konstantin
2020-01-09 16:06 ` Honnappa Nagarahalli
2020-01-13 11:53 ` Ananyev, Konstantin
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 03/17] test/ring: add functional tests for rte_ring_xxx_elem APIs Honnappa Nagarahalli
2020-01-02 16:31 ` Ananyev, Konstantin
2020-01-07 5:13 ` Honnappa Nagarahalli
2020-01-07 16:03 ` Ananyev, Konstantin
2020-01-09 5:15 ` Honnappa Nagarahalli [this message]
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 04/17] test/ring: test burst APIs with random empty-full test case Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 05/17] test/ring: add default, single element test cases Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 06/17] test/ring: rte_ring_xxx_elem test cases for exact size ring Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 07/17] test/ring: negative test cases for rte_ring_xxx_elem APIs Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 08/17] test/ring: remove duplicate test cases Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 09/17] test/ring: removed unused variable synchro Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 10/17] test/ring: modify single element enq/deq perf test cases Honnappa Nagarahalli
2020-01-02 17:03 ` Ananyev, Konstantin
2020-01-07 5:54 ` Honnappa Nagarahalli
2020-01-07 16:13 ` Ananyev, Konstantin
2020-01-07 22:33 ` Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 11/17] test/ring: modify burst " Honnappa Nagarahalli
2020-01-02 16:57 ` Ananyev, Konstantin
2020-01-07 5:42 ` Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 12/17] test/ring: modify bulk " Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 13/17] test/ring: modify bulk empty deq " Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 14/17] test/ring: modify multi-lcore " Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 15/17] test/ring: adjust run-on-all-cores " Honnappa Nagarahalli
2020-01-02 17:00 ` Ananyev, Konstantin
2020-01-07 5:42 ` Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 16/17] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2019-12-20 4:45 ` [dpdk-dev] [PATCH v7 17/17] lib/eventdev: use custom element size ring for event rings Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 0/6] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 1/6] test/ring: use division for cycle count calculation Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 2/6] lib/ring: apis to support configurable element size Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 4/6] test/ring: modify perf test cases to use " Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 5/6] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2020-01-13 17:25 ` [dpdk-dev] [PATCH v8 6/6] lib/eventdev: use custom element size ring for event rings Honnappa Nagarahalli
[not found] ` <1578977880-13011-1-git-send-email-robot@bytheb.org>
[not found] ` <VE1PR08MB5149BE79083CD66A41CBD6D198340@VE1PR08MB5149.eurprd08.prod.outlook.com>
2020-01-14 15:12 ` [dpdk-dev] FW: || pw64572 " Aaron Conole
2020-01-14 16:51 ` Aaron Conole
2020-01-14 19:35 ` Honnappa Nagarahalli
2020-01-14 20:44 ` Aaron Conole
2020-01-15 0:55 ` Honnappa Nagarahalli
2020-01-15 4:43 ` Honnappa Nagarahalli
2020-01-15 5:05 ` Honnappa Nagarahalli
2020-01-15 18:22 ` Aaron Conole
2020-01-15 18:38 ` Honnappa Nagarahalli
2020-01-16 5:27 ` Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 0/6] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 1/6] test/ring: use division for cycle count calculation Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 2/6] lib/ring: apis to support configurable element size Honnappa Nagarahalli
2020-01-17 16:34 ` Olivier Matz
2020-01-17 16:45 ` Honnappa Nagarahalli
2020-01-17 18:10 ` David Christensen
2020-01-18 12:32 ` Ananyev, Konstantin
2020-01-18 15:01 ` Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs Honnappa Nagarahalli
2020-01-17 17:03 ` Olivier Matz
2020-01-18 16:27 ` Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 4/6] test/ring: modify perf test cases to use " Honnappa Nagarahalli
2020-01-17 17:12 ` Olivier Matz
2020-01-18 16:28 ` Honnappa Nagarahalli
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 5/6] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2020-01-17 20:27 ` David Marchand
2020-01-17 20:54 ` Honnappa Nagarahalli
2020-01-17 21:07 ` David Marchand
2020-01-17 22:24 ` Wang, Yipeng1
2020-01-16 5:25 ` [dpdk-dev] [PATCH v9 6/6] lib/eventdev: use custom element size ring for event rings Honnappa Nagarahalli
2020-01-17 14:41 ` Jerin Jacob
2020-01-17 16:12 ` David Marchand
2020-01-16 16:36 ` [dpdk-dev] [PATCH v9 0/6] lib/ring: APIs to support custom element size Honnappa Nagarahalli
2020-01-17 12:14 ` David Marchand
2020-01-17 13:34 ` Jerin Jacob
2020-01-17 16:37 ` Mattias Rönnblom
2020-01-17 14:28 ` Honnappa Nagarahalli
2020-01-17 14:36 ` Honnappa Nagarahalli
2020-01-17 16:15 ` David Marchand
2020-01-17 16:32 ` Honnappa Nagarahalli
2020-01-17 17:15 ` Olivier Matz
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 " Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 1/6] test/ring: use division for cycle count calculation Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 2/6] lib/ring: apis to support configurable element size Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 4/6] test/ring: modify perf test cases to use " Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 5/6] lib/hash: use ring with 32b element size to save memory Honnappa Nagarahalli
2020-01-18 19:32 ` [dpdk-dev] [PATCH v10 6/6] eventdev: use custom element size ring for event rings Honnappa Nagarahalli
2020-01-19 19:31 ` [dpdk-dev] [PATCH v10 0/6] lib/ring: APIs to support custom element size David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB5138D05219583F571A78266A98390@AM0PR08MB5138.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@marvell.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).