Re: [dpdk-dev] [PATCH] Pktgen: Add build option to enable/disable AVX2 support

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

Hi Bruce,

Yes it is for pktgen. I just updated the title (hope that this will be picked up by patchwork).
BTW: That's something to mention in the contributing guide of Pktgen as well.

Best regards,
Felix

> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, October 27, 2020 12:47 PM
> To: Moessbauer, Felix (T RDA IOT SES-DE) <felix.moessbauer@siemens.com>
> Cc: keith.wiles@intel.com; dev@dpdk.org; Schild, Henning (T RDA IOT SES-DE)
> <henning.schild@siemens.com>
> Subject: Re: [dpdk-dev] [PATCH] Add build option to enable/disable AVX2
> support
> 
> On Mon, Oct 26, 2020 at 03:30:27PM +0100, Felix Moessbauer wrote:
> > This patch introduces a meson option to disable the AVX2 support.
> > If the build should be for a target without AVX2 support, the know can
> > be turned to false, even if the compiler supports AVX2.
> >
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >  meson.build       | 3 ++-
> >  meson_options.txt | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build index 0ee98be..2e2380c 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -18,7 +18,8 @@ pktgen_conf = configuration_data()  cc =
> > meson.get_compiler('c')
> >
> >  add_project_arguments('-march=native', language: 'c') -if
> > cc.has_argument('-mavx2')
> > +
> > +if get_option('enable-avx2') and cc.has_argument('-mavx2')
> >  	add_project_arguments('-mavx2', language: 'c')  endif
> > add_project_arguments('-DALLOW_EXPERIMENTAL_API', language: 'c')
> 
> Hi,
> 
> This code does not appear in the upstream DPDK project [1]. This looks like a
> pktgen patch instead, is this the case? If so, please put pktgen somewhere in the
> patch title to make it easier to disposition.
> 
> Thanks,
> /Bruce
> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.dpdk.o
> rg%2Fdpdk%2Ftree%2Fmeson.build&amp;data=04%7C01%7Cfelix.moessbauer%
> 40siemens.com%7C141d2e3bc7e9428d2c3408d87a6e1046%7C38ae3bcd95794f
> d4addab42e1495d55a%7C1%7C0%7C637393960453313238%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C1000&amp;sdata=CxGRxOe4dTDQgMhQbCQdwMyYGBwbm%2
> FldUC2bmTHg2xE%3D&amp;reserved=0