From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED5AA04B5; Tue, 27 Oct 2020 12:51:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DF132BF4; Tue, 27 Oct 2020 12:51:38 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80]) by dpdk.org (Postfix) with ESMTP id 0B6F32BEA for ; Tue, 27 Oct 2020 12:51:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2rAsbw8dWeWWzK69B+PXbqw+GJ5QCstis7m1vwKhz8+mqqE/Ucqiz45d8hxJBtlu6ZHsQbJKIr6Wrv2bLZCH5Ln7I/Ey45mbX0xElY9bT92CEns8/D+I58RMkBCDkdmw9Nn+jef7F2gQZmZdZXyR38nKVRSw1Prd9X5BM+vE2CIeCWbJHKRlj1TcQDNKuvfoVwYCp7ek5Zaj4lw1NZwrv4ja6wqF804iOtbayj2WDrMULs2fOu708HzQ6klktTopvdCkepaW7ytVkhcXz83fkfwE9M/X8yS6GBYRhkRmpHWyzLpHKJSgvSAUtWHsxm4QWN0+GfTiBKm22wl6sM5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7xBM0fFyQMnhUjSjQzPuAzLpFYPEkru1xyo1GH2AQk=; b=R5DMJfKvv5kuS5YndvFxhe30MUxGnoTul8UWdRx+EHUjpAvd3Wdq+BqoHnyKeoYHxgH1nxGN2AhYXv6Ag3lUGebFW99FsX1ozG0Dl5/kXcJ+3WRGoR5DYBwjz+W7S/PpLiIzHH8zIb08AyE2ksKUil0zjwptE8CANGDw/Pk1vgkct8IgOkBSmHQ7toGge96bTNzvfn2pIEw82sZmzRmcKkKX0scWvEXxj6QKN82BYet9BiCgpDC4XflrWjWhAuL5Ls+PZoOa8othZZGPf+ZxZykXd3X9q1ydgi/dwXaZxn7t22fQGfuu3B9FwzN2bk/G4w1oLXO6muCZPUhEe6ikuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a7xBM0fFyQMnhUjSjQzPuAzLpFYPEkru1xyo1GH2AQk=; b=CSGcLqWKZDM1ZtLyxIAbPZSr/dNY2pHcSiDX08VDXt0dQTqoNGsVXJJ3daq6tyPPZkRhYTUXYCgNepmYMBO21fQkcpRXIc6a1qTVnMAaervfMyPR79SUUSC+b2P52KqW53NoqQI1sAyFTDV5LJnFRn61LXJfsih+LdDQGsPx4u0= Received: from AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:44::22) by AM9PR10MB4310.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Tue, 27 Oct 2020 11:51:29 +0000 Received: from AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM ([fe80::3c42:176a:d4f7:bfad]) by AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM ([fe80::3c42:176a:d4f7:bfad%3]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 11:51:29 +0000 From: "Moessbauer, Felix" To: Bruce Richardson CC: "keith.wiles@intel.com" , "dev@dpdk.org" , "henning.schild@siemens.com" Thread-Topic: [dpdk-dev] [PATCH] Pktgen: Add build option to enable/disable AVX2 support Thread-Index: AdasVzHRWhDnAaj4Q+SH9qmu2LvgHA== Content-Class: Date: Tue, 27 Oct 2020 11:51:29 +0000 Message-ID: Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2020-10-27T11:51:27Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=b5d6d2e4-9cbd-4d1d-bb92-85c7ebb14332; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=siemens.com; x-originating-ip: [165.225.200.175] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a2560eaf-e9b9-47d7-12d6-08d87a6ea45e x-ms-traffictypediagnostic: AM9PR10MB4310: x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0sB3B329YamNgWZxg0f023Xds3bGFxXeRAiysXJTLAuwCjnNYqzACFDlI5Pb3gqsxtMKqV/BXEzpnV4QO9oGcvi+GTKOAXb7+nF641W8UbE86v9H/eJJaWfIZEWe3eVQpMZgIGVroj2aVagGTnD8ibkDC0hW1dylFPCbY31Rgv/2IioLHe1QCP9udv7wpJ0QbkS+2CTx7qBy81NncseDKHSJiVjooZiyUSUUiWBOzSRdbcrR3FZvOhkGuvO24rYUxnLiADxRoaVhmuqGoBF+5Si3z5GiJoYCM0zRpPAIUEK7GgIkQ3ustpXJxoSnDvgho3TmovpCdyDHCyzDNr3s+VUBRIYLnrzMrqhYL2jAXFo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(66556008)(966005)(26005)(7696005)(66446008)(66476007)(66946007)(107886003)(64756008)(55016002)(71200400001)(76116006)(8676002)(8936002)(186003)(54906003)(9686003)(316002)(4326008)(5660300002)(55236004)(33656002)(83380400001)(478600001)(6916009)(2906002)(86362001)(52536014)(45080400002)(53546011)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: f/0sBboLgHr1dSwq9rmojGKypG7J2EC9J1SH/TVPV+pZnxVwLUlLHkIBCOwKkEMPvDE3QvQ0PGdnAajcjAzvDSJnkz27rZARsa1FKGrx2s2tEcmLri/UTvk0CAuMVkESioe4P8K2W2Xc9l5NgkDbMKMZIL2e4INDkfD0dgrV2mhp54UL3hHSAayzNqcbx5873j7ED5ESVCnSHfSzUdlxLkx1r+lKHhxYdUVlwNTXlkv4roYdyOBHNn3aP9Ki7/RS91uznD4ywV5fu6pBnv9OjWVA3vMjNIXZ4/waWxjK9uAj8KDGVf88AMnwP6zLTrcL/g7yWj41B/s0CvbsDTkWMA3pqZFneovjPZlenP+xaQbuQozi2FN5Q2ZLfgd9+6uRHQzQiXoF4C/uMsmkcRd70n/W3YcbtfzD4/6pFK0WKK6AVjgc5vELJ0oAYyjuioce0I3P56BpBSqVxuQk/GBDn7FwFZbFqVrxT9XstbSyeaCqCEHHeshJTDT4Q4oSYm2xXGdM32kkiTWtMCpXYaTHr+BAcg64jaZ6F3OMxZHlwoHhAQgJ9AZvXfWgBu+ZK2xsnmMOVzbPPVqb2pn2+a5c573hznZ3ZJoUJpIbJSDqIYK9gLz+WGlr9HBisDGMmIlcyFDOvIA+CQooEMP7A1+V0A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a2560eaf-e9b9-47d7-12d6-08d87a6ea45e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 11:51:29.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WPFCPZsv6y91K/CBzdiD0PyzdTuqZqmUrpwbULSKjK/lCGui2hHQMR1ztt9Zgd8Ixg5FjWZOWtQvBf9lu6A9jBEqn7UmS+kEDfoTHiiAIOU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4310 Subject: Re: [dpdk-dev] [PATCH] Pktgen: Add build option to enable/disable AVX2 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, Yes it is for pktgen. I just updated the title (hope that this will be pick= ed up by patchwork). BTW: That's something to mention in the contributing guide of Pktgen as wel= l. Best regards, Felix > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, October 27, 2020 12:47 PM > To: Moessbauer, Felix (T RDA IOT SES-DE) > Cc: keith.wiles@intel.com; dev@dpdk.org; Schild, Henning (T RDA IOT SES-D= E) > > Subject: Re: [dpdk-dev] [PATCH] Add build option to enable/disable AVX2 > support >=20 > On Mon, Oct 26, 2020 at 03:30:27PM +0100, Felix Moessbauer wrote: > > This patch introduces a meson option to disable the AVX2 support. > > If the build should be for a target without AVX2 support, the know can > > be turned to false, even if the compiler supports AVX2. > > > > Signed-off-by: Felix Moessbauer > > --- > > meson.build | 3 ++- > > meson_options.txt | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build index 0ee98be..2e2380c 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -18,7 +18,8 @@ pktgen_conf =3D configuration_data() cc =3D > > meson.get_compiler('c') > > > > add_project_arguments('-march=3Dnative', language: 'c') -if > > cc.has_argument('-mavx2') > > + > > +if get_option('enable-avx2') and cc.has_argument('-mavx2') > > add_project_arguments('-mavx2', language: 'c') endif > > add_project_arguments('-DALLOW_EXPERIMENTAL_API', language: 'c') >=20 > Hi, >=20 > This code does not appear in the upstream DPDK project [1]. This looks li= ke a > pktgen patch instead, is this the case? If so, please put pktgen somewher= e in the > patch title to make it easier to disposition. >=20 > Thanks, > /Bruce >=20 > [1] > https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgit.dp= dk.o > rg%2Fdpdk%2Ftree%2Fmeson.build&data=3D04%7C01%7Cfelix.moessbauer% > 40siemens.com%7C141d2e3bc7e9428d2c3408d87a6e1046%7C38ae3bcd95794f > d4addab42e1495d55a%7C1%7C0%7C637393960453313238%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6Mn0%3D%7C1000&sdata=3DCxGRxOe4dTDQgMhQbCQdwMyYGBwbm%2 > FldUC2bmTHg2xE%3D&reserved=3D0