From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88]) by dpdk.org (Postfix) with ESMTP id 730151B3DD for ; Sat, 14 Oct 2017 08:07:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+owLzKI1Pz8/QlnFtJoCa+zz6wDGVsqpmc1Dpyj0dec=; b=irEHKesjratJGsMwagjfItFE+OBK7ykI1PRqv6iIhRZS7ZjlO6jXyFdqgYKwr0pYX+YbT9oVkK8AHfNEPNaQD5DhD0XAZbgaPSdeSwVv5YSz6/Bw8fZd5TCscruaJdEJgP/JuCSPamJl0nBPwUOiZiAKTwvVihfiZUvPUq7z818= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0754.eurprd04.prod.outlook.com (10.160.56.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 14 Oct 2017 06:07:40 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::ac7b:f458:e37:269a]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::ac7b:f458:e37:269a%14]) with mapi id 15.20.0077.021; Sat, 14 Oct 2017 06:07:39 +0000 From: Hemant Agrawal To: Santosh Shukla , "olivier.matz@6wind.com" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" Thread-Topic: Shared compilation issue - mempool/octeontx: add build and log infrastructure Thread-Index: AdNEsPkByE2DrrkRR0C3yoEUT/BBuA== Date: Sat, 14 Oct 2017 06:07:39 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0754; 6:JxD4i/TCeET4mGddwNqd/n2Lz4fYhARkwuADUN0MzdEOHtSPcMlR5a8zOpk6Cg9veZJaXcktfMvnCLihmsYqpjqQT/K2Sr+9DjMNcm/LrmSfLvAxKa9LhqYZajrsxiYCq4UkdW+1LY/l0Z6bZrBShYM4LVdS8LcxsTtu/sg6cqnsGE+wqOazCEz5CP87E3dPJXRID1lz5/XddCYbx7A6JZEcILSo15VKe3mvI5X31HFHQMWLg3Ljw3s8P4lmiWcm7spmmThq2+RmtgpNrzkXjtB26NBHdkW/6CQFK+j9I+ARO3jDjYSVPHPfKpbIH/gbKiOHqicuaZfBwd36Pf24Jg==; 5:MCDMKlDTbbJRfdFWEDcROQEb1aITlXbDQyb/NRazyCGvhgWIdJzzgV0iPzkNe7f419koK25AeINyQdRB/FdwnThwdtJ22J+ZUseE2LO25MvHBrDOrx5qMNGD2qE6NIb+bn45cRx5iBFUeJoRJGQPMA==; 24:4gFYdPsTPY5ucnp6YfHw2OKN2WQHz8+aaaNpl8bPmBl+JgivV6aAA3pwjeRfD+DP6Agj9gL7u2GL3TQHtdOjREvNd/Zz0SZxlCiOehqg6Yc=; 7:mYMo2F4D3q0hlxP6s9s1L47L78OL6H13Arxvcd3FF90pchYA3exTi+hS9QVCPng7o+pyT9yzhOy16RvDqLmaQ6lFGlUan4YaonfEv/50jrOCWcj+smHCd+uwoR6eRKZS1wm29JD6CnA7fNRdWK8wPzqjtw6rzw7yFMOlTcl9r5ZQdka8Ya3C2RfzEvf22RK8ZwoBVMVNfNIFBP7AZv1WI9TI0yygkRgJb05OoPfcB+8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 081ec749-de08-4c30-cb38-08d512c9dffe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM2PR04MB0754; x-ms-traffictypediagnostic: AM2PR04MB0754: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM2PR04MB0754; x-forefront-prvs: 046060344D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(199003)(74316002)(50986999)(5250100002)(53936002)(6436002)(966005)(189998001)(14454004)(54356999)(110136005)(54906003)(25786009)(7696004)(55016002)(5660300001)(6306002)(99286003)(9686003)(33656002)(68736007)(478600001)(101416001)(2501003)(6506006)(2900100001)(316002)(2201001)(102836003)(3846002)(6116002)(105586002)(97736004)(106356001)(3660700001)(3280700002)(2906002)(66066001)(53376002)(305945005)(7736002)(8936002)(4326008)(8676002)(86362001)(81166006)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0754; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2017 06:07:39.7286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754 Subject: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Oct 2017 06:07:41 -0000 Santosh/jerin, Your patch "mempool/octeontx: add build and log infrastructure" is causing= shared build failure for NXP's patch "event/dpaa2: support event eth adapt= er", which is still under review. http://dpdk.org/dev/patchwork/patch/30248/ In your patch, you have added mempool to be dependent on event, which is no= t correct. "+DEPDIRS-mempool :=3D bus event" Ideally, if you have common code, you should put that in bus or mempool . T= his way you can make event, net or sec etc dependent on bus or mempool and= not the otherway around. With the addition of ethernet adapter in the eventdev, eventdev drivers hav= e dependency on the net driver.=20 e.g dpaa2 event dev is dependent on dpaa2 net driver, but your patch caus= es cyclic dependency.=20 You may also face this issue, once you implement the ethernet adapter suppo= rt in eventdev.=20 Please look into this issue. =20 I suggest you to move the common code to mempool itself or to bus.=20 Regards, Hemant diff --git a/drivers/Makefile b/drivers/Makefile index 7fef66d..bc2d082 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -32,13 +32,13 @@ include $(RTE_SDK)/mk/rte.vars.mk DIRS-y +=3D bus +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D event +DEPDIRS-event :=3D bus DIRS-y +=3D mempool -DEPDIRS-mempool :=3D bus +DEPDIRS-mempool :=3D bus event DIRS-y +=3D net DEPDIRS-net :=3D bus mempool DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) +=3D crypto DEPDIRS-crypto :=3D mempool -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D event -DEPDIRS-event :=3D bus