* [dpdk-dev] [PATCH] rawdev: remove experimental flag
@ 2018-06-14 13:19 Shreyansh Jain
2018-07-16 6:18 ` Hemant Agrawal
0 siblings, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2018-06-14 13:19 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Shreyansh Jain
Besides the librawdev, removing experimental from skeleton_rawdev
dummy driver as well.
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Note: Dependent drivers, (dpaa2_cmdif, dpaa2_qdma and ifpga) cannot be
updated in this patch as are dependent on some other symbols
(rte_mem_virt2memseg and rte_eal_hotplug_*).
drivers/raw/skeleton_rawdev/Makefile | 1 -
drivers/raw/skeleton_rawdev/meson.build | 2 -
lib/librte_rawdev/Makefile | 1 -
lib/librte_rawdev/meson.build | 1 -
lib/librte_rawdev/rte_rawdev.c | 56 ++++++++++++------------
lib/librte_rawdev/rte_rawdev.h | 54 +++++++++++------------
lib/librte_rawdev/rte_rawdev_pmd.h | 8 ++--
lib/librte_rawdev/rte_rawdev_version.map | 2 +-
8 files changed, 60 insertions(+), 65 deletions(-)
diff --git a/drivers/raw/skeleton_rawdev/Makefile b/drivers/raw/skeleton_rawdev/Makefile
index bacc66dd0..3f97c2ee0 100644
--- a/drivers/raw/skeleton_rawdev/Makefile
+++ b/drivers/raw/skeleton_rawdev/Makefile
@@ -8,7 +8,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
#
LIB = librte_pmd_skeleton_rawdev.a
-CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
LDLIBS += -lrte_eal
diff --git a/drivers/raw/skeleton_rawdev/meson.build b/drivers/raw/skeleton_rawdev/meson.build
index 7cb2d3fb1..b4a6ed08a 100644
--- a/drivers/raw/skeleton_rawdev/meson.build
+++ b/drivers/raw/skeleton_rawdev/meson.build
@@ -4,5 +4,3 @@
deps += ['rawdev', 'kvargs', 'mbuf', 'bus_vdev']
sources = files('skeleton_rawdev.c',
'skeleton_rawdev_test.c')
-
-allow_experimental_apis = true
diff --git a/lib/librte_rawdev/Makefile b/lib/librte_rawdev/Makefile
index b9105b060..addb288d7 100644
--- a/lib/librte_rawdev/Makefile
+++ b/lib/librte_rawdev/Makefile
@@ -10,7 +10,6 @@ LIB = librte_rawdev.a
LIBABIVER := 1
# build flags
-CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
LDLIBS += -lrte_eal
diff --git a/lib/librte_rawdev/meson.build b/lib/librte_rawdev/meson.build
index dcd37ad49..a20fbdc04 100644
--- a/lib/librte_rawdev/meson.build
+++ b/lib/librte_rawdev/meson.build
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
-allow_experimental_apis = true
sources = files('rte_rawdev.c')
headers = files('rte_rawdev.h', 'rte_rawdev_pmd.h')
diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c
index 284e6aec8..00feb4ebe 100644
--- a/lib/librte_rawdev/rte_rawdev.c
+++ b/lib/librte_rawdev/rte_rawdev.c
@@ -46,13 +46,13 @@ static struct rte_rawdev_global rawdev_globals = {
struct rte_rawdev_global *rte_rawdev_globals = &rawdev_globals;
/* Raw device, northbound API implementation */
-uint8_t __rte_experimental
+uint8_t
rte_rawdev_count(void)
{
return rte_rawdev_globals->nb_devs;
}
-uint16_t __rte_experimental
+uint16_t
rte_rawdev_get_dev_id(const char *name)
{
uint16_t i;
@@ -69,7 +69,7 @@ rte_rawdev_get_dev_id(const char *name)
return -ENODEV;
}
-int __rte_experimental
+int
rte_rawdev_socket_id(uint16_t dev_id)
{
struct rte_rawdev *dev;
@@ -80,7 +80,7 @@ rte_rawdev_socket_id(uint16_t dev_id)
return dev->socket_id;
}
-int __rte_experimental
+int
rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info)
{
struct rte_rawdev *rawdev;
@@ -102,7 +102,7 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info)
return 0;
}
-int __rte_experimental
+int
rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf)
{
struct rte_rawdev *dev;
@@ -131,7 +131,7 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf)
return diag;
}
-int __rte_experimental
+int
rte_rawdev_queue_conf_get(uint16_t dev_id,
uint16_t queue_id,
rte_rawdev_obj_t queue_conf)
@@ -146,7 +146,7 @@ rte_rawdev_queue_conf_get(uint16_t dev_id,
return 0;
}
-int __rte_experimental
+int
rte_rawdev_queue_setup(uint16_t dev_id,
uint16_t queue_id,
rte_rawdev_obj_t queue_conf)
@@ -160,7 +160,7 @@ rte_rawdev_queue_setup(uint16_t dev_id,
return (*dev->dev_ops->queue_setup)(dev, queue_id, queue_conf);
}
-int __rte_experimental
+int
rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id)
{
struct rte_rawdev *dev;
@@ -172,7 +172,7 @@ rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id)
return (*dev->dev_ops->queue_release)(dev, queue_id);
}
-int __rte_experimental
+int
rte_rawdev_get_attr(uint16_t dev_id,
const char *attr_name,
uint64_t *attr_value)
@@ -186,7 +186,7 @@ rte_rawdev_get_attr(uint16_t dev_id,
return (*dev->dev_ops->attr_get)(dev, attr_name, attr_value);
}
-int __rte_experimental
+int
rte_rawdev_set_attr(uint16_t dev_id,
const char *attr_name,
const uint64_t attr_value)
@@ -200,7 +200,7 @@ rte_rawdev_set_attr(uint16_t dev_id,
return (*dev->dev_ops->attr_set)(dev, attr_name, attr_value);
}
-int __rte_experimental
+int
rte_rawdev_enqueue_buffers(uint16_t dev_id,
struct rte_rawdev_buf **buffers,
unsigned int count,
@@ -215,7 +215,7 @@ rte_rawdev_enqueue_buffers(uint16_t dev_id,
return (*dev->dev_ops->enqueue_bufs)(dev, buffers, count, context);
}
-int __rte_experimental
+int
rte_rawdev_dequeue_buffers(uint16_t dev_id,
struct rte_rawdev_buf **buffers,
unsigned int count,
@@ -230,7 +230,7 @@ rte_rawdev_dequeue_buffers(uint16_t dev_id,
return (*dev->dev_ops->dequeue_bufs)(dev, buffers, count, context);
}
-int __rte_experimental
+int
rte_rawdev_dump(uint16_t dev_id, FILE *f)
{
struct rte_rawdev *dev;
@@ -251,7 +251,7 @@ xstats_get_count(uint16_t dev_id)
return (*dev->dev_ops->xstats_get_names)(dev, NULL, 0);
}
-int __rte_experimental
+int
rte_rawdev_xstats_names_get(uint16_t dev_id,
struct rte_rawdev_xstats_name *xstats_names,
unsigned int size)
@@ -274,7 +274,7 @@ rte_rawdev_xstats_names_get(uint16_t dev_id,
}
/* retrieve rawdev extended statistics */
-int __rte_experimental
+int
rte_rawdev_xstats_get(uint16_t dev_id,
const unsigned int ids[],
uint64_t values[],
@@ -287,7 +287,7 @@ rte_rawdev_xstats_get(uint16_t dev_id,
return (*dev->dev_ops->xstats_get)(dev, ids, values, n);
}
-uint64_t __rte_experimental
+uint64_t
rte_rawdev_xstats_by_name_get(uint16_t dev_id,
const char *name,
unsigned int *id)
@@ -306,7 +306,7 @@ rte_rawdev_xstats_by_name_get(uint16_t dev_id,
return (*dev->dev_ops->xstats_get_by_name)(dev, name, id);
}
-int __rte_experimental
+int
rte_rawdev_xstats_reset(uint16_t dev_id,
const uint32_t ids[], uint32_t nb_ids)
{
@@ -317,7 +317,7 @@ rte_rawdev_xstats_reset(uint16_t dev_id,
return (*dev->dev_ops->xstats_reset)(dev, ids, nb_ids);
}
-int __rte_experimental
+int
rte_rawdev_firmware_status_get(uint16_t dev_id, rte_rawdev_obj_t status_info)
{
RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
@@ -327,7 +327,7 @@ rte_rawdev_firmware_status_get(uint16_t dev_id, rte_rawdev_obj_t status_info)
return (*dev->dev_ops->firmware_status_get)(dev, status_info);
}
-int __rte_experimental
+int
rte_rawdev_firmware_version_get(uint16_t dev_id, rte_rawdev_obj_t version_info)
{
RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
@@ -337,7 +337,7 @@ rte_rawdev_firmware_version_get(uint16_t dev_id, rte_rawdev_obj_t version_info)
return (*dev->dev_ops->firmware_version_get)(dev, version_info);
}
-int __rte_experimental
+int
rte_rawdev_firmware_load(uint16_t dev_id, rte_rawdev_obj_t firmware_image)
{
RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
@@ -350,7 +350,7 @@ rte_rawdev_firmware_load(uint16_t dev_id, rte_rawdev_obj_t firmware_image)
return (*dev->dev_ops->firmware_load)(dev, firmware_image);
}
-int __rte_experimental
+int
rte_rawdev_firmware_unload(uint16_t dev_id)
{
RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
@@ -360,7 +360,7 @@ rte_rawdev_firmware_unload(uint16_t dev_id)
return (*dev->dev_ops->firmware_unload)(dev);
}
-int __rte_experimental
+int
rte_rawdev_selftest(uint16_t dev_id)
{
RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
@@ -370,7 +370,7 @@ rte_rawdev_selftest(uint16_t dev_id)
return (*dev->dev_ops->dev_selftest)();
}
-int __rte_experimental
+int
rte_rawdev_start(uint16_t dev_id)
{
struct rte_rawdev *dev;
@@ -397,7 +397,7 @@ rte_rawdev_start(uint16_t dev_id)
return 0;
}
-void __rte_experimental
+void
rte_rawdev_stop(uint16_t dev_id)
{
struct rte_rawdev *dev;
@@ -419,7 +419,7 @@ rte_rawdev_stop(uint16_t dev_id)
dev->started = 0;
}
-int __rte_experimental
+int
rte_rawdev_close(uint16_t dev_id)
{
struct rte_rawdev *dev;
@@ -438,7 +438,7 @@ rte_rawdev_close(uint16_t dev_id)
return (*dev->dev_ops->dev_close)(dev);
}
-int __rte_experimental
+int
rte_rawdev_reset(uint16_t dev_id)
{
struct rte_rawdev *dev;
@@ -465,7 +465,7 @@ rte_rawdev_find_free_device_index(void)
return RTE_RAWDEV_MAX_DEVS;
}
-struct rte_rawdev * __rte_experimental
+struct rte_rawdev *
rte_rawdev_pmd_allocate(const char *name, size_t dev_priv_size, int socket_id)
{
struct rte_rawdev *rawdev;
@@ -506,7 +506,7 @@ rte_rawdev_pmd_allocate(const char *name, size_t dev_priv_size, int socket_id)
return rawdev;
}
-int __rte_experimental
+int
rte_rawdev_pmd_release(struct rte_rawdev *rawdev)
{
int ret;
diff --git a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h
index 2e14919b5..7988e76af 100644
--- a/lib/librte_rawdev/rte_rawdev.h
+++ b/lib/librte_rawdev/rte_rawdev.h
@@ -35,7 +35,7 @@ typedef void *rte_rawdev_obj_t;
* @return
* The total number of usable raw devices.
*/
-uint8_t __rte_experimental
+uint8_t
rte_rawdev_count(void);
/**
@@ -48,7 +48,7 @@ rte_rawdev_count(void);
* Returns raw device identifier on success.
* - <0: Failure to find named raw device.
*/
-uint16_t __rte_experimental
+uint16_t
rte_rawdev_get_dev_id(const char *name);
/**
@@ -61,7 +61,7 @@ rte_rawdev_get_dev_id(const char *name);
* a default of zero if the socket could not be determined.
* -(-EINVAL) dev_id value is out of range.
*/
-int __rte_experimental
+int
rte_rawdev_socket_id(uint16_t dev_id);
/**
@@ -84,7 +84,7 @@ struct rte_rawdev_info;
* - <0: Error code returned by the driver info get function.
*
*/
-int __rte_experimental
+int
rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info);
/**
@@ -111,7 +111,7 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info);
* - 0: Success, device configured.
* - <0: Error code returned by the driver configuration function.
*/
-int __rte_experimental
+int
rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf);
@@ -137,7 +137,7 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf);
* @see rte_raw_queue_setup()
*
*/
-int __rte_experimental
+int
rte_rawdev_queue_conf_get(uint16_t dev_id,
uint16_t queue_id,
rte_rawdev_obj_t queue_conf);
@@ -160,7 +160,7 @@ rte_rawdev_queue_conf_get(uint16_t dev_id,
* - 0: Success, raw queue correctly set up.
* - <0: raw queue configuration failed
*/
-int __rte_experimental
+int
rte_rawdev_queue_setup(uint16_t dev_id,
uint16_t queue_id,
rte_rawdev_obj_t queue_conf);
@@ -180,7 +180,7 @@ rte_rawdev_queue_setup(uint16_t dev_id,
* - 0: Success, raw queue released.
* - <0: raw queue configuration failed
*/
-int __rte_experimental
+int
rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id);
/**
* Get the number of raw queues on a specific raw device
@@ -190,7 +190,7 @@ rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id);
* @return
* - The number of configured raw queues
*/
-uint16_t __rte_experimental
+uint16_t
rte_rawdev_queue_count(uint16_t dev_id);
/**
@@ -208,7 +208,7 @@ rte_rawdev_queue_count(uint16_t dev_id);
* - 0: Success, device started.
* < 0: Failure
*/
-int __rte_experimental
+int
rte_rawdev_start(uint16_t dev_id);
/**
@@ -218,7 +218,7 @@ rte_rawdev_start(uint16_t dev_id);
* @param dev_id
* Raw device identifier.
*/
-void __rte_experimental
+void
rte_rawdev_stop(uint16_t dev_id);
/**
@@ -232,7 +232,7 @@ rte_rawdev_stop(uint16_t dev_id);
* - <0 on failure to close device
* - (-EAGAIN) if device is busy
*/
-int __rte_experimental
+int
rte_rawdev_close(uint16_t dev_id);
/**
@@ -246,7 +246,7 @@ rte_rawdev_close(uint16_t dev_id);
* 0 for sucessful reset,
* !0 for failure in resetting
*/
-int __rte_experimental
+int
rte_rawdev_reset(uint16_t dev_id);
#define RTE_RAWDEV_NAME_MAX_LEN (64)
@@ -316,7 +316,7 @@ struct rte_rawdev_buf {
* - 0: on success
* - <0: on failure.
*/
-int __rte_experimental
+int
rte_rawdev_dump(uint16_t dev_id, FILE *f);
/**
@@ -338,7 +338,7 @@ rte_rawdev_dump(uint16_t dev_id, FILE *f);
* 0 for success
* !0 Error; attr_value remains untouched in case of error.
*/
-int __rte_experimental
+int
rte_rawdev_get_attr(uint16_t dev_id,
const char *attr_name,
uint64_t *attr_value);
@@ -357,7 +357,7 @@ rte_rawdev_get_attr(uint16_t dev_id,
* 0 for success
* !0 Error
*/
-int __rte_experimental
+int
rte_rawdev_set_attr(uint16_t dev_id,
const char *attr_name,
const uint64_t attr_value);
@@ -383,7 +383,7 @@ rte_rawdev_set_attr(uint16_t dev_id,
* Whether partial enqueue is failure or success is defined between app
* and driver implementation.
*/
-int __rte_experimental
+int
rte_rawdev_enqueue_buffers(uint16_t dev_id,
struct rte_rawdev_buf **buffers,
unsigned int count,
@@ -414,7 +414,7 @@ rte_rawdev_enqueue_buffers(uint16_t dev_id,
* Whether partial enqueue is failure or success is defined between app
* and driver implementation.
*/
-int __rte_experimental
+int
rte_rawdev_dequeue_buffers(uint16_t dev_id,
struct rte_rawdev_buf **buffers,
unsigned int count,
@@ -454,7 +454,7 @@ struct rte_rawdev_xstats_name {
* -ENODEV for invalid *dev_id*
* -ENOTSUP if the device doesn't support this function.
*/
-int __rte_experimental
+int
rte_rawdev_xstats_names_get(uint16_t dev_id,
struct rte_rawdev_xstats_name *xstats_names,
unsigned int size);
@@ -478,7 +478,7 @@ rte_rawdev_xstats_names_get(uint16_t dev_id,
* -ENODEV for invalid *dev_id*
* -ENOTSUP if the device doesn't support this function.
*/
-int __rte_experimental
+int
rte_rawdev_xstats_get(uint16_t dev_id,
const unsigned int ids[],
uint64_t values[],
@@ -500,7 +500,7 @@ rte_rawdev_xstats_get(uint16_t dev_id,
* - positive value or zero: the stat value
* - negative value: -EINVAL if stat not found, -ENOTSUP if not supported.
*/
-uint64_t __rte_experimental
+uint64_t
rte_rawdev_xstats_by_name_get(uint16_t dev_id,
const char *name,
unsigned int *id);
@@ -520,7 +520,7 @@ rte_rawdev_xstats_by_name_get(uint16_t dev_id,
* - zero: successfully reset the statistics to zero
* - negative value: -EINVAL invalid parameters, -ENOTSUP if not supported.
*/
-int __rte_experimental
+int
rte_rawdev_xstats_reset(uint16_t dev_id,
const uint32_t ids[],
uint32_t nb_ids);
@@ -539,7 +539,7 @@ rte_rawdev_xstats_reset(uint16_t dev_id,
* 0 for success,
* !0 for failure, `status_info` argument state is undefined
*/
-int __rte_experimental
+int
rte_rawdev_firmware_status_get(uint16_t dev_id,
rte_rawdev_obj_t status_info);
@@ -557,7 +557,7 @@ rte_rawdev_firmware_status_get(uint16_t dev_id,
* 0 for success,
* !0 for failure, `version_info` argument state is undefined
*/
-int __rte_experimental
+int
rte_rawdev_firmware_version_get(uint16_t dev_id,
rte_rawdev_obj_t version_info);
@@ -574,7 +574,7 @@ rte_rawdev_firmware_version_get(uint16_t dev_id,
* 0 for successful load
* !0 for failure to load the provided image, or image incorrect.
*/
-int __rte_experimental
+int
rte_rawdev_firmware_load(uint16_t dev_id, rte_rawdev_obj_t firmware_image);
/**
@@ -586,7 +586,7 @@ rte_rawdev_firmware_load(uint16_t dev_id, rte_rawdev_obj_t firmware_image);
* 0 for successful Unload
* !0 for failure in unloading
*/
-int __rte_experimental
+int
rte_rawdev_firmware_unload(uint16_t dev_id);
/**
@@ -599,7 +599,7 @@ rte_rawdev_firmware_unload(uint16_t dev_id);
* - -ENOTSUP if the device doesn't support selftest
* - other values < 0 on failure.
*/
-int __rte_experimental
+int
rte_rawdev_selftest(uint16_t dev_id);
#ifdef __cplusplus
diff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h
index 408adf0fd..6d6cf14a1 100644
--- a/lib/librte_rawdev/rte_rawdev_pmd.h
+++ b/lib/librte_rawdev/rte_rawdev_pmd.h
@@ -556,7 +556,7 @@ struct rte_rawdev_ops {
* @return
* - Slot in the rte_dev_devices array for a new device;
*/
-struct rte_rawdev * __rte_experimental
+struct rte_rawdev *
rte_rawdev_pmd_allocate(const char *name, size_t dev_private_size,
int socket_id);
@@ -568,7 +568,7 @@ rte_rawdev_pmd_allocate(const char *name, size_t dev_private_size,
* @return
* - 0 on success, negative on error
*/
-int __rte_experimental
+int
rte_rawdev_pmd_release(struct rte_rawdev *rawdev);
/**
@@ -585,7 +585,7 @@ rte_rawdev_pmd_release(struct rte_rawdev *rawdev);
* - Raw device pointer if device is successfully created.
* - NULL if device cannot be created.
*/
-struct rte_rawdev * __rte_experimental
+struct rte_rawdev *
rte_rawdev_pmd_init(const char *name, size_t dev_private_size,
int socket_id);
@@ -597,7 +597,7 @@ rte_rawdev_pmd_init(const char *name, size_t dev_private_size,
* @return
* - 0 on success, negative on error
*/
-int __rte_experimental
+int
rte_rawdev_pmd_uninit(const char *name);
#ifdef __cplusplus
diff --git a/lib/librte_rawdev/rte_rawdev_version.map b/lib/librte_rawdev/rte_rawdev_version.map
index af4465e26..f5be52df9 100644
--- a/lib/librte_rawdev/rte_rawdev_version.map
+++ b/lib/librte_rawdev/rte_rawdev_version.map
@@ -1,4 +1,4 @@
-EXPERIMENTAL {
+DPDK_18.08 {
global:
rte_rawdev_close;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-26 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 13:19 [dpdk-dev] [PATCH] rawdev: remove experimental flag Shreyansh Jain
2018-07-16 6:18 ` Hemant Agrawal
2018-07-26 21:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).