From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>,
Sunil Kumar Kori <sunil.kori@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks
Date: Tue, 24 Apr 2018 17:23:44 +0000 [thread overview]
Message-ID: <AM2PR04MB07539D647D117DC4EDE30F6A89880@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ac02791d-06cd-8915-0ba1-82a3c063eab6@intel.com>
HI Ferruh,
> Hi Hemant,
>
> Overall this looks good to me, thanks.
>
> Only I would like to ask if you prefer to replace nodis and not_supported checks.
>
> Because with current order, if an offlaod requested that both has not supported
> offload and not enable all nodis offloads, this will print both logs and return
> error. Since it will return error, do you really need "non configurable" log?
>
> If you replace checks, if any not supported offload requested it will only print log
> for it and return error without checking/caring nodis offloads.
>
> It is up to you, please let me know if you want to go with existing set.
[Hemant] Thanks for the review. In v4, I have reversed the order of check
Regards,
Hemant
>
> Thanks,
> ferruh
next prev parent reply other threads:[~2018-04-24 17:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:26 [dpdk-dev] [PATCH 0/2] Support for new Ethdev offload APIs Sunil Kumar Kori
2018-04-09 10:26 ` [dpdk-dev] [PATCH 1/2] net/dpaa: Changes to support ethdev " Sunil Kumar Kori
2018-04-09 13:19 ` Sunil Kumar Kori
2018-04-09 13:19 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-10 16:47 ` Ferruh Yigit
2018-04-10 16:40 ` [dpdk-dev] [PATCH 1/2] net/dpaa: " Ferruh Yigit
2018-04-09 10:26 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 0/2] Support for new Ethdev " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 1/2] net/dpaa: Changes to support ethdev " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-12 18:17 ` [dpdk-dev] [PATCH v2 0/2] Support for new Ethdev " Ferruh Yigit
2018-04-24 15:06 ` [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks Hemant Agrawal
2018-04-24 15:06 ` [dpdk-dev] [PATCH v3 2/2] net/dpaa2: " Hemant Agrawal
2018-04-24 16:43 ` [dpdk-dev] [PATCH v3 1/2] net/dpaa: " Ferruh Yigit
2018-04-24 17:23 ` Hemant Agrawal [this message]
2018-04-24 17:16 ` [dpdk-dev] [PATCH v4 " Hemant Agrawal
2018-04-24 17:16 ` [dpdk-dev] [PATCH v4 2/2] net/dpaa2: " Hemant Agrawal
2018-04-24 18:04 ` [dpdk-dev] [PATCH v4 1/2] net/dpaa: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB07539D647D117DC4EDE30F6A89880@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=sunil.kori@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).