From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0049.outbound.protection.outlook.com [104.47.0.49]) by dpdk.org (Postfix) with ESMTP id 9D87AAAB7 for ; Thu, 19 Apr 2018 17:46:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PIwr4xuNUB8bMgyqykc8RFK9nTv2y3oZOuvRoB5kfGE=; b=L6zVmN+7O0f8MYlwARc1eAjd4BrgtIwihDXZmyYOCc7cOfN9PcOUPQZlHCuFWBhJLMqSw446WdC8lMc9SA5HuYHmigTt642l/bWQoRLKX3n6MoYBIiqxJxtR7c7mLKgn6K5W9Qnb8T0tVZosc5CYsP6pJ4+OBwxbekrEGky22pw= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0995.eurprd04.prod.outlook.com (10.162.35.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.13; Thu, 19 Apr 2018 15:46:14 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::d4ee:e091:7253:7237]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::d4ee:e091:7253:7237%8]) with mapi id 15.20.0675.015; Thu, 19 Apr 2018 15:46:14 +0000 From: Hemant Agrawal To: Bruce Richardson , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build Thread-Index: AQHT11kCMUUg/3WL7E6FfatpiXFYSKQIPCAg Date: Thu, 19 Apr 2018 15:46:14 +0000 Message-ID: References: <20180418210521.277384-1-bruce.richardson@intel.com> <20180418210521.277384-2-bruce.richardson@intel.com> In-Reply-To: <20180418210521.277384-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.162.207.48] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0995; 7:T4iyOZVCbhk3nURZfiGAeNcqM8VKlcHbc5n9UBF8DClKHlxpU7zYn/EBmgp6ySEG+A/pdlaClQgXTx9AXxAyZUQREL8KMhiEMq3qRJx7NwAECIDEHTB07RIfwQA+Yu4Ra2ATVhuIp5Qv13MgM2ByXyAy04um3Hgte9N/4spETFdrADXcA8hcDckHd+uTn0NC46QOyEaNn5XvBQ50DYQeFG7Ci2YluifckVuPNzKT6AampJ+Ixrpt3mUj7poDXSG2 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM2PR04MB0995; x-ms-traffictypediagnostic: AM2PR04MB0995: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231232)(944501383)(52105095)(10201501046)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0995; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0995; x-forefront-prvs: 0647963F84 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(396003)(39380400002)(376002)(13464003)(76176011)(7696005)(5660300001)(6246003)(316002)(59450400001)(6506007)(102836004)(5250100002)(44832011)(2501003)(86362001)(25786009)(74316002)(229853002)(305945005)(33656002)(478600001)(8936002)(3846002)(186003)(446003)(66066001)(476003)(11346002)(81166006)(8676002)(3280700002)(7736002)(26005)(3660700001)(53936002)(110136005)(9686003)(6436002)(6116002)(2906002)(55016002)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0995; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: e2rHh1L41YoMwqmS2AjCGmVH8/+Vyh/FNStAu68vOOaw4qndCt+qtT4wNviNkb7oHsRHBOx8VlH7n49EP8G5J9WTOPutV7ZkLRZ4veMzTAU7NOMx/to5peuj2HC6xgaSl8fh5IdLBixenS3e5OEGsBVp7soN7pmSaNMaSbcelIyfXhuyTFaFPQyVHLvEXgZf spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 710bf611-52c7-471a-6c24-08d5a60caeca X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 710bf611-52c7-471a-6c24-08d5a60caeca X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2018 15:46:14.4172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0995 Subject: Re: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 15:46:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson >=20 > When cross-compiling, if no kernel_dir was specified, then the kernel mod= ules > were still being compiled for the build machine. Fix this by only buildin= g modules > on cross-compile when we have a kernel_dir value set. >=20 > Fixes: a52f4574f798 ("igb_uio: build with meson") >=20 > Signed-off-by: Bruce Richardson > --- > meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/meson.build b/meson.build > index cc16595cb..9e3b44931 100644 > --- a/meson.build > +++ b/meson.build > @@ -26,10 +26,14 @@ subdir('config') >=20 > # build libs and drivers > subdir('lib') > -subdir('kernel') > subdir('buildtools') > subdir('drivers') >=20 > +# build kernel modules if we have a kernel path, or we are not cross > +compiling if get_option('kernel_dir') !=3D '' or not meson.is_cross_buil= d() > + subdir('kernel') > +endif [Hemant] actually kernel_dir may not be always available on host. So unless kernel_dir is available - irrespective of host/cross - it=20 shall not try kernel compilation.=20 > + > # build binaries and installable tools > subdir('usertools') > subdir('app') > -- > 2.14.3