From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30074.outbound.protection.outlook.com [40.107.3.74]) by dpdk.org (Postfix) with ESMTP id 0712D25A1 for ; Mon, 18 Sep 2017 11:47:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CgdcFycy7xeMBXgsP332Zxq6kDHIjKua68o75YYBSU4=; b=YaaJkROe69gNjaldQ6GKioo9Ud6UGtEyJiquJCRlyavMvrQ4Wf+zpnS6ZohcoiBdn4/tYNCLTrSgaRtloVOi9P4eMhDAGg/usB9Mn0E016JC0nDR/QxR6qTy2zZwWPelyhDVqOTwoyxvk1lveTPRWRXzkw8DAcwkhdx5HdRoGBc= Received: from AM2PR05MB0689.eurprd05.prod.outlook.com (10.161.20.16) by AM2PR05MB1156.eurprd05.prod.outlook.com (10.163.147.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Mon, 18 Sep 2017 09:47:04 +0000 Received: from AM2PR05MB0689.eurprd05.prod.outlook.com ([fe80::e5d8:bc6d:6cb7:165]) by AM2PR05MB0689.eurprd05.prod.outlook.com ([fe80::e5d8:bc6d:6cb7:165%14]) with mapi id 15.20.0056.016; Mon, 18 Sep 2017 09:47:04 +0000 From: Shachar Beiser To: Yongseok Koh CC: "dev@dpdk.org" , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host macros Thread-Index: AQHTLV92dIIcV5Jbu0qR9nyq6n30kqK2bb6AgAP8wfA= Date: Mon, 18 Sep 2017 09:47:03 +0000 Message-ID: References: <0027cb81572aa683b0db357dbfc62e810f1ae4c8.1505396232.git.shacharbe@mellanox.com> <2E023DB0-6B86-4C66-8600-8374A0D95D48@mellanox.com> In-Reply-To: <2E023DB0-6B86-4C66-8600-8374A0D95D48@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shacharbe@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR05MB1156; 6:BXpr902I4Yq87osReqHHZbxKQhB7Kv99ejfmjhQOUotJqzXq4EgC7h81ag0Njzhuq4aVV/LF8G7yBRINhkbm3W8djIOArGwXdApdspGDj9Mopsb0+sHaivBW7a6hJu/pg2kbyGBI8I97S7h/PjMsWlGhDpqYYa139yRoTzJyU5YwX/e+HaeeDnJctE6zIdZ753u5wz2C0f8pp9fRcYrsOwchvK9HMbrfvV0ERkmme0lcLeEcELE2k37ZusDDOawSSqs/sUhKXKi0e20nzxtUtdlabouFtMIEfgDYCrlQ90KiXMvgOm8Bifgj5MlNRQb31hNzYiJo4Ube/7mEmmDlxg==; 5:IupzA88OzXBkvmOUkPqc6J01McvglDyZ9y7J8I76LoM+Q+XumbsPYictMOuNib2aqb+LzrnWP8YMy6JklkjMsxFbU2fkoq9Ssa41buWqXLxU0Hd03q6b3WIw3ciceEMqFcx8fK4pMLhMOxDLwKNolQ==; 24:xvo9oD3iB2FVK5l0IcIzQPuoa2w2qiC++fjdT1gVzoBvSXkWKyN0DzVYYanUj7IiFLp/N+NS4ua96pNjhiw33KKViVr7wOtzSllfzAwWrO8=; 7:EIx5Bhma9m0+xMS2EmMLhFYb1EKJ2Qz+3xhxcehMXe32PHFp8tt5QAuKNou4lANLAmG0nTLoxXFxh5g/2J5BSL4eNq7NnClnU71iM5zdRuaQ6bizCeiEKp9k8EZ/QjPSnQf0Y7guefNg02lvaC2iJTbgG09EpxyT2fnZixJeVWdNR9q9qRghXuGPyilIjd2mzHt9TQvIrO4DimCSExexJ09iXJcXh00e8plefIBWgH8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 77eb3c22-aab8-46db-4cb9-08d4fe7a37bf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM2PR05MB1156; x-ms-traffictypediagnostic: AM2PR05MB1156: x-exchange-antispam-report-test: UriScan:(788757137089); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM2PR05MB1156; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM2PR05MB1156; x-forefront-prvs: 04347F8039 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(24454002)(13464003)(199003)(189002)(377454003)(305945005)(101416001)(316002)(9686003)(6306002)(478600001)(3846002)(33656002)(229853002)(6862004)(110136004)(53376002)(68736007)(53936002)(99286003)(2906002)(86362001)(3280700002)(55016002)(54906002)(6506006)(4326008)(3660700001)(6246003)(66066001)(5660300001)(5250100002)(7696004)(6636002)(8936002)(105586002)(106356001)(2950100002)(6436002)(97736004)(2900100001)(74316002)(189998001)(81166006)(81156014)(25786009)(50986999)(966005)(6116002)(14454004)(7736002)(53546010)(102836003)(76176999)(54356999)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR05MB1156; H:AM2PR05MB0689.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2017 09:47:03.6300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB1156 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 09:47:06 -0000 > -----Original Message----- > From: Yongseok Koh > Sent: Friday, September 15, 2017 11:50 PM > To: Shachar Beiser > Cc: dev@dpdk.org; Adrien Mazarguil ; N=E9lio > Laranjeiro > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host > macros >=20 >=20 > > On Sep 14, 2017, at 6:43 AM, Shachar Beiser > wrote: > > > > Signed-off-by: Shachar Beiser > > --- > [...] > > @@ -550,7 +553,8 @@ > > max_wqe -=3D n; > > if (tso) { > > uint32_t inl =3D > > - htonl(copy_b | > MLX5_INLINE_SEG); > > + rte_cpu_to_be_32(copy_b | > > + MLX5_INLINE_SEG); > Wrong indentation. >=20 Since there is a constrain of 80 characters a line , this indentation was a= ccepted by N=E9lio .=20 > [...] > > @@ -605,8 +605,8 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *, > uint16_t, uint16_t, unsigned int, > > uint64_t *dst =3D (uint64_t *)((uintptr_t)txq->bf_reg); > > volatile uint64_t *src =3D ((volatile uint64_t *)wqe); > > > > - rte_io_wmb(); > > - *txq->qp_db =3D htonl(txq->wqe_ci); > > + rte_wmb(); > Look like a mistake when rebasing. This should not be touched by this pat= ch. >=20 > > + *txq->qp_db =3D rte_cpu_to_be_32(txq->wqe_ci); > > /* Ensure ordering between DB record and BF copy. */ > > rte_wmb(); > > *dst =3D *src; >=20 Yes , this is true. There is a fix for this issue in the coming patch: [dpdk-dev,v4,1/2] net/mlx5: replace network to host macros http://dpdk.org/dev/patchwork/patch/28804/ > -- > Thanks, > Yongseok >=20