From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0053.outbound.protection.outlook.com [104.47.1.53]) by dpdk.org (Postfix) with ESMTP id 5BE781B976; Tue, 10 Apr 2018 10:04:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4LILjFdIJ0HrJE+yXNSeXuMgyplz/+GMzn6UVGYsXSo=; b=GfwjvP1gFhr2aETDxb/5AZIWfWCdx/k/8+COdCRoqDwnznlgnbsjM3o8T5/O2kit2cP5moH+3XsBXTlLt2hU0OVel0UOTezCN6xxEgtriCNEjLyujzbZfaK3fC3gw6ySS9HvL6vZSwFRJ/S6cELq2ktjHnSuH66d6EwvhYLCRvg= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2225.eurprd05.prod.outlook.com (10.165.82.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.9; Tue, 10 Apr 2018 08:04:12 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6%9]) with mapi id 15.20.0675.009; Tue, 10 Apr 2018 08:04:12 +0000 From: Matan Azrad To: Ophir Munk , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v1] net/vdev_netvsc: fix creating short name devices Thread-Index: AQHT0JxrAEGZgm8wd0Svn+0eUuQf7aP5oBoA Date: Tue, 10 Apr 2018 08:04:12 +0000 Message-ID: References: <1523344821-8890-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1523344821-8890-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2225; 7:81OZsBlILMRA/KD/N8zRJMIRJqwRZigjIupc6cPvQxKJON+bmcMhpVz5xOQEPT1JRNxy7d5n0dWcwj9mHhEycjruPdm8BJeS3MQHCDOYC1kJl1S+6x6ubzxU9mdhyCR2hQ2rpGDI7lsspCEYQWZa1FumLKEf3K0+m/wx3i9LYDH3ByIvZamj5ar7hxXbFBYox2Px67DO+LqAclKeJUtp+EQHH1HTk8qa0GscLqhcyCM2Iu31igBa+r7PNH7ZhOS+ x-ms-exchange-antispam-srfa-diagnostics: SOS; X-MS-Office365-Filtering-Correlation-Id: f71be9d3-8569-4e6c-2e29-08d59eb9a599 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB2225; x-ms-traffictypediagnostic: AM4PR0501MB2225: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231221)(944501327)(52105095)(93006095)(93001095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:AM4PR0501MB2225; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2225; x-forefront-prvs: 0638FD5066 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(376002)(39860400002)(396003)(346002)(199004)(189003)(4326008)(5660300001)(6246003)(105586002)(53936002)(229853002)(81156014)(14454004)(8676002)(97736004)(81166006)(8936002)(33656002)(478600001)(2900100001)(66066001)(106356001)(25786009)(74316002)(3846002)(3280700002)(9686003)(3660700001)(6116002)(55016002)(7736002)(2501003)(305945005)(6436002)(5250100002)(2906002)(86362001)(486006)(26005)(6506007)(99286004)(11346002)(446003)(476003)(110136005)(54906003)(68736007)(76176011)(316002)(7696005)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2225; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xDmhlcZ/eOcEK9dxB05LxXyAXyb3iQYpK67NM5kD2AKjalLnh8395fT6sxrJw/PU3QI2EnL1jJA4SO58PswZ6RM2+81OBred1VbCdmzvs3oSfjgYsfhD7s1lz/hyamdOzElmwKT9XzKgtcdiQeCSivhUk+VffBJFlCSf71YmmGuN9TqBMJXZh3vV+RXY9g99YfQZCVYco/tp6Xx2t535vw4TsMi5oaplDcHdeRlzvu4xGcsl1MIJMZ2bqXNw32MGB15lbqdqrgzcSndNCC2B+DApGuldSPScYNhRcOWiVUG3ovt5ZmNq2GcZozrgRVE1o1WfYt/BIj/Q2XQBuwkORhRSpIX3FXCzs3QcL6LrV7PxsapPInlO+QJ+DttiQoFtLTP555nENpwTe3JSahGhxdyLpVJh/s8Ei62CkXGV5E4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f71be9d3-8569-4e6c-2e29-08d59eb9a599 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2018 08:04:12.6090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2225 Subject: Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 08:04:14 -0000 Hi Ophir From: Ophir Munk, Tuesday, April 10, 2018 10:20 AM > Prior to this commit the vdev_netvsc PMD was creating tap and failsafe > devices with long names, such as "net_tap_net_vdev_netvsc0" or > "net_failsafe_net_vdev_netvsc0". > Long names containing more than 32 characters may be rejected by some > APIs (e.g. membuf pool creation). Since EAL allows to use long names, I don't think it is a problem of the ne= tvsc device. If a DPDK entity wants to use this name for some reason it needs to adjust = it to the usage.=20 I agree that short names are better and may help for such like cases. I suggest the next title: net/vdev_netvsc: use short device names > This commits fixes this issue by creating tap and failsafe devices with s= hort > names such as "tap_net_vsc0" or "net_failsafe_vsc0". >=20 > Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ophir Munk > --- > drivers/net/vdev_netvsc/vdev_netvsc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c > b/drivers/net/vdev_netvsc/vdev_netvsc.c > index db0080a..bb2f78d 100644 > --- a/drivers/net/vdev_netvsc/vdev_netvsc.c > +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c > @@ -614,13 +614,13 @@ vdev_netvsc_netvsc_probe(const struct > if_nameindex *iface, > name, ctx->id); > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->name)) > ++i; > - ret =3D snprintf(ctx->devname, sizeof(ctx->devname), > "net_failsafe_%s", > - ctx->name); > + ret =3D snprintf(ctx->devname, sizeof(ctx->devname), > "net_failsafe_vsc%u", > + ctx->id); > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->devname)) > ++i; > ret =3D snprintf(ctx->devargs, sizeof(ctx->devargs), > - "fd(%d),dev(net_tap_%s,remote=3D%s)", > - ctx->pipe[0], ctx->name, ctx->if_name); > + "fd(%d),dev(net_tap_vsc%u,remote=3D%s)", > + ctx->pipe[0], ctx->id, ctx->if_name); > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->devargs)) > ++i; > if (i) { > -- > 2.7.4