From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0042.outbound.protection.outlook.com [104.47.2.42]) by dpdk.org (Postfix) with ESMTP id 7D1FD2BBB for ; Mon, 19 Feb 2018 15:13:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tfJd3jUe4QslE7cfjmhdi37Ojy/YA0ePjHdG6pjdeLk=; b=WpOAJqVNzFjyfS27DjEn5j3/rqCzuZbtWEyW74l90RzMOQ6DY889cVKOOkJqnRQZgDi0HHFe+ljY11cfhZ5kW3iCKtFVlTa4dzFLE30/cvrVxFvyt7p+EpL5QY5N+knXZZZ2IMWFPS/2aeGKahxAi7VP1pHWgVGu40Pih+KxSSA= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2339.eurprd05.prod.outlook.com (10.167.123.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Mon, 19 Feb 2018 14:13:33 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05%17]) with mapi id 15.20.0506.021; Mon, 19 Feb 2018 14:13:33 +0000 From: Matan Azrad To: "Wiles, Keith" , Thomas Monjalon CC: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Thread-Index: AQHTqM6hjNC7dvJ+KUy8qhmt6Do6xqOrPDoggACEx4CAAAHfsA== Date: Mon, 19 Feb 2018 14:13:33 +0000 Message-ID: References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <28F3DAA5-CCAB-4D2E-A6C9-FEB685A619C8@intel.com> <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> In-Reply-To: <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2339; 7:a8ufOwT+G05gDi94u1lJ7Ixji90uiBWNYFtxKC/GtQ+W77WQG8JRS7ustEQZWTLAHyTzsidyBJ+6rVUYtikyMN8j1ek7BI3PSNDgem7fUZiKoBMhgMyaiSaGawFVSRxaTcXBYDOBF5gPT972G7nZSej+8xiRTkq2bVgzt4G78JrIggu7KYYycaz2+UL/1XzDcAjB3fpbT67U+WW7PPVm/9TkJNpopRpXkj6xdGkPms8RXt6eTHxIu6D6v6oWJ36q x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6d0be21d-9012-4251-d040-08d577a2f5cd x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM4PR0501MB2339; x-ms-traffictypediagnostic: AM4PR0501MB2339: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001056)(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231101)(944501161)(10201501046)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0501MB2339; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2339; x-forefront-prvs: 0588B2BD96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(39380400002)(366004)(396003)(199004)(189003)(2900100001)(53936002)(110136005)(966005)(54906003)(2906002)(4326008)(106356001)(6246003)(316002)(3660700001)(3280700002)(5660300001)(68736007)(33656002)(2950100002)(97736004)(25786009)(478600001)(99286004)(7736002)(305945005)(229853002)(102836004)(55016002)(74316002)(93886005)(14454004)(186003)(8936002)(81166006)(81156014)(26005)(6436002)(7696005)(66066001)(105586002)(6506007)(9686003)(53546011)(6306002)(86362001)(5250100002)(76176011)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2339; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: c/+PTHOK6ke9zAKEammsCwfahoXIsww0/RlaBTUGHfXuK3hYaXKFdRmYhzPGVnhiJR/qKXAPNp8utTk++j+OV/cFESvX4M7lXS/ZdK5r3l5rEywOQAllqUIGUE9S4A67WBUGePaQG4S7Xj9OB3nefGqfzOchUT8ACDTAXX6ZL1M= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d0be21d-9012-4251-d040-08d577a2f5cd X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2018 14:13:33.4169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2339 Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 14:13:34 -0000 Hi Wiles From: Wiles, Keith, Monday, February 19, 2018 3:56 PM > > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: > >> Is this the type of API that needs to be marked experimental, > > > > I think it is relevant to any exposed API(not only for internal librari= es). > > > >> we should be able to prove these functions, correct? > > > > Don't we need to prove any function in DPDK? > > What is your point? >=20 >=20 > My point is this is a inline function and can not be placed in the .map f= ile as a > external API. Doesn't each API in .h file external? Why not? If it shouldn't be external and should be in .h file, I think it should be = marked as internal, no? > These simple type of APIs are easy to prove and making them > experimental seems to just cause an extra step. As Thomas mentioned here: https://dpdk.org/ml/archives/dev/2018-January/087719.html Any new API should be experimental. Thomas, Is it different for .h file inline APIs? =20 > If the functions are not required that is a different problem or if the A= PI is really only ever used by a > single function or module of files then it should be moved to the module/= file > and made locate to the module/file. Agree. Looks like this function makes sense and may be used by other modules later= .