From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20050.outbound.protection.outlook.com [40.107.2.50]) by dpdk.org (Postfix) with ESMTP id 2D9F01B2F2 for ; Mon, 12 Feb 2018 10:04:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VTHljc63gO6M1RxMkkVF4CynM6LqVbAtJ0CY197/ju0=; b=XSmrqd076M9VuwBrc0LNLmFLA6nkG6D6kE45DEp0yHIIn9KUvWY6f/kGDQY0ptM0ijeNZEEze9nGBX5Zy87sShCMTL5fFBs5qtc5hq6Ty5ExeS/L//+0V3XZjd+e/LqLP++IDWB8HVizggwFuSZtg8BzOFcj3oQ1dKWZzXxFNa8= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2209.eurprd05.prod.outlook.com (10.165.82.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 09:04:07 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05%17]) with mapi id 15.20.0485.013; Mon, 12 Feb 2018 09:04:07 +0000 From: Matan Azrad To: Jerin Jacob , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Thomas Monjalon , Konstantin Ananyev , Pavan Nikhilesh Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned Thread-Index: AQHTo8YSOfZN9JQRQ0q03fPDgObqg6OgdnKA Date: Mon, 12 Feb 2018 09:04:07 +0000 Message-ID: References: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> In-Reply-To: <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2209; 6:Y07yINLgnDvd3oSlsdOxBpeFAVMdJg5Cy018AyrRoSglwb5AqtJYuXze0+6f/bqtJFmDZfcs7Vyl3jiwWJlZ6+XlQeg1xtYRJDLCpktQpI9puDXVZUuOzRsk6itQ0A9OJj8pf2NTFJrxguOKI1WCoex5K0PC/+npl1kbCIIXTs0i8WPShQ5nr7DAqV3vuWB1L5q0Jab7YNneVzkLYC2Nn1Nk3WP/Tl7HE0b6lmlEhGXKaIjezWUvaBm4xo73RzpXXnb2OGKAoCjdQzzmVf8ZawCGpF0IjE+x17mGnUIEk9j1QkQGCUnCGd6SYlOpsMcSsV5pVLIKmMdoUFpda6SCdtv68NmsjanAWjwnLrLt/rokAOqMohqHkAqx02kF9UhR; 5:HHLeLxQriN79h3hmE0zTqWjsvPnoTMrw/6vNsHc718l9qH7Ttlq8QVzyzqMJTo7du7QXtGin7bfn3+xjD92LU0O3qfUdUIbKD4EJL4M6CcAKQwp2Yy1tbhWW57FrcApWerCol99o1JyK3P5fDRo0MiYmwdFuTipxGLWDjDhOq3k=; 24:q9HikwXwdtTt9HD4nsyA4r4ROnXbDj7ZpIfwqkhDbBM8/U8ze7/xnvXw0dcfIiBM/Jv6GTUZmDn+4zi2T3mVLHeAUePBnYUsWwCTahIbmFA=; 7:AQoENfobEYioloPfJ9Q49ItuZKWNaNEKK8s61/PToTjlI+Ds5lZpwffMsqaH3qrUGcFdJz2dqJVAUnDJRQa3Lo39q3HqVVWOREF4bmKK58IfD8SP5bYW7Rj9JXuXpf88kxdgxrUjkOb4D3eUPUl5vQL8Z2InFlkCPoKRC9Qg3Fb+BKXejbVj1fcEYUooe9sJ6nIwSQMpZvbG4EWVz0esmAyxV5Z8pwViBJ5+Hvj5Uh/7bQH5j+25yeZ6OFfOtdrv x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 45758a30-1613-4ef2-057e-08d571f7929f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM4PR0501MB2209; x-ms-traffictypediagnostic: AM4PR0501MB2209: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(60795455431006)(189930954265078)(45079756050767)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0501MB2209; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2209; x-forefront-prvs: 0581B5AB35 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(39380400002)(376002)(396003)(346002)(199004)(51444003)(189003)(7736002)(102836004)(2906002)(105586002)(74316002)(966005)(305945005)(5660300001)(106356001)(33656002)(2900100001)(59450400001)(26005)(97736004)(6246003)(6506007)(229853002)(4326008)(25786009)(55016002)(7696005)(2501003)(81156014)(99286004)(5250100002)(3280700002)(81166006)(6116002)(6436002)(8936002)(2950100002)(3846002)(6306002)(186003)(54906003)(76176011)(316002)(86362001)(3660700001)(575784001)(478600001)(110136005)(53936002)(14454004)(66066001)(68736007)(45080400002)(8676002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2209; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: txMbC/K4RcwW5s4iiD61dz/KuslrAE7G2n4B1JAYX6iC0besUo5RhNMrIwzMCmq81nHkrZMbPRUyfTMGUNmJTQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45758a30-1613-4ef2-057e-08d571f7929f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2018 09:04:07.2611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2209 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 09:04:09 -0000 Hi Jerin From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Since struct rte_eth_dev_data used in the fast path, making it as cache > aligned. >=20 > Fixes: af75078fece3 ("first public release") > Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Looks like it is just improvement. No need the above "fixes" lines (also fix title is not needed as you did). I think that performance improvement results should be added to the commit = log. Moreover, Did you investigate which fields in rte_eth_dev_data structures a= re important for performance and should not be in a different cache lines? Maybe alternative order of the fields in the structure may improve the perf= ormance more...=20 =20 > Cc: Matan Azrad > Cc: Thomas Monjalon > Cc: Konstantin Ananyev >=20 > Signed-off-by: Jerin Jacob > Signed-off-by: Pavan Nikhilesh > --- > v2: > - Change the git comments based on Matan's feedback > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fdp > dk.org%2Fdev%2Fpatchwork%2Fpatch%2F35104%2F&data=3D02%7C01%7Cmat > an%40mellanox.com%7C5c2537b12e6d4e51f12a08d571dd33a2%7Ca652971c7 > d2e4d9ba6a4d149256f461b%7C0%7C0%7C636540117238324576&sdata=3D8OOg > Zb0KzDbBce9xPVywV8ynmiKP9B%2BbYsQxgE5VlX0%3D&reserved=3D0 >=20 > - Some platform like thunderx + l3fwd showed 1% regression in the > performance with 5b7ba31148a8 ("ethdev: add port ownership") in one port > setup. >=20 > - If there are no objection for this change then request to take it for v= 18.02 > release. > --- > lib/librte_ether/rte_ethdev_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev_core.h > b/lib/librte_ether/rte_ethdev_core.h > index 315b31723..e5681e466 100644 > --- a/lib/librte_ether/rte_ethdev_core.h > +++ b/lib/librte_ether/rte_ethdev_core.h > @@ -601,7 +601,7 @@ struct rte_eth_dev_data { > struct rte_vlan_filter_conf vlan_filter_conf; > /**< VLAN filter configuration. */ > struct rte_eth_dev_owner owner; /**< The port owner. */ -}; > +} __rte_cache_aligned; >=20 > /** > * @internal > -- > 2.16.1