From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id 9305F1B321 for ; Tue, 13 Feb 2018 23:19:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FwAgLZVqWhXBehYGT0WK+Kb7pHX+Hq9XlwdJgSlS6LE=; b=GJxM2/nDG1HDO9m1OFEpS2nr9TTed7kkPtU9ZPzAE6y/vddkjPwHHxs96BBtLliDdBW3zPOH2Mv5FXnlk63/0zQLReTZIN3iFX1KoXx7l6LPkho7uD3KcUsWQ+adP6R1uZc2SkpF5c88jBiXPCIlp2kRa6oRXg+pT6MD2kTPs7I= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB3588.eurprd05.prod.outlook.com (10.167.90.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 22:19:15 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05%17]) with mapi id 15.20.0506.016; Tue, 13 Feb 2018 22:19:15 +0000 From: Matan Azrad To: "De Lara Guarch, Pablo" , Thomas Monjalon CC: "dev@dpdk.org" , "gaetan.rivet@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build Thread-Index: AQHTpRfmmUze9LB0aUCB9EyEMcLsgaOi5v2AgAAAHIA= Date: Tue, 13 Feb 2018 22:19:15 +0000 Message-ID: References: <20180213213312.22225-1-thomas@monjalon.net> <20180213221324.24524-1-thomas@monjalon.net> In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [85.64.136.190] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB3588; 7:1JHdWG3AY7h9D4LNKA/gVfAImz+zWEYk9w0QoiOzTs86xETE5fqFtW4akOArBuHxs68f94jITX3rFHNZDVeS0fx0eqReMmQg1E05pUHEXYsS55HJwPR+/CrthrrA5uNsJFfMVmAT9IWs1GP71Em6brZdaftpUwOzDeTlPc8mOrf4vcDVIIkKxNxQTTb34yGpO0FM3xNhpJoED7lAOY0vaxNgI3mddaQLS0jEJ9msdxNYvR2+8JgRiHBCfC+lvOBM x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 586e004a-0bea-4364-a134-08d5732fd14b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM4PR0501MB3588; x-ms-traffictypediagnostic: AM4PR0501MB3588: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231101)(944501161)(3002001)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM4PR0501MB3588; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB3588; x-forefront-prvs: 0582641F53 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39380400002)(39860400002)(366004)(13464003)(199004)(189003)(5660300001)(478600001)(5250100002)(2950100002)(54906003)(97736004)(106356001)(110136005)(316002)(2906002)(6246003)(26005)(2900100001)(53546011)(6506007)(8676002)(66066001)(81156014)(25786009)(3280700002)(102836004)(6436002)(229853002)(81166006)(68736007)(99286004)(6116002)(6346003)(76176011)(14454004)(8936002)(4326008)(105586002)(7696005)(3846002)(186003)(33656002)(305945005)(3660700001)(86362001)(53936002)(55016002)(9686003)(7736002)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB3588; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-microsoft-antispam-message-info: n+tEjar7SOZRQdWeO/dt+/ngiZFI1HIgr3UQeJApNUzEjKof4072M0LUHiyH+HVwI1Ov6S/7I4zMtjzCew79Dg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 586e004a-0bea-4364-a134-08d5732fd14b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2018 22:19:15.3907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB3588 Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 22:19:17 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > Sent: Wednesday, February 14, 2018 12:19 AM > To: Thomas Monjalon ; Matan Azrad > > Cc: dev@dpdk.org; gaetan.rivet@6wind.com > Subject: RE: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, February 13, 2018 10:13 PM > > To: matan@mellanox.com > > Cc: dev@dpdk.org; gaetan.rivet@6wind.com > > Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build > > > > The type pthread_t is not portable because it is freely defined. > > On Linux, it is an unsigned long int which can be printed with %l. > > On FreeBSD, it is a pointer which can be printed with %p. > > > > That's why there was this error: > > drivers/net/failsafe/failsafe_private.h:377:53: error: > > format specifies type 'unsigned long' but the argument has > > type 'pthread_t' (aka 'struct pthread *') > > > > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") > > > > Reported-by: Pablo de Lara > > Signed-off-by: Thomas Monjalon >=20 > Tested-by: Pablo de Lara >=20 Acked-by: Matan Azrad