From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30087.outbound.protection.outlook.com [40.107.3.87]) by dpdk.org (Postfix) with ESMTP id 0900A8DAF; Mon, 16 Apr 2018 21:17:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hql0Ekj1UJJ29Ao+hEdiZAttWyUxSY/kbWsQ9xlpI8I=; b=wYHa9CVzBUh0DeFVYL3JFpFm9L0taixzIOWhkzpskcAkoCbuP7feeVAc6HfQVZbMa/r5DLLS0SGuAxv/f0fa7F0+7ZoqYaIerFTykQfjU3Fc/bSdoqEM22dhQC+9QJUv98iYFX8IOli1RJFe5GZzTYkau3+is1RdFpLHswWQAiA= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2708.eurprd05.prod.outlook.com (10.172.215.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.9; Mon, 16 Apr 2018 19:17:45 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6%9]) with mapi id 15.20.0675.015; Mon, 16 Apr 2018 19:17:44 +0000 From: Matan Azrad To: Adrien Mazarguil , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command Thread-Index: AQHT1Z9hT96KzgpjqUyU/Ut8tYSCtaQDw3Ww Date: Mon, 16 Apr 2018 19:17:44 +0000 Message-ID: References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> <20180416150058.2620-11-adrien.mazarguil@6wind.com> In-Reply-To: <20180416150058.2620-11-adrien.mazarguil@6wind.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2708; 7:kaga7HIjIq/9d78PS+81jPBDq+ZYyrHCqhn6F5Bm2FV7yq6c+N/Vyb3fLV/fZzaOjkxfnTkHMrRqyZZn3lpQChfgMia2ekHGhXJ0zDWRhnXqC/OGJtNANIQLVP0gDkUMptWEtHMqLeYCnfSTNpyboniVcARCC4+2NysFYcD/B5P9vxKtFTENvDDztxEe9n14UlfnQhaegRm5/Jdt+Yw3Rofnz1TTM9TFiPNRaklwffaK8oTl+deMxhp+NGO1hZGY x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB2708; x-ms-traffictypediagnostic: AM4PR0501MB2708: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231232)(944501327)(52105095)(10201501046)(6055026)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:AM4PR0501MB2708; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2708; x-forefront-prvs: 0644578634 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(346002)(39380400002)(366004)(199004)(189003)(3660700001)(25786009)(33656002)(97736004)(575784001)(26005)(6246003)(81156014)(316002)(186003)(81166006)(105586002)(8936002)(106356001)(486006)(4326008)(110136005)(86362001)(2900100001)(7696005)(66066001)(6506007)(59450400001)(2501003)(2906002)(76176011)(446003)(99286004)(476003)(68736007)(5250100002)(3280700002)(55016002)(11346002)(229853002)(5660300001)(53936002)(14454004)(9686003)(478600001)(6436002)(74316002)(102836004)(7736002)(305945005)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2708; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 54xNPfulgVPqk+YWrpYU4bXLazdkXtiMmIygKtrHDR6mTxwalC2w6x3VN8Rqe2t5BagkyjnX8hi/FpSNc9SFPLglsrZ8yE6AQqclDfFeDS7mgLPT90Y/zM7G/2ZoTnOEo/7SuVz4LnypQcfY8z0yXVTRFDJKDz7SxkXhwEftJ1SA9RDWxBhM8+588fYyEwd1 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 00bdfc96-8137-48e5-f261-08d5a3cebba6 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00bdfc96-8137-48e5-f261-08d5a3cebba6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2018 19:17:44.8573 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2708 Subject: Re: [dpdk-dev] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 19:17:46 -0000 Hi Adrien I think the title should be "app/testpmd: ..." ... From: Adrien Mazarguil, Monday, April 16, 2018 7:22 PM > Original implementation lacks the on/off toggle. >=20 > This patch shows up as a fix because it has been a popular request ever s= ince > the first DPDK release with the original implementation but was never > addressed. >=20 > Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil > Acked-by: Nelio Laranjeiro > --- > app/test-pmd/cmdline_flow.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index fcd76b56e..f0b4b7bc4 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -2692,6 +2692,7 @@ static const char *const boolean_name[] =3D { > "false", "true", > "no", "yes", > "N", "Y", > + "off", "on", > NULL, > }; >=20 > -- > 2.11.0