From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30073.outbound.protection.outlook.com [40.107.3.73]) by dpdk.org (Postfix) with ESMTP id 49B9A1B29F for ; Wed, 14 Feb 2018 16:11:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=S5Qk38QoPzOyvvN1yGFwka+jhrWijomtIqnuVmYlkTw=; b=LRI4PNx3YTM+mjrprGynUWxOK7iQd7V1MTwOlMHUrl8uyHxV9Qmhee0HiP8DzWJ5d+MYeZJ/wkSDGZ0bmZgIUzFX5DVATVpYnqauDgTjjI1a5MbWogWlSZ4uBIxHZvEQiUJOsfvGvCoQ2nMcp7aV8p6IXsvfB/XI2OVP9TQI/ss= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2228.eurprd05.prod.outlook.com (10.165.82.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Wed, 14 Feb 2018 15:11:08 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::80c6:df5:b1b0:ff05%17]) with mapi id 15.20.0506.016; Wed, 14 Feb 2018 15:11:08 +0000 From: Matan Azrad To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] net/failsafe: fix Rx interrupt reinstallation Thread-Index: AQHTpaSOC/DzdP7+I0KS1HCYEnW4qaOj/hmAgAACMEA= Date: Wed, 14 Feb 2018 15:11:08 +0000 Message-ID: References: <1518562772-29823-1-git-send-email-matan@mellanox.com> <1518619646-23990-1-git-send-email-matan@mellanox.com> <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> <20180214150129.ajvb2otj5xogpn3i@bidouze.vm.6wind.com> In-Reply-To: <20180214150129.ajvb2otj5xogpn3i@bidouze.vm.6wind.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2228; 7:9FgVX4JRA4EU5v6w5+VIbygc+L8vmha1qPpxKOHrToD7Obdd2An1Dc58kY+89Wj4+fXtyI6mG0hck1kxR3FWbETqqbjLvaiHALketcPQEg+bh3jFd+tcIGtrunu5HV3YKtk0x0RHL/eAKRuFPj4jjRKhWmT5NgfgZ6JRO05srO+WBTHZoHB+6Npxa9IU4H4LmslUZdVS7tFI/IkjY49HGApUpSPxxx7xYYnYyqYUpKUzQABMSpJY6vlQbNeuVYNf x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 440b9e1f-c43e-484a-541a-08d573bd2d0e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM4PR0501MB2228; x-ms-traffictypediagnostic: AM4PR0501MB2228: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231101)(944501161)(10201501046)(6055026)(6041288)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0501MB2228; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2228; x-forefront-prvs: 0583A86C08 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(376002)(346002)(39860400002)(396003)(199004)(189003)(106356001)(93886005)(6506007)(99286004)(26005)(59450400001)(2900100001)(102836004)(7696005)(76176011)(6116002)(6916009)(5660300001)(105586002)(68736007)(86362001)(5250100002)(2950100002)(3846002)(8936002)(229853002)(81156014)(33656002)(6246003)(81166006)(6436002)(3660700001)(74316002)(305945005)(97736004)(14454004)(25786009)(8676002)(478600001)(186003)(9686003)(4326008)(316002)(53936002)(3280700002)(55016002)(66066001)(2906002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2228; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: cM5d6B9GCTZa1o9A4zsujFxqigx6bKtGwAb1D52Oh8leEudcHFCH8r7lk2kTBqkHFwm+E7dCJPisGVby+kP3/A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 440b9e1f-c43e-484a-541a-08d573bd2d0e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2018 15:11:08.3938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2228 Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 15:11:09 -0000 Hi Gaetan From: Ga=EBtan Rivet, Sent: Wednesday, February 14, 2018 5:01 PM > On Wed, Feb 14, 2018 at 04:00:13PM +0100, Ga=EBtan Rivet wrote: > > On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > > > Fail-safe dev_start() operation can be called by both the > > > application and the hot-plug alarm mechanism. > > > > > > The installation of Rx interrupt are triggered from dev_start() in > > > any time it is called while actually the Rx interrupt should be > > > installed only by the application calls. > > > > > > So, each plug-in event causes reinstallation which causes memory > > > leak and spoils the fail-safe Rx interrupt mechanism. > > > > > > Trigger the Rx interrupt installation only when it does not exist. > > > > > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode") > > > > > > Signed-off-by: Matan Azrad > > > > Acked-by: Gaetan Rivet >=20 > Actually no! >=20 > There is a mistake in the patch, you disabled the uninstall, instead of t= he > installation. > No Gaetan, I think it is in the install. Please recheck maybe by applying. =20 > -- > Ga=EBtan Rivet > 6WIND