From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0054.outbound.protection.outlook.com [104.47.1.54]) by dpdk.org (Postfix) with ESMTP id 276C21B98F; Tue, 10 Apr 2018 17:39:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FWjbzPQk+jYucNEWr4dFhljLAmEoNoQBtWyLW5d1ReU=; b=qYtHEj+RbVK1qO74wqftL5V9RluGm6JvEEkLF3BKKU73RwQPAxxB08jjsAIX2HHjxwS+kR/qRCtMmaed1prnwgxx9nxgtbWrN8hhct5/b+CndsqHQncf9WHuACXrS0NQ/sCzB1e0+73LfXvCQmnHTNTlRveUUnsJGviEVYEQozQ= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2321.eurprd05.prod.outlook.com (10.165.82.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.10; Tue, 10 Apr 2018 15:39:50 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6%9]) with mapi id 15.20.0675.009; Tue, 10 Apr 2018 15:39:50 +0000 From: Matan Azrad To: Ophir Munk , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v1] net/vdev_netvsc: fix creating short name devices Thread-Index: AQHT0JxrAEGZgm8wd0Svn+0eUuQf7aP5oBoAgACB7ICAAAC90A== Date: Tue, 10 Apr 2018 15:39:50 +0000 Message-ID: References: <1523344821-8890-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2321; 7:+HojdkWrAePKwuqKkrh7G8eM7lJAynkmZuAOz+kmlaee4A7vy0Bz9tR7DArYf8lpDxAzcwpTBSiDy4x5SOmQnXgeDF7w3NBoH5exxhpH1OrfQY//CwBSSrqBJliDB8c9SDINyPlb5iNfKcDW9MRalavoE1hNS/3tBvOYuydCE0WjsvXn5DZj9om8NdpVrTtKdDCCe/NDKJH2sw938eGDoU3xpHPxyG5mdnPxJAJTDQHepUiU7qd5Re+kcCpl4oQH x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(3008032)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB2321; x-ms-traffictypediagnostic: AM4PR0501MB2321: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231221)(944501327)(52105095)(93006095)(93001095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR0501MB2321; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2321; x-forefront-prvs: 0638FD5066 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(376002)(39860400002)(39380400002)(13464003)(189003)(199004)(8936002)(81156014)(8676002)(6436002)(81166006)(6116002)(2900100001)(3846002)(55016002)(229853002)(33656002)(6246003)(9686003)(25786009)(5250100002)(53936002)(2501003)(97736004)(316002)(4326008)(102836004)(54906003)(110136005)(68736007)(26005)(99286004)(7696005)(6506007)(66066001)(53546011)(486006)(11346002)(76176011)(446003)(476003)(74316002)(305945005)(2906002)(86362001)(5660300001)(105586002)(3280700002)(3660700001)(106356001)(14454004)(478600001)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2321; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Ml54z2rHxSfxEKX9aDUZ59+HGpONn8MitBL5CAACMeQT7VUo9nShsh2QmQvSl1Ew/e85ToBJzS1q21dNUQh05HcX0jhvgMZ8uyDDOMWg8GLQlnm4UhN84gf8Fd+pQyi/QBzO+WJuYr0LWYoKymQ05bV92CDcH6Hr8ULeOvC5lef9AK/VrTw7LGWY3sN7LjQtH9I4mMvbfWN7WMIOMfQjAVGZC66XJAay9c2dG052YwVW8LYHW/wYs2PsViogxPigo+kWgGLaEPoqDBjJsb3QVXqZs8bPKxr4rRZFJ0qukLuvU6JcG5FcVRP6DZcWmFz9gzsE+NrgU47Ww6pJlZm1gyYH+BYiR0XrJ4FvSUxBZ7YsaH6uTUhkQPDUqUZQ32baivLVtYOnWmVtDRuFRwdS8/tnortsCVp/G1jv/G92tDE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a6c1b991-b822-4d3d-c784-08d59ef94c75 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6c1b991-b822-4d3d-c784-08d59ef94c75 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2018 15:39:50.8174 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2321 Subject: Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 15:39:52 -0000 It is OK for me. Thanks. From: Ophir Munk, Tuesday, April 10, 2018 6:36 PM > Hi. > Discussed with Thomas. > Please consider the following commit message: >=20 > net/vdev_netvsc: shorten devices names >=20 > Prior to this commit the vdev_netvsc PMD was creating tap and failsafe > devices with long names, such as "net_tap_net_vdev_netvsc0" or > "net_failsafe_net_vdev_netvsc0". > This commits creates tap and failsafe devices with short names such as > "net_tap_netvsc0" or "net_failsafe_netvsc0". >=20 > > -----Original Message----- > > From: Matan Azrad > > Sent: Tuesday, April 10, 2018 11:04 AM > > To: Ophir Munk ; dev@dpdk.org > > Cc: Thomas Monjalon ; Olga Shern > > ; stable@dpdk.org > > Subject: RE: [PATCH v1] net/vdev_netvsc: fix creating short name > > devices > > > > Hi Ophir > > > > From: Ophir Munk, Tuesday, April 10, 2018 10:20 AM > > > Prior to this commit the vdev_netvsc PMD was creating tap and > > > failsafe devices with long names, such as "net_tap_net_vdev_netvsc0" > > > or "net_failsafe_net_vdev_netvsc0". > > > Long names containing more than 32 characters may be rejected by > > > some APIs (e.g. membuf pool creation). > > > > Since EAL allows to use long names, I don't think it is a problem of > > the netvsc device. > > If a DPDK entity wants to use this name for some reason it needs to > > adjust it to the usage. > > > > I agree that short names are better and may help for such like cases. > > > > I suggest the next title: > > net/vdev_netvsc: use short device names > > > > > This commits fixes this issue by creating tap and failsafe devices > > > with short names such as "tap_net_vsc0" or "net_failsafe_vsc0". > > > > > > Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core > > > functionality") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Ophir Munk > > > --- > > > drivers/net/vdev_netvsc/vdev_netvsc.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c > > > b/drivers/net/vdev_netvsc/vdev_netvsc.c > > > index db0080a..bb2f78d 100644 > > > --- a/drivers/net/vdev_netvsc/vdev_netvsc.c > > > +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c > > > @@ -614,13 +614,13 @@ vdev_netvsc_netvsc_probe(const struct > > > if_nameindex *iface, > > > name, ctx->id); > > > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->name)) > > > ++i; > > > - ret =3D snprintf(ctx->devname, sizeof(ctx->devname), > > > "net_failsafe_%s", > > > - ctx->name); > > > + ret =3D snprintf(ctx->devname, sizeof(ctx->devname), > > > "net_failsafe_vsc%u", > > > + ctx->id); > > > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->devname)) > > > ++i; > > > ret =3D snprintf(ctx->devargs, sizeof(ctx->devargs), > > > - "fd(%d),dev(net_tap_%s,remote=3D%s)", > > > - ctx->pipe[0], ctx->name, ctx->if_name); > > > + "fd(%d),dev(net_tap_vsc%u,remote=3D%s)", > > > + ctx->pipe[0], ctx->id, ctx->if_name); > > > if (ret =3D=3D -1 || (size_t)ret >=3D sizeof(ctx->devargs)) > > > ++i; > > > if (i) { > > > -- > > > 2.7.4