From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0083.outbound.protection.outlook.com [104.47.1.83]) by dpdk.org (Postfix) with ESMTP id F13C62BAD for ; Thu, 3 Mar 2016 16:03:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dRdKQgc4Tanlb6Bx3Amoa4IT9w4SK1PhCjkxstuEO7o=; b=rv9WLhxOgwZtS5W3f8LMefMlbFK1HvDxhN70JML7byDAgjFVaHUszAXoyPuA+exCspdtiU6SeFHZgju615Elgqvpabp6wFOI/uZt+XnWzHTLzEpp2mY49s0/pHEy/iaXigXL09/OZvEIXA8R4QLyGe347gTiyYlxMMggltVHVFE= Received: from AM4PR05MB1651.eurprd05.prod.outlook.com (10.165.245.146) by AM4PR05MB1651.eurprd05.prod.outlook.com (10.165.245.146) with Microsoft SMTP Server (TLS) id 15.1.415.20; Thu, 3 Mar 2016 15:03:35 +0000 Received: from AM4PR05MB1651.eurprd05.prod.outlook.com ([10.165.245.146]) by AM4PR05MB1651.eurprd05.prod.outlook.com ([10.165.245.146]) with mapi id 15.01.0415.024; Thu, 3 Mar 2016 15:03:35 +0000 From: Olga Shern To: "Wu, Jingjing" , Thomas Monjalon , Rahul Lakkireddy Thread-Topic: [dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and new behavior switch to fdir Thread-Index: AQHRcDONLgD1oE/iTEWEfGTdE+ETt59H1u3w Date: Thu, 3 Mar 2016 15:03:35 +0000 Message-ID: References: <3102616.xnBgmsEaQs@xps13> <20160225093322.GB10077@chelsio.com> <3876623.1zX8JlhDJf@xps13> <9BB6961774997848B5B42BEC655768F8DC9E41@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F8DC9E41@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-microsoft-exchange-diagnostics: 1; AM4PR05MB1651; 5:4EkOf+Jz61lKSnUly2YPU5yO21IrNgqNKAhHqr9Rdmg6yuLclDA+KEvnPovB963aph9DTfN1V0r+9KBXppGlV2qBtUMm2IBurpCKbsuKlwdxCnZNAwjcHj7sz2mrEZYrvqFH7fLK6r0+rrEd7yhprg==; 24:DPsRsnuvIYjXe2LvEYFHrmXYlaNHmgvTienikcNcBIuVjJfYwMT0OJaugaC6Xre+2LnLP4AWU9E8sHWb0R10+AFdc9Yc99H05J5DP20DGfU= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB1651; x-ms-office365-filtering-correlation-id: de025b65-e0a3-4c99-f06d-08d34374fe72 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:AM4PR05MB1651; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1651; x-forefront-prvs: 0870212862 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(377424004)(479174004)(377454003)(24454002)(40100003)(5002640100001)(5008740100001)(5003600100002)(5001770100001)(102836003)(6116002)(50986999)(76176999)(54356999)(33656002)(86362001)(10400500002)(5004730100002)(76576001)(586003)(2950100001)(2906002)(2900100001)(106116001)(4326007)(1220700001)(77096005)(66066001)(189998001)(19580395003)(19580405001)(1096002)(5001960100004)(74316001)(3280700002)(11100500001)(3660700001)(92566002)(122556002)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1651; H:AM4PR05MB1651.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2016 15:03:35.2022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1651 Cc: "dev@dpdk.org" , Kumar A S , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and new behavior switch to fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 15:03:37 -0000 I think what Thomas meant is that we should redesign Flow Director feature= and call it something else , Mellanox is calling it "Flow Steering" . I = agree that Filtering may be more generic name. We have implemented Flow Director API in Mellanox ConnectX-4 PMD (part of t= he DPDK 16.04 patches) but we did is in very awkward way that will fit the= current API and some Mellanox features are missing with current Flow Direc= tor API. Therefore I disagree with Jingjing's statement that this API is generic.=20 Frankly, it is very hard to understand it , as Thomas mentioned ..., not s= ure how DPDK users understand what each function/field means ....=20 Best Regards, Olga -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wu, Jingjing Sent: Friday, February 26, 2016 3:18 AM To: Thomas Monjalon; Rahul Lakkireddy Cc: dev@dpdk.org; Kumar A S; Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and new be= havior switch to fdir > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, February 26, 2016 2:25 AM > To: Rahul Lakkireddy > Cc: Richardson, Bruce ; dev@dpdk.org;=20 > Kumar A S ; Nirranjan Kirubaharan=20 > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and=20 > new behavior switch to fdir >=20 > 2016-02-25 15:03, Rahul Lakkireddy: > > On Wednesday, February 02/24/16, 2016 at 14:17:58 -0800, Thomas Monjalo= n wrote: > > > > A raw flow provides a generic way for vendors to add their=20 > > > > vendor specific input flow. > > > > > > Please, "generic" and "vendor specific" in the same sentence. > > > It's obviously wrong. > > > > I think this sentence is being mis-interpreted. > > What I intended to say is: the fields are generic so that any vendor=20 > > can hook-in. The fields themselves are not vendor specific. >=20 > We are trying to push some features into fields of an API instead of=20 > thinking how to make it simple. >=20 > > > > In our case, it is possible to match several flows in a single=20 > > > > rule. For example, it's possible to set an ethernet, vlan, ip=20 > > > > and tcp/udp flows all in a single rule. We can specify all of=20 > > > > these flows in a single raw input flow, which can then be passed=20 > > > > to cxgbe flow director to set the corresponding filter. > > > > > > I feel we need to define what is an API. > > > If the application wants to call something specific to the NIC,=20 > > > why using the ethdev API? You just have to include cxgbe.h. > > > > Well, in that sense, flow-director is also very intel specific, no ? >=20 > Yes. I think the term "flow director" comes from Intel. >=20 > > What we are trying to do is make flow-director generic >=20 > So let's stop calling it flow director. > We are talking about filtering, right? >=20 Hi Thomas Are you suggesting chelsio to define a new filter type? > Why is it so complex? We are talking about packet filtering, not rocket s= cience! > The complex is due to different NICs different behavior :-) As I know, it i= s a common way to use used-define data pass specific infor to driver. Even flow director is concept from Intel's NIC, but I think it is the gener= ic one comparing with other kinds of filters. So I think that's why Rahul c= hoose it to add their kind of filters. As I know enic driver also uses flow director API to support their filters. No matter chelsio NIC filter uses flow director API or define another new f= ilter type. I vote the change happened in struct rte_eth_fdir_input, it pro= vide a RAW Flow type, And there is also a mask field for that, by this way,= user can have a flexible way to configure. And drivers can parse the raw input to define the filter fields. But for the change happened in struct rte_eth_fdir_action, only SWITCH type= is added, Where to switch? All things is in behavior_arg[RTE_ETH_BEHAVIOR_= ARG_MAX_LEN] which is black to user. Maybe your previous define in RFC makes more sense.= It's better to add user defined field but not for all args. Any better suggestion?