From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0088.outbound.protection.outlook.com [104.47.0.88]) by dpdk.org (Postfix) with ESMTP id BBE3314E8 for ; Wed, 13 Dec 2017 14:12:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8iiytA1e1URHjqaXSpZpsLPEFY3HaznK7BwHtKZIt3s=; b=U9p+dDRSsWW4H14KqcU6rRb3q9fJjZN77mYwKNBrpV+LfMtyJwtZFaBujmfbQFsMeL5LMqmcDdrR1exhAQc31rxBRg33154RkDGHFeARPI+TXyPCoDRvc48bQcLnzJURZRtgc7l6vtNuvTr+vu9S0oMzLmjpYCTG24n+w2T95cM= Received: from AM4PR05MB1907.eurprd05.prod.outlook.com (10.167.91.15) by AM4PR05MB1906.eurprd05.prod.outlook.com (10.167.91.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 13:12:10 +0000 Received: from AM4PR05MB1907.eurprd05.prod.outlook.com ([fe80::b0cf:4ecd:d349:a71]) by AM4PR05MB1907.eurprd05.prod.outlook.com ([fe80::b0cf:4ecd:d349:a71%13]) with mapi id 15.20.0302.013; Wed, 13 Dec 2017 13:12:10 +0000 From: Mordechay Haimovsky To: Stephen Hemminger CC: "gaetan.rivet@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts Thread-Index: AQHTcn115CKXx1b27E+40S1J/r1Rz6M+7ZqAgAJUx2A= Date: Wed, 13 Dec 2017 13:12:10 +0000 Message-ID: References: <1512996107-9331-1-git-send-email-motih@mellanox.com> <20171211173403.58ec6d86@xeon-e3> In-Reply-To: <20171211173403.58ec6d86@xeon-e3> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-originating-ip: [79.176.4.69] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB1906; 6:y2GxbiVvrcKlhcbPe1X0kqB7FHkiyVTEAwyWU9O08adVvUTcSfAo/rAn9ts5ZaUBZYd2E2gQ3YptJ4xCxlh+9NkUnlnWK6gY7JS3A5KLe5gEF9YBqX+YdxKyVCZc7y24naDvsxv9DiBA0fEsQDcFUu1oOqyVkIJu2sI9ppqsXTqQeyKGt5p7tcm/AxTBg03f2IcmIlkEYCmQLW8wf8fqCWBdo9XzvuLYYZMmTFopK3wNCyV7d336+Q6o/i813aEoMO8O1trDqqIQCSQo+DyV15AYLm+acTQrHsKc8VjHNIXtmBxdd9Cudzviv/1to7vk7fAOhgvt6Zjse9+tOZIhWnMB7MeonlG0X+amPs5lJYM=; 5:Dr1m1K9QmU+D7ItqgKeVBPoBHVn5ZnMwb1S/QwICzbtSExDL3lAVbp+1AwkYRcq3eB42g8lvLqSq8VN/l5PIIrvCXM0OJsOECz9b1fOgVMQbkGxorGQoCy7d79sbE1bMy89clEv/Wn+b4teB3dXbQD8ZtcGDWmYtlYmnQyt33TI=; 24:Y09tT4p715oG+Or+oeLGnaSMU2wYar817CdWJhQzTVzJ7WXTG2lQOnI2Xtq5PBktKP0W+XP5fnhVvQzbHlaurPbMpZIGixHkJ2t8eB5O9Ng=; 7:xKl+IPekxNN2WcMQuBxtoO5+ZBQo/Wathg9mgtdFjBoXP94BMTIV3xgbHqqF74Qu2TXd5YHf9YIruHxRn97ugyBhIVjGP/lU00LjGFeghwgEpF4/UjZvf4botI388ynVLBI/YMPfktQoieMHieHjxC4z8VFN/KlGx3adFg2oADtv4Tk3WM8QZdDmojLIxJSAXOtkCF6+T1iqoFNDrXey8uU5lxt/xzA44/CgysUS8CwUvRwl0SJvO+b8Z1jZ6h13 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3525d1a2-cc28-4b88-e861-08d5422b1ea0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307); SRVR:AM4PR05MB1906; x-ms-traffictypediagnostic: AM4PR05MB1906: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(6055026)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR05MB1906; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM4PR05MB1906; x-forefront-prvs: 052017CAF1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(346002)(24454002)(13464003)(199004)(189003)(4326008)(25786009)(6116002)(81166006)(81156014)(8936002)(2900100001)(3280700002)(102836003)(106356001)(3846002)(105586002)(97736004)(5250100002)(478600001)(53936002)(53546011)(6506007)(68736007)(8676002)(5660300001)(2950100002)(6246003)(6916009)(33656002)(54906003)(76176011)(7736002)(229853002)(2906002)(316002)(305945005)(74316002)(66066001)(86362001)(99286004)(6436002)(3660700001)(14454004)(55016002)(7696005)(9686003)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1906; H:AM4PR05MB1907.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3525d1a2-cc28-4b88-e861-08d5422b1ea0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 13:12:10.6431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1906 Subject: Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 13:12:13 -0000 Thank you Stephen, Will gather more review inputs and send a fix. Moti > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, December 12, 2017 3:34 AM > To: Mordechay Haimovsky > Cc: gaetan.rivet@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts >=20 > On Mon, 11 Dec 2017 14:41:47 +0200 > Moti Haimovsky wrote: >=20 > > + for (i =3D 0; i < n; i++) { > > + rxq =3D (struct rxq *)events[i].epdata.data; >=20 > Minor nit. events[i].epdata.data is "void *" therefore cast is unnecessar= y.