From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0080.outbound.protection.outlook.com [104.47.1.80]) by dpdk.org (Postfix) with ESMTP id 5C4711B651 for ; Mon, 16 Oct 2017 13:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dyx5+XOZE94A9NVhU2yFjl7h16eId3U6gAVdVlwKq5w=; b=gjx+qRP24oywWGd1zw7v9EPtF5XAMqOfSfL7RX361XRQn2Bi6/AlkfZdQXH5+/FGbWG5bY/AEce4OdCxo3UIaDc6Vu9kYmQlHuWN8Oc2/4ZkfDXHqeYPo3Roy6aoSg/6PrdYlfvNMvCNOM4KvLuM8+8csGFbFGOJkXuQ8liipAs= Received: from AM4PR05MB3202.eurprd05.prod.outlook.com (10.171.186.31) by DB6PR0501MB2038.eurprd05.prod.outlook.com (10.168.9.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 11:31:32 +0000 Received: from AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8]) by AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8%13]) with mapi id 15.20.0077.022; Mon, 16 Oct 2017 11:31:32 +0000 From: Ori Kam To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" Thread-Topic: [PATCH v2] doc: update mlx5 flow count limitations Thread-Index: AQHTRnBoQ3pxKVUNT02Qcq1Om1EE7aLmVFHg Date: Mon, 16 Oct 2017 11:31:32 +0000 Message-ID: References: <1508142759-24829-1-git-send-email-orika@mellanox.com> <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> In-Reply-To: <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0501MB2038; 6:7eH8RjtbCrLsBYye0yBS5E3EuPi0bkdRIeKPeA1GM66GuEXNtupUnvlMlQrnq+TAmzodSsasoWLN11/VlYPkptLtCrdrT//ye5BLiB1UQAI2E+aDEoD1a1WeMrNUzpcjAiFVz+XuViAo3ZOZpvB9wKUMu12R+YBLRuMk7qqxW7i2/g1E3qBvC0FKq8gko1DTrFgNi2gvm6pam1I0J+GQsP+eO+rStnkBynGR9OzWCGHW4EW4AOmw5u5JCYNV2Ln30g/qLbNR3iDlLj7758NgZyz5cOHBA6ZfkO1bKe8DAH43yY8tbM+gtBm4UU7H2xakZklBzK9QuQo7gEO/OQAUlg==; 5:TTIk+mu3xQP2qDr+PmtYb0ygovqLe8TFP5CqUh3jP3Npo9XDMzKXUMGagRBJViNuJSd8C/ombCaWChSuGVJL62s7sHOBU7MX218DNkvmY9guoUSDmr7drUZ8VuNBA3kWhIgbjkOi79waU2UokZ088e0+6S4CWPdKAMD7tpmZ8KU=; 24:815KJBiNWIrvqY1R8YM6FqFQ4UVpSNPCJT7G14FerA1vqjbOt67l66kBWa60NrDj+oBMjIasq4FHKxFXBaNB310OEMLuqp3Y3vB7QvzdL/g=; 7:dezPjFbTQmvIP3wvQnGyT8GCYTwlOaGTZswkNUjqC01alU5Z5IWGcAl7fIAHa8xL/W7rjly1/CL0iEPWLiwvmGosvA210PrZXWMe1c8WZac0oDZyj7e6wpiwplY+a0cOR0WnzI78BqygcLu7rzskFvMx1mQuP1iUert/Kze8gcrYBhrVA7wqxbTmYBONaVuDEj+wmTPWg9aWrtGgNizK6mFvvjipkYE9V1pdMDa72Fg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 47d3670f-856a-48ed-b2b9-08d514897360 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DB6PR0501MB2038; x-ms-traffictypediagnostic: DB6PR0501MB2038: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0501MB2038; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0501MB2038; x-forefront-prvs: 0462918D61 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(346002)(376002)(199003)(24454002)(189002)(13464003)(377454003)(3660700001)(2950100002)(3846002)(86362001)(9686003)(6916009)(6436002)(14454004)(74316002)(97736004)(53936002)(189998001)(6116002)(5250100002)(99286003)(7736002)(229853002)(5660300001)(102836003)(53546010)(316002)(305945005)(6246003)(6506006)(54906003)(478600001)(7696004)(8676002)(50986999)(81156014)(101416001)(54356999)(68736007)(55016002)(15650500001)(25786009)(76176999)(3280700002)(2906002)(33656002)(81166006)(105586002)(66066001)(2900100001)(106356001)(4326008)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2038; H:AM4PR05MB3202.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2017 11:31:32.0804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2038 Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 11:31:34 -0000 Please see my comments, > -----Original Message----- > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Monday, October 16, 2017 2:18 PM > To: Ori Kam > Cc: Adrien Mazarguil ; Yongseok Koh > ; dev@dpdk.org > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations >=20 > On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote: > > Signed-off-by: Ori Kam > > Acked-by: Shahaf Shuler > > --- > > doc/guides/nics/mlx5.rst | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > > d24941a..7da5c87 100644 > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -104,7 +104,8 @@ Limitations > > ----------- > > > > - Inner RSS for VXLAN frames is not supported yet. > > -- Port statistics through software counters only. > > +- Port statistics through software counters only. Flow statistics are > > + supported by hardware counters. > > - Hardware checksum RX offloads for VXLAN inner header are not > supported yet. > > - Forked secondary process not supported. > > - Flow pattern without any specific vlan will match for vlan packets a= s well: > > @@ -127,6 +128,8 @@ Limitations > > - A multi segment packet must have less than 6 segments in case the Tx > burst function > > is set to multi-packet send or Enhanced multi-packet send. Otherwise= it > must have > > less than 50 segments. > > +- Count action for RTE flow is only supported in OFED 4.2. > > +- Two identical rules with count action are not supported. >=20 > This last line does not bring anything, having two identical rules alread= y > create a collision which is not defined by the flow API. > In PMD situation is is even worse, as it will match both rules and thus i= t will > duplicate a packet. >=20 > There is no need to add a limit on an undefined behavior by the API itsel= f. >=20 The thing is that when you try adding duplicate rules without the count it = works without any error while if you add the count action then for the second rul= e you get an error. This line address this inconsistency. > Thanks, >=20 > PS: when you send a new revision, please use the --thread and --in-reply-= to > to link it with the previous one. >=20 My bad, > -- > N=E9lio Laranjeiro > 6WIND Regards, Ori Kam