From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59D49A00BE; Tue, 28 Apr 2020 11:34:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2B3C1D5CC; Tue, 28 Apr 2020 11:34:08 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by dpdk.org (Postfix) with ESMTP id D84401D5CA for ; Tue, 28 Apr 2020 11:34:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSZY3UvznlCH6rnkyDEWE3G48dXORrXlkMyo6tH8NMHoMlGcJfTbl3uWDrAGz1V+f3qV45v+kPhz5k3mq88ehbKfawXV6mD7zYlrpTSB42lSvDFzhb3LJBM9c7WZQ7dgdBUphToNBmacSx/QcdCIXjm+TClpnQSCkphWTHP3KgjiSK7MjPyOdZLB0mOB/xlGM9ecw+VSvCM2NF1+DFxOjM9hHcEx1nO39ke9hx6ArTyv/whq81tKyEn0eKJ8Qf+7A9iz0581qDS63AkLS5LxTfw49eXArnM1KsPibUs2zTtX4C2sobsxOtVZTX0/5BNzZMN/8Xoc0UVtqCK8tTWFZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4e2/FGfIxUBnWJaDACaziJhyztLfD82x4O1Nv8s7eRk=; b=md5odDrdYtO5/sPyP0y23qjvJ1U7fHQJZX9OygOiPX3/NdvY0aMg7hWNSucpp1cdlgkJADePVEBkedndti38Z8Sce9zwLaxPkL19qkDnZIlJV0grYkGPw6Js5uUlkf3ZmdBryhZM5R/W+AVCdlIZ0dMUHcT4joNBs+oqkSiQvWcz6hdDbK6wwirMTfAetw8uf83u/vkG1fNbGvujkAfcY+fNJZlBPWPAn3eAC40h6bQGnh8Jfajod0EtZVpDsCHimbSQwRPE8Vkgz3MirhPjktArUm4y4o9wcMaRqIboE6TiCFiSCPnXu7Jhw7GgrGXtrwrcdXc+WqBvQSa5474u+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4e2/FGfIxUBnWJaDACaziJhyztLfD82x4O1Nv8s7eRk=; b=oJuFIz7Cvs8xsiXSFcflDaIiUVxhNG8xveTtlvbSaCmd1qUFKiZicmuGRKZ8RcD5BLziMU5Xe4C10qV5bay/Y0afxltKQ4MvKqc4zePVwvoDNqfHZG9/9BnF1mfuSUkKL3Qew/tSHtR+fC8qOl94gVGHpu6DQ+QdUbj0y6Q0/2c= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:8::26) by AM4PR05MB3443.eurprd05.prod.outlook.com (2603:10a6:205:f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 09:34:06 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4%7]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 09:34:06 +0000 From: Slava Ovsiienko To: Stephen Hemminger , "dev@dpdk.org" CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer Thread-Index: AQHWGPWYAzDoq0gPKUKiInHRJgDh96iOTTAQ Date: Tue, 28 Apr 2020 09:34:06 +0000 Message-ID: References: <20200422223000.16602-1-stephen@networkplumber.org> In-Reply-To: <20200422223000.16602-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5594677f-2526-40f7-3e37-08d7eb574c0a x-ms-traffictypediagnostic: AM4PR05MB3443: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(366004)(376002)(136003)(39860400002)(81156014)(110136005)(186003)(478600001)(6506007)(64756008)(8676002)(26005)(86362001)(9686003)(2906002)(4326008)(66946007)(66556008)(66476007)(66446008)(76116006)(53546011)(7696005)(71200400001)(55016002)(316002)(52536014)(8936002)(5660300002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ULVAjfZzJ1d4oOueStmgLMQlmbmdtZ2P3rVhpBzXeXjqAxaqCFmfmTvpKrgZDU7FsovUM5SUBlcggRhjbwusa+Uim1Mlg9YaMcx6nyKX2QEEVa4YWxECQCLt1TgOX2z/SGKF3AGDKECoovkpFqLVM2GDuF1mJCsjzqXi1hOtMZRFIurG/s/BSYZcpjiBvQBqUXxeItD1vw/3IZDeghQD4nemIdwQbTk4mnpZpnXyBunabOkLZdXN49AXMORLmBcjpu9T1QJHz/mUtueNLWQCZl2IRGoFq5DIG0b2Cw4n8bBCnubV8qoCEk5Utm1CCIRruRTZTCwU7J9MNr0wR5VfpMzry1r3DvTNToOUHS2MIs/0ZV8gh8nbUHhJXeRlUBPch7v8Aj0YCsBQrP6780eLpYK7yKVQ8iogDPSlblvWw3mGw8F1wCLe58MN/cKcQ6Kl x-ms-exchange-antispam-messagedata: Mk7kP4kC6Z0SnkglLpDADk2fYzJpBvyni4g5VZZd3/jx+YzXLjeqYmYYoe/Sdzo7+9eabSox2zJO9lHg+1qdYyczxTHw6njzlcUh9d+m2+4dS61Rfh4TbqtZJM45gPTx2zIHCJKhzNhJgVTfmongxWHcie2FnhH7NJdcKjQwrverDx8dQyKBoHZXxafWu7AB07J9i+sV91XdiQwNF8QqcFFIRpAiuyqeBXE0qzAyeBV5ByhPklr8AVqPZ1fvAD3cucn6aa/Dv0jO5J+50CdWzijB4H0rxv+XKdA28IOAMoMFIDn2/kLdDTfOwntvY51owu/458ZCZxTrSCocbR/bf+S0si85B+VB3CHoqYrnr98FEVal+e7vuFVPTRlm7G+LCITIxs6HDVCzKdrVuyKpG2cdcP1NrCBL2rSONYxQ+ygWn+K4B9sG3CDMFScHiKlcGvwAutr0Um6Hr8OpyGEAppeGYLOsTWbRTdOaEhzIQfEuUm5pRkE9akmJ4hW2kZXFMsa6D8v4FF+PljAJ8+VWION8gdJRxEFOuXEeKC+VgEXBpq6LChOWXnNq11LGDncLhrDXgeULWSM+OJPt0b5e0ejivWXGZXMK2uu4tNCQpR0VG2zYximvVyAl4On7WUV0bV5OoWu+LRiqigzdaPB4Xwf0pbowQNNlQnKi7lHb1XwDyBL8eVks0aQpSCyPPd+LSFYYU2zMjIIDTz43bmf9AX73TSh1u8Nh4bKZbXciZEPRL3Z2dGFzaQQykN/7PdNK++ZxXbP5RpsnEyzhPImCOc4WNWZ/fQkJMcUgcyUt8B4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5594677f-2526-40f7-3e37-08d7eb574c0a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 09:34:06.6056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ihyNRO6SJxDinQUzCyMe9bvUV3xpLO8NELnTFWtoZxaI9TcsyiDPhuL2UOTWqKCKoz+eJeEoPfwlC9sUuCQKZS750Ouah3AxFYHBZ0NTeyM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3443 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger > Sent: Thursday, April 23, 2020 1:30 > To: dev@dpdk.org > Cc: Stephen Hemminger ; N=E9lio Laranjeiro > > Subject: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer >=20 > Since the driver is just using netlink to receive acknowledgements for > command requests, having a large (32K) buffer is unnecessary. Not for acknowledgements only, it is also used to get the dumps for the MAC addresses and Infiniband device ports, as we know dump operations might merge replies into one large message, smaller buffer might prevent the dump receiving. What do you think about the buffer allocation on the devic= e initialization and storing that somewhere in the device structure? With best regards, Slava > Allocating large buffers on stack will break in application is using smal= ler per- > thread stacks. >=20 > It looks like original code intended to use a smaller buffer for the read= than > the socket, so keep that set of defines. >=20 > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Cc: nelio.laranjeiro@6wind.com > Signed-off-by: Stephen Hemminger > --- > drivers/common/mlx5/mlx5_nl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_nl.c > b/drivers/common/mlx5/mlx5_nl.c index d9f0d4129e35..847e78dbcea6 > 100644 > --- a/drivers/common/mlx5/mlx5_nl.c > +++ b/drivers/common/mlx5/mlx5_nl.c > @@ -28,7 +28,7 @@ >=20 >=20 > /* Size of the buffer to receive kernel messages */ -#define > MLX5_NL_BUF_SIZE (32 * 1024) > +#define MLX5_NL_BUF_SIZE 4096 > /* Send buffer size for the Netlink socket */ #define MLX5_SEND_BUF_SIZ= E > 32768 > /* Receive buffer size for the Netlink socket */ @@ -330,7 +330,7 @@ > mlx5_nl_recv(int nlsk_fd, uint32_t sn, int (*cb)(struct nlmsghdr *, void = *arg), > void *arg) > { > struct sockaddr_nl sa; > - char buf[MLX5_RECV_BUF_SIZE]; > + char buf[MLX5_NL_BUF_SIZE]; > struct iovec iov =3D { > .iov_base =3D buf, > .iov_len =3D sizeof(buf), > -- > 2.20.1