From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14F6FA0535; Thu, 23 Jan 2020 08:57:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88BD8343C; Thu, 23 Jan 2020 08:57:44 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150051.outbound.protection.outlook.com [40.107.15.51]) by dpdk.org (Postfix) with ESMTP id 28F5E2B98; Thu, 23 Jan 2020 08:57:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQc6OiV+fTXrBshhPs3xdTc+2aRjk016tb6c/FlTj/CN85M5Uybc21q+cz12OAVfsH/c7Sk/7kNExafB9BrOBynk3im0b3Lj7DhwsFdXdaFV2KFV19fXevGDJU7Ydd8u3SWau9x8wt0dEmiyOHN8G880LbKBDbC2vbaKlLs2lADss7FrcA5Fy1O/FY65f1tHUH6X9RPiXmi8+E2IZvqreBxRGUhMroIzOjdZV2Uv6PXVy+0h4eu1ZJEI0+SHz+aB7hAWLUcqR3tJod17/d5pWg0OpQmU7D4TytyhwDOONH2Q+CSt8EVmqClfQWMlw2lKNTtKg4xWMJ5Z3V7xxIfKaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gopz/u7fW6Vt97HpW9swfsRVUQ2rgg8K70si+KlIkr8=; b=cenp8adC/bk6FL/RU78TszM+9aPBHwQTUfdZ9TA1JjXSyCgbxfXUi5I4/lGTFZWhUGVxAoVKqCBr5fUE1VuGJ+ZIHh4TlejiF5927iPKMFB6nICJTJhVmzTPilDEnVItJc84i9Hi53wmW6x6Nx1YT7WJN3fje7PFhknDyNFtJQDdlDZBnYnk3YDugiv4kLCjvqIZqN2e3V6YDYhWCpVHYGK2RCrvu2vCib+atfXWGRAUNMmdjnK7SeXeG/0wyV44qcxkCZPAw5AtLq3RN0a8fW78wNEjOa9Hg5dlGJEtXu2AlcYKCEXwrzZY40I6RpNdNSq9TR4hY4ojQm+2DVwaHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gopz/u7fW6Vt97HpW9swfsRVUQ2rgg8K70si+KlIkr8=; b=b46aMVhBk0BewdGlMZX6zKSNqAWwwJNR8FLErT0DppFaTLvSbM5AGx++3aLPMqfSVEDG2sOM4Sf67PYDwDm3HDH4bpUvLygrmlO+UUyA3s6vi4QIeFBanuA8XL5c8hhnz4WoBhx0MkZoGhZgZCXv4Lxsc8+xdj+rnbQkwi23uWQ= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Thu, 23 Jan 2020 07:57:42 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:57:42 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 08/11] net/mlx5: fix pop VLAN action validation function Thread-Index: AQHV0TB8GnMo/0ukDE6NzMALg9DmLKf34yyg Date: Thu, 23 Jan 2020 07:57:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 140272b9-5b36-4015-50ac-08d79fd9ecb8 x-ms-traffictypediagnostic: AM4PR05MB3492:|AM4PR05MB3492: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(189003)(199004)(450100002)(81166006)(8676002)(81156014)(2906002)(316002)(54906003)(110136005)(8936002)(4326008)(55016002)(9686003)(186003)(26005)(7696005)(53546011)(6506007)(5660300002)(66556008)(66476007)(66946007)(76116006)(64756008)(66446008)(52536014)(86362001)(71200400001)(478600001)(33656002)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D5lUyU9kjMhyc1zgSqN6cjG9381Ww+nU5s5VZlZld9deJ2Hkk+RsR9l718SMaoXtPurB2r+ijekhOCvOXWNiVobVL0gNyRRhSuiaQcCVJyalu28l0JDfIK4lrEdYWC05yswyjtde3q9TLex3a7mM4R7alvzLi6AfbbxZNAeMlaUbqjIAiCTZgd3C+YfYzCezz5q0GJeXgDxc0veRHbljfijk5Z1rKPCND40Qgk01MrctMNYcwEkbCJTtnldT/B2S2CZ+FhBepSh21b0dZ4wkPhBwekq+3UFC9yca+Y7MVKfmUnlfj1SjynMPhomA4pZANXs0mdp2JHNBc0nbEvZ6yWSGwg5qo472SHyM28ACl2lKN0Rd8Mihv8mg5mlLk9i+cA+4f+BHqQ2BbKsrSAUcFCjAEK22DpR+Pe/4AvJLzjgHMQTXcHPR3ePfJLWN4crB x-ms-exchange-antispam-messagedata: OsreA6VfLwJHrKbI+KhytW3HFa8xysPBTYIiln2zPL9GuSEeO9a8/Baqj8NnTYcC7/5u1ef7IMxf3QYwhzlkXo8c2CXR+AKOByOGLndHsfqVWLodUGJSIfL0tXgehEgYb8d7GQFA/dMcXNJ4fc5kpA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 140272b9-5b36-4015-50ac-08d79fd9ecb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:57:42.2457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8C4ru05NehRafKlUbw9IC7mwW7zvV7aJROQYXjOYRtrUHDOsNwGwx2R8pzXS/eUcXp7MkNaLQ1zzi+KHjnu36UNxLerYrC9dV/oCn/v+GlI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-dev] [PATCH 08/11] net/mlx5: fix pop VLAN action validation function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 08/11] net/mlx5: fix pop VLAN action validation function >=20 > Validation function of 'POP VLAN' action includes check for other 'POP VL= AN' > actions present in flow. > It doesn't check for 'PUSH VLAN' actions present in flow. >=20 > This patch adds check for 'PUSH VLAN' actions present in flow. >=20 > Fixes: b41e47da2592 ("net/mlx5: support pop flow action on VLAN header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 9dc08ce..de4b765 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1640,17 +1640,10 @@ struct field_modify_info modify_tcp[] =3D { > NULL, > "pop vlan action not supported for " > "egress"); > - /* > - * Check for inconsistencies: > - * fail strip_vlan in a flow that matches packets without VLAN tags. > - * fail strip_vlan in a flow that matches packets without explicitly a > - * matching on VLAN tag ? > - */ > - if (action_flags & MLX5_FLOW_ACTION_OF_POP_VLAN) > + if (action_flags & MLX5_FLOW_VLAN_ACTIONS) > return rte_flow_error_set(error, ENOTSUP, > - > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > - NULL, > - "no support for multiple vlan pop " > + RTE_FLOW_ERROR_TYPE_ACTION, > action, > + "no support for multiple VLAN " > "actions"); > if (!(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN)) > return rte_flow_error_set(error, ENOTSUP, > -- > 1.8.3.1