From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35980A0535; Thu, 23 Jan 2020 08:58:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C5053253; Thu, 23 Jan 2020 08:58:29 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80]) by dpdk.org (Postfix) with ESMTP id 981402C6D for ; Thu, 23 Jan 2020 08:58:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CpVD4N3oBEswSSz9zCaPlL4P365nhRp++7ZcJc/QSNRh3dz0cVYAI/NfiMOfmknirVwHoYkAnWsXTuabwL3KjhvgGmz/bvaRxYbspPyEpIt2Cci7XzjtOKn1b+tMZ86qjAl9vQx/qT7oGLXJJ3nGiNU+H2BcIi6mOrqv1RvhYp382OnCCbRljwyGJMClnD5HjzTwQgLdWM/sUs/wWGWfDOIMUoBMHMXKCLsGPcfEWoIxSfhFREFVa/v0Gr2amRN/rQGmOYB3BwBQmODzN2op3vd4RHqutZxyGUzcaDm0/ObUcmfQLDOUp9D6mBkyHEex9Pr9CBjwJPtmSzZSQWWAJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yo48T9tajsh8r1qqbOelxvXdJpyGqqQxf86de5H9s4=; b=YLMN4/iME38dBu3IB12aRTNrJtcJ3GPsDR49A+pxDug/iwkzAd/1omJ+D9Uz+e3PcMNofCVoSWIcY1mPuSkSJK7107RngrrHIp9Q7P0gMdDBwq/wODNI7Pbj7JJOTWzrL7dXw/bq3l/EDebnslkaLghMWeQ1HN/NZcpX+Q60X6bMhsCtvX8uoHdV8UpnGYl3Ysmqrx2WGr4seyCA8CgsdVccr6EH4O7iRpWr1sr1VXdNVT0tSxrjKIt/cnix7PJ2EJQJcarRBCrrwSm2avE632OfsqTOqdNaaUxo5cs+O0Z0T+L1PTntGFyI01031VwcmsHombUUbNW+OLd5k+IB8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yo48T9tajsh8r1qqbOelxvXdJpyGqqQxf86de5H9s4=; b=gJ25zgcZnsL0IPmeWxRnRsNQ+U8DX0e0FK2UerzhTdDU3MdIGJohhMdVZHGESTUvmJfEe2obluolpahA7FvG8dFccINEsGv8vdjDK/v2J5amddL6F8bLpYRzfoEAQTo1dPZC8RY5XxL6gw1k2S/LzhDs4NKBX02v57IAJzZeqFo= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Thu, 23 Jan 2020 07:58:27 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:58:26 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH 10/11] net/mlx5: update description of validation funcs Thread-Index: AQHV0TCqHX9QDG1UKEub0oAqY9pmZKf342CA Date: Thu, 23 Jan 2020 07:58:26 +0000 Message-ID: References: <6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com> In-Reply-To: <6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7bc72e63-9322-492c-0ab7-08d79fda073c x-ms-traffictypediagnostic: AM4PR05MB3492:|AM4PR05MB3492: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(189003)(199004)(81166006)(8676002)(81156014)(2906002)(316002)(54906003)(110136005)(8936002)(4326008)(55016002)(9686003)(186003)(26005)(7696005)(53546011)(6506007)(5660300002)(66556008)(66476007)(66946007)(76116006)(64756008)(66446008)(52536014)(86362001)(71200400001)(478600001)(33656002)(15650500001)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +Lz86I2/COBaIbM7TuZIB5OcwheHi67QdEriiJ6uax1tzQjgWf7YRmDOD9go4Z0F0ZyvLX11xBcVz9Qa5P4//B8W6NR2Oubik087RKxve8LbV2ov1VJeB0Ufe/6OtXcm7PtnmSfHfHYedj5q/xtU7rETTta0HKgpezMGyxxo8ZsLJD6W3zYoQHkgf5+JsqE1pqRjCU/PrZ4VJPT8+Fw7et5TBL42GrsttuFj20xeIODnYsoOPKGayxBF60zJfIFbRwShI3Q2Rtyf5TtAiEoeTOUd5xbP7OW1T88AXSIiLgdP/Tq+59O7scBKhgWKcBZwufqcEzhT4jPNmVnblP+1KKIUCVrQ5huOLTqjKhEmjiVoE113R3v79jMUv/VFRaelRzWvIzfEArxD+L9IZRARgB2vWrqtiUcrrMR5PjvpNIePDScOdBkRpx9Gd0loRzyd x-ms-exchange-antispam-messagedata: OPa63iuF5AQtKFOqVtu+5fOXXIGhvmcX6/cgzvAVguNKxMiQnA8mqR0PKWVbWoqw8p964bR2rqlzp6VitgL1EuI/m1/Q3ch97bzAvRfwyUGwUadI6dO+6ckROjIRMC2XTgnsMLd+93hGtxJFk941bA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc72e63-9322-492c-0ab7-08d79fda073c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:58:26.7907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqoEj0KL0V2T0wqZeRIO8KF9AKZAUYG00YpIsDIoiFyyN8BTTxE4q5gsoG8CoNYEUCtUe0jRrlEMW0vXbRQLof2HXgGvLCldDZLqB9cvkFo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-dev] [PATCH 10/11] net/mlx5: update description of validation funcs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org > Subject: [PATCH 10/11] net/mlx5: update description of validation funcs >=20 > Description of several functions is not accurate. > This patch updates the description, parameter names etc. >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 4b6a92c..059d03f 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1662,14 +1662,10 @@ struct field_modify_info modify_tcp[] =3D { > /** > * Get VLAN default info from vlan match info. > * > - * @param[in] dev > - * Pointer to the rte_eth_dev structure. > - * @param[in] item > + * @param[in] items > * the list of item specifications. > * @param[out] vlan > * pointer VLAN info to fill to. > - * @param[out] error > - * Pointer to error structure. > * > * @return > * 0 on success, a negative errno value otherwise and rte_errno is set= . > @@ -1721,8 +1717,10 @@ struct field_modify_info modify_tcp[] =3D { > * > * @param[in] action_flags > * Holds the actions detected until now. > + * @param[in] item_flags > + * The items found in this flow rule. > * @param[in] action > - * Pointer to the encap action. > + * Pointer to the action structure. > * @param[in] attr > * Pointer to flow attributes > * @param[out] error > @@ -1772,8 +1770,6 @@ struct field_modify_info modify_tcp[] =3D { > * Holds the actions detected until now. > * @param[in] actions > * Pointer to the list of actions remaining in the flow rule. > - * @param[in] attr > - * Pointer to flow attributes > * @param[out] error > * Pointer to error structure. > * > @@ -1988,7 +1984,7 @@ struct field_modify_info modify_tcp[] =3D { > * @param[in] dev > * Pointer to the rte_eth_dev structure. > * @param[in] action > - * Pointer to the encap action. > + * Pointer to the action structure. > * @param[in] action_flags > * Holds the actions detected until now. > * @param[in] attr > @@ -2049,7 +2045,7 @@ struct field_modify_info modify_tcp[] =3D { > * @param[in] dev > * Pointer to the rte_eth_dev structure. > * @param[in] action > - * Pointer to the encap action. > + * Pointer to the action structure. > * @param[in] action_flags > * Holds the actions detected until now. > * @param[in] attr > @@ -2103,7 +2099,7 @@ struct field_modify_info modify_tcp[] =3D { > * Validate count action. > * > * @param[in] dev > - * device otr. > + * Pointer to rte_eth_dev structure. > * @param[out] error > * Pointer to error structure. > * > @@ -2135,7 +2131,7 @@ struct field_modify_info modify_tcp[] =3D { > * @param[in] action_flags > * Holds the actions detected until now. > * @param[in] action > - * Pointer to the encap action. > + * Pointer to the action structure. > * @param[in] attr > * Pointer to flow attributes > * @param[out] error > @@ -2995,12 +2991,12 @@ struct field_modify_info modify_tcp[] =3D { > * > * @param[in] dev > * Pointer to rte_eth_dev structure. > - * @param[in] vlan_tag > - * the vlan tag to push to the Ethernet header. > - * @param[in, out] dev_flow > - * Pointer to the mlx5_flow. > * @param[in] attr > * Pointer to the flow attributes. > + * @param[in] vlan > + * Pointer to the vlan to push to the Ethernet header. > + * @param[in, out] dev_flow > + * Pointer to the mlx5_flow. > * @param[out] error > * Pointer to the error structure. > * > -- > 1.8.3.1