From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45A40A00BE; Tue, 29 Oct 2019 19:35:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 922EF1BF4F; Tue, 29 Oct 2019 19:35:27 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60062.outbound.protection.outlook.com [40.107.6.62]) by dpdk.org (Postfix) with ESMTP id 622F31BEC0 for <dev@dpdk.org>; Tue, 29 Oct 2019 19:35:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSyqzud+dJLAQC0OONstG3t2TRbw8O/1tx1vjoQOvMDk6RZYLK3ZQFNJgvihqmwT9CoUsg8E85Jvow9EHQLkiSevMgyDs/smekRlbImCFWSrX6DoVyAo3CGfrBFpzupCexpvRV2Ln5YR5khNcv6Iltw2/xeMpNDmRp5bSkFpxxYWwgJ6CB6CynRq77n/bbmqTChO209u91H17o74yQVRLczkSZBSXr61VWw9EABz0jrsRtvjJ8qQynIaWfuKv0Qirzmu0tg4masInodr5OXYcfZDXBk3cYcCgw7flBpZW9xw4uwoowFOooUVxIRa3XERPraU1H2rFvLE7SC+bz933Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=md97RbelfK+TC/vXUg1grPwGzhGcBcIQUMGN53kLEcc=; b=AHZmgHqKlAbP5R1fkmZho/0vMFgWHaiXRMp6pkdTIXVSakSHHXeJhfUdlKJKDu6/jwjV5dqdnnqtwtTal5wk8OXjLtSqb2ehsCp+FyeVDFj0EYhSP/5PVoH0mp8Ig93190ifG1YyC1hk8rYgq8Kmy65Q2BrKAkvyzXScxggVP3Xy5lCP8s7eJ6hlLmOm7Xip8hLvtadaPWm4ABIMg0n41l7yCWzTs8VMHiYEu8QIjRPfgTvG4jTTe8m7/fMI3dE153Gb/jMhb2joXns0sVn7O9nT8he4cImo6NiV86Of4jfwj3Gzr7kMOt+i1CryhXKpUWNdBxfGfHFG4X/MWUVw4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=md97RbelfK+TC/vXUg1grPwGzhGcBcIQUMGN53kLEcc=; b=gGT/pk4yod1MrGECKa6m0odo3MQaSiYFNS6ndAymWqf9yW6Am0PdVQtra540fFKIOKWDMQYHYFVDjWQ5LOKVmHa0aRP6F2ClQlkN1DdhaugAXVPXMujzmqMEhIuBR4bS/NxDkpdkKsLt3WZojnei0eTxpQhDJw6D9DSjaeVDchA= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3329.eurprd05.prod.outlook.com (10.171.189.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Tue, 29 Oct 2019 18:35:24 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.027; Tue, 29 Oct 2019 18:35:24 +0000 From: Slava Ovsiienko <viacheslavo@mellanox.com> To: Thomas Monjalon <thomas@monjalon.net> CC: Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, Ori Kam <orika@mellanox.com> Thread-Topic: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata Thread-Index: AQHVjPYP3yCquRGX4Ean9kYpOkOfjqdx0C4AgAAEMrCAAB+SgIAAAQpQ Date: Tue, 29 Oct 2019 18:35:24 +0000 Message-ID: <AM4PR05MB326552A33C9F597C9ED5D84DD2610@AM4PR05MB3265.eurprd05.prod.outlook.com> References: <1571922495-4588-1-git-send-email-viacheslavo@mellanox.com> <d19ddcbb-8ea5-17d8-efa0-e9e8305b6671@solarflare.com> <AM4PR05MB3265862E508CE480DE9C7462D2610@AM4PR05MB3265.eurprd05.prod.outlook.com> <5596453.zqmvSB3bmi@xps> In-Reply-To: <5596453.zqmvSB3bmi@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d83284ed-6559-4874-5f48-08d75c9ec34d x-ms-traffictypediagnostic: AM4PR05MB3329:|AM4PR05MB3329: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <AM4PR05MB33295626200B8A3512DE825FD2610@AM4PR05MB3329.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0205EDCD76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(199004)(13464003)(189003)(316002)(52536014)(64756008)(476003)(14454004)(53546011)(33656002)(107886003)(66946007)(6506007)(54906003)(6246003)(74316002)(305945005)(7736002)(4326008)(5660300002)(86362001)(11346002)(186003)(102836004)(71200400001)(99286004)(256004)(71190400001)(66066001)(14444005)(2906002)(6436002)(66446008)(25786009)(6916009)(7696005)(76176011)(446003)(6116002)(8676002)(229853002)(66476007)(486006)(55016002)(26005)(3846002)(8936002)(76116006)(9686003)(81166006)(478600001)(81156014)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3329; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vOTt1BbkSHlMU512f7r2OY4pxYu4Iib+G9+iFcVUp2X99q4WuSEp9qPF+nWOp2fRv/1Tvcw4EZTekgFxFfDaTgRAC6Xd5VE+Tzn3CFnNqLMfrITTcTy4HUBebYlIO/DTAvbQYZb0Xq8ppwGY0mWbxDeW6bvIw4c3yUgcIwlsx4AJ8Y5erMH3lW2sNQdq+EHG0cGeNVy+fChTqzUZ9L6ZIW7fV60BicXPbHIGft88YkM4Mea6qXxq86L3ROnj3w63O75LINaLcoPErJ209a/n48nZg+bIEGDOV/WnuVEn3xn0XYUu8ABOSeWiB8tafq9Bt7eMwv4NW7f9bDjqU9zRr3e9eumlZTqO/uYBOwUHTGKMS5hsiPzzWhuDklKfxbC3rx+/tlZH8lrwXsZrWHStdswmGDfTAQFeaI3GmL3qtnNUL8Hzq4dp9HcpHl0eSzNC Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d83284ed-6559-4874-5f48-08d75c9ec34d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 18:35:24.6241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z2iTUjQxBUhnkn9hm48c5hQahk2XHq0JWoV8wANf83ZDe7AZ26imaoF9exrEH+qV594eJOrxOwgCEE+oimlaNwK7RbCGQY4+N2uX3UINBF0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3329 Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, October 29, 2019 20:30 > To: Slava Ovsiienko <viacheslavo@mellanox.com> > Cc: Andrew Rybchenko <arybchenko@solarflare.com>; dev@dpdk.org; > Matan Azrad <matan@mellanox.com>; olivier.matz@6wind.com; Ori Kam > <orika@mellanox.com> > Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata >=20 > 29/10/2019 18:19, Slava Ovsiienko: > > From: Andrew Rybchenko <arybchenko@solarflare.com> > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, > static > > > > +metadata > > > > + mbuf field will be removed in 20.02, metadata feature will use > > > > +dynamic mbuf > > > > + field and flag instead. > > > > + > > > > > > Isn't it breaking stable API/ABI? Should target release be 20.11? > > > > tx_metadata is in union, it should not be ABI break. > > And we propose to remove tx_metadata at all in 19.11 and share the > > dynamic metadata field between Rx and Tx METAdata. >=20 > Yes please, let's remove tx_metadata from mbuf now, while adding > metadata dynamic field. > I am sure nobody will complain that we sanitized this feature before > releasing DPDK 19.11 LTS. OK, I'll extend this patch to small series and update tx_metadata in the dedicated commit (to simplify reviewing either). With best regards, Slava =20