From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F39A10DA for ; Thu, 1 Aug 2019 06:32:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E5DB1C0C5; Thu, 1 Aug 2019 06:32:12 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130043.outbound.protection.outlook.com [40.107.13.43]) by dpdk.org (Postfix) with ESMTP id 459531BFE0 for ; Thu, 1 Aug 2019 06:32:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjj2BPWZj9Kekq5xVe0FvMrJkMqPs4Z3xbLR1fzUoHkLH8RkbLPgW8pbQCjkL0swW9gGrDF7NTNEzyCHrz355ibpF6KuV2JqYTalY8PNZ5sxTWu2wD/ikuEgOcJjCMcCJzefiyZsxyN8n8y2JloMq97LuxaNOqB2WbxWY3iVm9gu7LPxOzNkkUWxzI5woWNpOq19ZtlKGJkC2SPm0XoTcjgKvhJRdgZNKfVenDQtO6DHS3DVTycamBTC5nvELQdc0Gg/DaFz15FJNWshOv9Lsun9oh9eUlGCwLV3aglcLvQQA/rP6W5800M9g2Lnicz2fhGQpxIfgxOZLPumewhrRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cSpYGW/TuOb1qAkQZezYOyzcv2jHuJQIuAy4W+vNWs=; b=EjrobVLMUBuIxd1ZwK/vPaSs53GXQDvl8Cxt2nmkXmIblrVLyHIb3REbLOwi5jfDfsLkZA3GFaaKXzJNecqphIYPxQ6ojXrK+qkiw6h60O64pcE2/RAdKJ5hldrM9BL6r1YsgLGUME16SuhMDGRYyXBbYg8F5dAckh5erqTNBxO4PC9W23LyTKpDMfpsnDgpSC1bEMDIvzCE2ermxUyFdj1rHgbmtipIvxf7fdadfy7d2LxgezeG0bSVhX++CtZtGbDoPKhU1UoWtpkgaHwDlIIqkxBaWc6tSOTxVbPgjb+g581XaKvXpiDJQsoii5AcKV6wWp+N2TDw7YiT84XxaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cSpYGW/TuOb1qAkQZezYOyzcv2jHuJQIuAy4W+vNWs=; b=aV5Hecw5MPxJxpvmPKaySCV8RnYTKhOb4wsP4SAfQc+zi1sqAauFocrLScfgiS/KqORnvsbU5DCcEndPPBlt2ECKOMxLC/XC+iYeC6cqiE4txMIm/bMEXF7+9bQbUDFbH/j/nHqlK+/9DjxM6bUFW1e3aAMRWdKJMc1TZMN2Q/Y= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3154.eurprd05.prod.outlook.com (10.170.125.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Thu, 1 Aug 2019 04:32:09 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a%4]) with mapi id 15.20.2115.005; Thu, 1 Aug 2019 04:32:09 +0000 From: Slava Ovsiienko To: David Christensen CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters Thread-Index: AQHVR/EaS++0LoRmg02VmR27UQ8EqqblsGtQ Date: Thu, 1 Aug 2019 04:32:09 +0000 Message-ID: References: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fd2da8c-cc6c-443e-925b-08d716393767 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3154; x-ms-traffictypediagnostic: AM4PR05MB3154: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01165471DB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(13464003)(199004)(189003)(6916009)(229853002)(52536014)(102836004)(33656002)(99286004)(66946007)(7696005)(76116006)(66066001)(7736002)(66556008)(81156014)(66476007)(81166006)(64756008)(305945005)(8676002)(66446008)(8936002)(74316002)(14454004)(76176011)(53546011)(6506007)(5660300002)(25786009)(14444005)(3846002)(256004)(6116002)(71200400001)(71190400001)(2906002)(53936002)(11346002)(478600001)(68736007)(26005)(4326008)(446003)(486006)(86362001)(6246003)(9686003)(476003)(55016002)(186003)(6436002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3154; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CD7z2BKsdZQ9KzfUbgLXV4M7grxFlZntHISsnrC4S9bfo9DUZFELwrje1avHr1BmRlrwnP3VH6EQ31sXGErglCWzS8KP7ocwZRsdtxpKrBUSsvKV2OK9TCGc8gTV/cXYRgoCatWrhQOLzNNTn8feCHta9/IiIpLbxTXM3jxu6kGV70ElAr1YTi0be59s98IGJ/AvSfyS0utXXxEFQo5L5J/nGWCsUQbu2vaDW7hOSmVLJiXOMqs0MAFri0Wh0x8mq/ZF1bwinITJ75u6ya1J538cU92iQSIREmvmhXv2ZS/j9QhC27fjb1v7Hk4dkqv+VMRbBHgCuELp+yyIaoii6F0ny1Xyowvt3vt/mSaKRiBPpb4s8dbuU+P0W9+pcjlVPN1Bqb5bWHO6/gviO67dmYrZvzZCK2UlEz26WVnQfJE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd2da8c-cc6c-443e-925b-08d716393767 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2019 04:32:09.2937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3154 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, David Yes, thank you for the patch, acked. The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG= _UNSET=20 and default value 0 is set: txq_set_params() ... inlen_mode =3D (config->txq_inline_min =3D=3D MLX5_ARG_UNSET) ? 0 : (unsigned int)config->txq_inline_min; So, there should be no negative backwards. Did you observe any? WBR, Slava > -----Original Message----- > From: David Christensen > Sent: Thursday, August 1, 2019 1:41 > To: Slava Ovsiienko > Cc: dev@dpdk.org; David Christensen > Subject: [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters >=20 > The function mlx5_set_min_inline() includes a switch() that checks variou= s > PCI device IDs in order to set the txq_inline_min value. No value is set= when > the PCI device ID matches the ConnectX-5 adapters, resulting in an assert= () > failure later in the function mlx5_set_txlimit_params(). >=20 > This error was encountered on an IBM Power 9 system running RHEL 7.6 w/o > Mellanox OFED installed. >=20 > Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: David Christensen Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 3a345c7..0f61dd5 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1341,6 +1341,7 @@ struct mlx5_dev_spawn_data { > * and PFC control may be broken, so disable feature. > */ > config->hw_vlan_insert =3D 0; > + config->txq_inline_min =3D MLX5_INLINE_HSIZE_NONE; > break; > default: > config->txq_inline_min =3D MLX5_INLINE_HSIZE_NONE; > -- > 1.8.3.1