From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B1C6A0577; Mon, 13 Apr 2020 12:48:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53F592986; Mon, 13 Apr 2020 12:48:13 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83]) by dpdk.org (Postfix) with ESMTP id 8C8C71B53; Mon, 13 Apr 2020 12:48:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIM9r1pIIYOPk/jUeklnRWzuxIz1B7J/VU4rAcU7EztIE2/5qz5cMNPialP5SGs+gkoJrQRFYW6lZJG+Tg9MW7D7hTGiL1hdfkKBu03XMeL5FsVP93Xa6G5hPAXh6QXktNCV6VOimOB/fmzFCXKI1UKygfYTgOaxqpU08EjTko8hJF+aZ5yM1XMpfdBMufr6T53Wacuwi0QUdRt1K1FNntYjAvIc2zeDp/eGwpkZ8LxA4tJN5gA+CiuQCH5ajFgUFw9ZcC4VP3v1Gly6KncWGViMrb53wDcnfxiKv/7PJ0wVaSbqWhntZWxAdn07jlZQrFg0FvmF3XhaNF3WJK++3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0fE+mx0650JkmJrwKmwrqi8loBATmmfD7mGN66mSjMg=; b=dtBr2bWihX7zj0+0lBoxMrvZdFqrIpeL2xynIWnBKW0ptvPBrf0YGIE3e2AC058wwXU+u01+FVU9Qlk0ayH7aGLBVnGU+4rU5bCyaPPcLdnnVdt9FN87f1Qr970EBX6XfLcJm/qcoItgx5X8GFunvcx1dvjxgwOI59tvbZaLLiA5jFgQXrvW/9hDSmZp9ysJ1YTEdsvIsQCJoEPJAUI/AAG6023fijU5N3bWiOSmKlY/9CGNyRpEyfDm/fc4hwHyimO+KHyOBk3+bXlyREuRssubQ8zsuT0vjl2QpOEb6wF+zbEv7QexjRL1KqDnZ08uBFBIvUoxaUkNim4GPubC6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0fE+mx0650JkmJrwKmwrqi8loBATmmfD7mGN66mSjMg=; b=dk9W4TECK64jOPR9BhZ0OfPM5Si5tIALrGABqRY0tDpUnUr6xD2WZoOgm85aDcRhAXnw+Fbdl+jOZpZiZe9kJH9ANHQiI3w4okhQpLi5qrVwSYB77Jpwaql6nD9jaVhdlPasVCiam9HDqZdupPOeVJZKKlhyMkeI+RYjKSLIPmY= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:8::26) by AM4PR05MB3377.eurprd05.prod.outlook.com (2603:10a6:205:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Mon, 13 Apr 2020 10:48:11 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4%7]) with mapi id 15.20.2900.028; Mon, 13 Apr 2020 10:48:11 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , Mohsin Shaikh , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat Thread-Index: AQHWDr0bFuRC1xK4lkqaPLe4JPuIi6h25E9w Date: Mon, 13 Apr 2020 10:48:11 +0000 Message-ID: References: <1586464626-12958-1-git-send-email-mohsinshaikh@niometrics.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 217477d5-15fd-43e1-a107-08d7df982956 x-ms-traffictypediagnostic: AM4PR05MB3377:|AM4PR05MB3377: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 037291602B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(316002)(53546011)(6506007)(64756008)(86362001)(110136005)(5660300002)(66556008)(76116006)(81156014)(52536014)(8936002)(71200400001)(66946007)(66476007)(55016002)(478600001)(33656002)(66446008)(9686003)(7696005)(4326008)(4744005)(186003)(26005)(2906002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: My10S1s4kgykAVHZqDc+esK5Pa8+1MxuBti7xYESPQ6P93Fm4AE3n77sosLVKffVcTbVX+7x5W936dRy55QkKxsgl9NP48jRKkzrQz8QWVwDrGrF5vBXiQmcHjpXjX0apme3sYC8Vq28DPd1f7DzMqhDwPyLiE6Ln7iEOKHIf9pxByJXGH8OM+QKRb2DCrYg8oiEbS4Nzl1JTaz58f/MHFG0B7K+ZxiMD37lIZe5deIjjil0SegClIhS3mSD5pt0jWHBUYaPJXcvT3CjI6gTG66ChoY2IruE8mmCXvuVJ5naLuclUXyfUaJOV01N3S903DCOlsHkeQaqKx+q0PIK7hr+Ucoj8A5WNHN3+vcI3aOGsl+iAAPaYZKY0mRU4VDryWrfufFQzzTwz5/syNjoExryK71eS+hbdKNMFEd+2sRuiGOFl7wkR4jz/3IFrRKd x-ms-exchange-antispam-messagedata: vEhyNMHmwtW4Okw/6THtGeGULEVnEca/C+X01esYPtKsCN+Xo5RrDQ7AuW5A7Rs898sraCobREKb/+oXHJxTLnoTzPUcVVHIWw8g57ju8BQg0KY0ptCfQTmu0Ra4R7R5EwkA85vc42JlMg73h22uQg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 217477d5-15fd-43e1-a107-08d7df982956 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2020 10:48:11.7081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OEGqVp5pO9Rftk7FUrhSYAjOP/dNsPo6U3Z1qFEZ1bk4D477eWC+RhTsZWDgWwAIcMGh4A4rNpLOChhUlUNRnb//6HVadQWwpTrgtyN/X7M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3377 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Alexander Kozyrev > Sent: Friday, April 10, 2020 1:21 > To: Mohsin Shaikh ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading= ib > stat >=20 > > -----Original Message----- > > From: Mohsin Shaikh > > Sent: Thursday, April 9, 2020 16:37 > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Alexander Kozyrev ; > Mohsin > > Shaikh > > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat > > > > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to > > TLB shootdown interrupts to all dpdk app cores including RX cores. > > This can cause packet drops. Use read(2)/write(2) instead. > > > > Bugzilla ID: 440 > > Cc: stable@dpdk.org > > > > Signed-off-by: Mohsin Shaikh > > --- >=20 > Reviewed-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko Thank you, Mohsin for the patch. Alexander, thank you for the review and test. With best regards, Slava