From: Slava Ovsiienko <viacheslavo@mellanox.com> To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine Date: Wed, 14 Nov 2018 12:57:30 +0000 Message-ID: <AM4PR05MB3265A6B3306271580C8AF013D2C30@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw) In-Reply-To: <DB7PR05MB4426FC604F2332271CBA8A37C3C20@DB7PR05MB4426.eurprd05.prod.outlook.com> > -----Original Message----- > From: Shahaf Shuler > Sent: Tuesday, November 13, 2018 15:22 > To: Slava Ovsiienko <viacheslavo@mellanox.com>; Yongseok Koh > <yskoh@mellanox.com> > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/4] net/mlx5: fix Netlink communication routine > > Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > > Subject: [PATCH 2/4] net/mlx5: fix Netlink communication routine > > > > While receiving the Netlink reply messages we should stop at DONE or > > ACK message. The existing implementation stops at DONE message or if > > no multiple message flag set ( NLM_F_MULTI). It prevents the single > > query requests from working, these requests send the single reply > > message without multi-message flag followed by ACK message. This patch > > fixes receiving part of Netlink communication routine. > > > > Fixes: 6e74990b3463 ("net/mlx5: update E-Switch VXLAN netlink > > routines") > > > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > > --- > > drivers/net/mlx5/mlx5_flow_tcf.c | 58 +++++++++++++++++++++++++----- > > ---------- > > 1 file changed, 37 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c > > b/drivers/net/mlx5/mlx5_flow_tcf.c > > index 5a38940..4d154b6 100644 > > --- a/drivers/net/mlx5/mlx5_flow_tcf.c > > +++ b/drivers/net/mlx5/mlx5_flow_tcf.c > > @@ -3732,44 +3732,60 @@ struct pedit_parser { { > > unsigned int portid = mnl_socket_get_portid(tcf->nl); > > uint32_t seq = tcf->seq++; > > - int err, ret; > > + int ret, err = 0; > > > > assert(tcf->nl); > > assert(tcf->buf); > > - if (!seq) > > + if (!seq) { > > /* seq 0 is reserved for kernel event-driven notifications. */ > > seq = tcf->seq++; > > + } > > nlh->nlmsg_seq = seq; > > nlh->nlmsg_flags |= NLM_F_ACK; > > ret = mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len); > > - err = (ret <= 0) ? errno : 0; > > + if (ret <= 0) { > > + /* Message send error occurres. */ > > + rte_errno = errno; > > + return -rte_errno; > > + } > > nlh = (struct nlmsghdr *)(tcf->buf); > > /* > > * The following loop postpones non-fatal errors until multipart > > * messages are complete. > > */ > > - if (ret > 0) > > - while (true) { > > - ret = mnl_socket_recvfrom(tcf->nl, tcf->buf, > > - tcf->buf_size); > > + while (true) { > > This while(true) is a bit disturbing (I know it exists also before). > > Can't we bound it to some limit, e.g. is there any multiply of tcf->buf_size > that if we receive more than that it is for sure an error? > We receive the reply messages in the loop - one for each iteration. Yes, it is expected the each message is smaller than tcf->buf_size, but the number of messages is not limited theoretically. We query the dump, dump can be sent by kernel in any number of reply messages, depending on size of dump, we can't make any assumptions regarding the number of reply messages, we should receive all of them until DONE or ACK message is encountered. WBR, Slava > > + ret = mnl_socket_recvfrom(tcf->nl, tcf->buf, tcf->buf_size); > > + if (ret < 0) { > > + err = errno; > > + /* > > + * In case of overflow Will receive till > > + * end of multipart message. We may lost part > > + * of reply messages but mark and return an error. > > + */ > > + if (err != ENOSPC || > > + !(nlh->nlmsg_flags & NLM_F_MULTI) || > > + nlh->nlmsg_type == NLMSG_DONE) > > + break; > > + } else { > > + ret = mnl_cb_run(nlh, ret, seq, portid, cb, arg); > > + if (!ret) { > > + /* > > + * libmnl returns 0 if DONE or > > + * success ACK message found. > > + */ > > + break; > > + } > > if (ret < 0) { > > + /* > > + * ACK message with error found > > + * or some error occurred. > > + */ > > err = errno; > > - if (err != ENOSPC) > > - break; > > - } > > - if (!err) { > > - ret = mnl_cb_run(nlh, ret, seq, portid, > > - cb, arg); > > - if (ret < 0) { > > - err = errno; > > - break; > > - } > > - } > > - /* Will receive till end of multipart message */ > > - if (!(nlh->nlmsg_flags & NLM_F_MULTI) || > > - nlh->nlmsg_type == NLMSG_DONE) > > break; > > + } > > + /* We should continue receiving. */ > > } > > + } > > if (!err) > > return 0; > > rte_errno = err; > > -- > > 1.8.3.1
next prev parent reply other threads:[~2018-11-14 12:57 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 6:30 [dpdk-dev] [PATCH 1/5] net/mlx5: add VXLAN encap/decap support for e-switch Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 2/5] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 3/5] net/mlx5: e-switch VXLAN flow validation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 4/5] net/mlx5: e-switch VXLAN flow translation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 5/5] net/mlx5: e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 0/7] net/mlx5: e-switch VXLAN encap/decap hardware offload Viacheslav Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions Viacheslav Ovsiienko 2018-10-23 10:01 ` Yongseok Koh 2018-10-25 12:50 ` Slava Ovsiienko 2018-10-25 23:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine Viacheslav Ovsiienko 2018-10-23 10:04 ` Yongseok Koh 2018-10-25 13:53 ` Slava Ovsiienko 2018-10-26 3:07 ` Yongseok Koh 2018-10-26 8:39 ` Slava Ovsiienko 2018-10-26 21:56 ` Yongseok Koh 2018-10-29 9:33 ` Slava Ovsiienko 2018-10-29 18:26 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine Viacheslav Ovsiienko 2018-10-23 10:06 ` Yongseok Koh 2018-10-25 14:37 ` Slava Ovsiienko 2018-10-26 4:22 ` Yongseok Koh 2018-10-26 9:06 ` Slava Ovsiienko 2018-10-26 22:10 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 4/7] net/mlx5: e-switch VXLAN netlink routines update Viacheslav Ovsiienko 2018-10-23 10:07 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management Viacheslav Ovsiienko 2018-10-25 0:28 ` Yongseok Koh 2018-10-25 20:21 ` Slava Ovsiienko 2018-10-26 6:25 ` Yongseok Koh 2018-10-26 9:35 ` Slava Ovsiienko 2018-10-26 22:42 ` Yongseok Koh 2018-10-29 11:53 ` Slava Ovsiienko 2018-10-29 18:42 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 6/7] net/mlx5: e-switch VXLAN encapsulation rules management Viacheslav Ovsiienko 2018-10-25 0:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines Viacheslav Ovsiienko 2018-10-25 0:36 ` Yongseok Koh 2018-10-25 20:32 ` Slava Ovsiienko 2018-10-26 6:30 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 01/13] net/mlx5: prepare makefile for adding e-switch VXLAN Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 02/13] net/mlx5: prepare meson.build " Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-01 20:35 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-01 20:36 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 05/13] net/mlx5: swap items/actions validations for e-switch rules Slava Ovsiienko 2018-11-01 20:37 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 06/13] net/mlx5: add e-switch VXLAN support to validation routine Slava Ovsiienko 2018-11-01 20:49 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-01 21:03 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-01 21:18 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 09/13] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-11-01 21:21 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 10/13] net/mlx5: fix e-switch Flow counter deletion Slava Ovsiienko 2018-11-01 22:00 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 11/13] net/mlx5: add e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-01 23:59 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 12/13] net/mlx5: add e-switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 13/13] net/mlx5: add e-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 20:32 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-12 20:01 ` [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-14 12:57 ` Slava Ovsiienko [this message] 2018-11-12 20:01 ` [dpdk-dev] [PATCH 3/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 4/4] net/mlx5: add E-switch rule hardware offload flag check Slava Ovsiienko 2018-11-13 13:21 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Shahaf Shuler 2018-11-14 14:56 ` Shahaf Shuler 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-04 6:48 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Shahaf Shuler 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-02 21:38 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-02 21:53 ` Yongseok Koh 2018-11-02 23:29 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM4PR05MB3265A6B3306271580C8AF013D2C30@AM4PR05MB3265.eurprd05.prod.outlook.com \ --to=viacheslavo@mellanox.com \ --cc=dev@dpdk.org \ --cc=shahafs@mellanox.com \ --cc=yskoh@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git