From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFA65A00E6 for ; Mon, 5 Aug 2019 13:01:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 938F01BDEB; Mon, 5 Aug 2019 13:01:20 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00057.outbound.protection.outlook.com [40.107.0.57]) by dpdk.org (Postfix) with ESMTP id 828111BD52 for ; Mon, 5 Aug 2019 13:01:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fqEd0BI5rsYoM78yBMVq2x2s0+HtDc8Ew7wt9DUF/adBcehSF3mOWkjsygc2uY0hgPQbHFvIU0vNDJb7MP4Qm0YcuBxP/Pn/Zs47Cs3OdmBVirntQ+G8L0OwgLkYoSMURLeh8BJqGnYK1dIqCFaqIt6v2mpMa9BSYGuvpXVuDPFBgTBaNoGnLz8HcX3WlYw/p3+Mf3C5SUDv8v6BgAHvR9C4zrVk7YznN/8BYV8eFyD6rAtm1WTXx6X0MoIx5HB+ubH/16qP3yObgl8kf9LGgaV9Nn/rzjg47m0t2JzzpExnASmJ2W3yo9zwpWJeK4IoofNCz8WS5/4ZlJ9oLjZ4QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYUtOLFaKP5RacdT78ibWQx2hYKTzW0xL1XXikUmf3Q=; b=KbqeRSVvC8vqQ+LGc6xW2iCLOvNzlOK3uTwsLfyZoJX3MyhnkV7Uadq5CIfETKgd0SFiaRQU3nVT6T8gNTNNYcnupL4aZytWKaeQjL28mJn0CKzHn3vJrcpE0sO3sd7KE5yb9+uWAc3SXoaIiP8AUYkmXjOg9lWwMCmi3pp5Rl8NElOQ1zJn5H1h2wohnof8b246rnTNGVXoFtfLA+ZtfwsAN2g0W7mymSEAsQngPm72uyxis4aXDk/5MmINfmGcXZZZXf19sL+eh9wiZI5bfX+T7W0z0UIiSMHgWXqJeNe8CTo3zf59oRpx4TLcW6uaffMNEzD70k+s1cQXaXZBvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYUtOLFaKP5RacdT78ibWQx2hYKTzW0xL1XXikUmf3Q=; b=oIXaGCf9Ym2mGMP2Eunw+u9J/KevMs19EEsuKuX3QdcfeQv+p+vLZ8YF/Y8eBTgrBI+Gsj0oAeJ4pQx9pRF5ZrX2VP+0K3vjVF0qNLHEz1VrJ9xonr3OMSOsJ+EYUZ7KtiJ/wO+UCsEAyGyfmnTM1SFcEtz62pCQakRkUjDxDyk= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3443.eurprd05.prod.outlook.com (10.170.125.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Mon, 5 Aug 2019 11:01:16 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a%4]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 11:01:16 +0000 From: Slava Ovsiienko To: Dekel Peled , Yongseok Koh , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix redundant use of directive Thread-Index: AQHVS1ywqp90w/ZcmEOK8/ThKY40j6bsY0lw Date: Mon, 5 Aug 2019 11:01:16 +0000 Message-ID: References: <1f303dbfa3900b1d435ff323a05ab166684da8b9.1564988649.git.dekelp@mellanox.com> In-Reply-To: <1f303dbfa3900b1d435ff323a05ab166684da8b9.1564988649.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [77.75.144.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9eb46de-cfb1-41f8-798f-08d719943cd5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM4PR05MB3443; x-ms-traffictypediagnostic: AM4PR05MB3443: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(199004)(189003)(13464003)(66066001)(6246003)(256004)(71200400001)(33656002)(53936002)(71190400001)(52536014)(6506007)(53546011)(5660300002)(76116006)(55016002)(99286004)(305945005)(7736002)(229853002)(68736007)(14454004)(76176011)(4326008)(7696005)(74316002)(25786009)(9686003)(6436002)(316002)(478600001)(2906002)(6116002)(3846002)(110136005)(8936002)(81166006)(81156014)(8676002)(486006)(86362001)(6636002)(476003)(11346002)(26005)(446003)(102836004)(66556008)(54906003)(186003)(66446008)(66476007)(64756008)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3443; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Y91awqx1s1MZWrC16lBjavHUIYhXh1B4ZejoiOmqYRnk4TtfVUDZIKqycvAuqvyb/BCjWlc+9yqnCxrrz/qEbBKmx+nR1mGxBepvzyIZcP780La/uib8KBM00pxmRCgHWfoAQJVPTw1vyg2UxSrjWqMdhj8rgqCYeJILUIzwMXIOAAew3NoI23OHJiiPIwzMMW6puhBTS1xtvD9idTG28ejSCZdbAMf3x1p4n9P9Qk7Oe5kKEl5yZa3ZDeOeCu5lRBpwzLDD0uDbwuMXAmjaiEh8HjrPwZyiLzcWoCSKrPmtzFe7i6TRHF1XyvrJMs1JoJ7shMm+PqBFgf9RsAJ42ikeDT4IY+4yA7tsd2MzLC5BTqvwJmZpZgaeiFIt0tM7qD3nKEh+nyxGzQRX7J/vZ+lQXFY9P5bkf8AYRgdBhCs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9eb46de-cfb1-41f8-798f-08d719943cd5 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 11:01:16.1502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3443 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Monday, August 5, 2019 10:07 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix redundant use of directive >=20 > Part of the code in function flow_dv_matcher_enable() is enclosed in '#if= def > HAVE_MLX5DV_DR' preprocessor directive. > Using this directive is not needed here, and prevents compilation of rele= vant > code. >=20 > This patch removes the redundant preprocessor directive. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 9c0a261..582f644 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4324,11 +4324,9 @@ struct field_modify_info modify_tcp[] =3D { > match_criteria_enable |=3D > (!HEADER_IS_ZERO(match_criteria, misc_parameters_2)) << > MLX5_MATCH_CRITERIA_ENABLE_MISC2_BIT; > -#ifdef HAVE_MLX5DV_DR > match_criteria_enable |=3D > (!HEADER_IS_ZERO(match_criteria, misc_parameters_3)) << > MLX5_MATCH_CRITERIA_ENABLE_MISC3_BIT; > -#endif > return match_criteria_enable; > } >=20 > -- > 1.8.3.1