From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6B77A2F6B for ; Tue, 8 Oct 2019 11:41:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 62FA71C10F; Tue, 8 Oct 2019 11:41:34 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by dpdk.org (Postfix) with ESMTP id 6ECA11C0B4 for ; Tue, 8 Oct 2019 11:41:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bk5BahaXFD3des2mOSkVN4xb7jnVkxzniE0q6xXuX6bIqFQsA/AKThnDlS1mGlz5Y/hFxrPglz6SwYip6+VGxv6rATZTkN0/SfOUmqJyewSvsEPhtQdllwYZB3A6ya6WWpfYakN2Q/vxYCTvNRRNRRqNirhN4FsLc0ErchHrH50PPPv5fzujl9WlYiYerrJVh4r7L28uAYvlrBt1Gz8Jvu07cX8Aeb4xXZIh15R2VLiCScZNtlj80rZvBAZxp2wgZmJbKvMdfumHSzqrxBlNI0+F9/UJyHMM9w5GwHawK1AAD2igtofHQzDSu60hK8CQeQ0y+zrnDCVeXnUUbfI0ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkCnam5Zj8tby0rWryluiPrGUxgL8hpq2BD5TFXP3I4=; b=KV/iPuHFKSHpBd79BNAd472zzxpWJnzJNnxEEDPI+eCZjobX7NJGBQA/5ozWS06+YBWVE6K3xSmtHBFuc4SIHrt1d5Cum+BNxYbC1tUif1FK81LxOmF8RByReQIlUH7ngOfl8smEge+22+4b6eC6DavXNVh/fC3clWUZDHfTRNYbXZINBxXz6g+YAKM0/c9jWaZcT3khk3hQ3Go5V93Drr88maQOQdBwurRmzYJjDeJ13KhkZmX+WOodcfdnZG84dZu4QgYJKxi5pIbCxSPGZcExCDuBULgWcXK/Mr0Mt0O2dsHos31U8+xhZUXdZA/oCXytx2LwPNmeDMVJ8/FjXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkCnam5Zj8tby0rWryluiPrGUxgL8hpq2BD5TFXP3I4=; b=QqRyok0/o7QCanfwS0CJ/ogZNusisGAvDM25/eSTUayutx95pLvWPNkd5pOFyrO34HbpXONLfMuKynAAEF/gqA8Ob+WUCFM3MO+ZHdfDhOJNAmxQDMVZRgi03F5atZIXI57oviyyrJhlh22XgtFTZKkNN51ftkheUL4SsG1rb4Q= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3204.eurprd05.prod.outlook.com (10.171.186.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 09:41:31 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2327.023; Tue, 8 Oct 2019 09:41:31 +0000 From: Slava Ovsiienko To: Ori Kam , Matan Azrad CC: "dev@dpdk.org" , Ori Kam , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute Thread-Index: AQHVdFRUdR3p/KUUxEKCUsOcy3u4MKdQkFbw Date: Tue, 8 Oct 2019 09:41:31 +0000 Message-ID: References: <1569493335-44790-1-git-send-email-orika@mellanox.com> In-Reply-To: <1569493335-44790-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76bbb0bd-06fe-470f-dd5c-08d74bd3b327 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: AM4PR05MB3204:|AM4PR05MB3204: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(13464003)(199004)(189003)(53546011)(66446008)(76176011)(6506007)(76116006)(6436002)(229853002)(25786009)(99286004)(64756008)(33656002)(66476007)(66946007)(7696005)(9686003)(66066001)(26005)(186003)(66556008)(316002)(6636002)(107886003)(6246003)(55016002)(14454004)(54906003)(110136005)(478600001)(74316002)(2906002)(52536014)(102836004)(305945005)(486006)(4326008)(5660300002)(7736002)(446003)(11346002)(8936002)(81156014)(81166006)(3846002)(86362001)(8676002)(71190400001)(71200400001)(6116002)(476003)(256004)(14444005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3204; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GJEY7BUbTxtThPjaY73SuTCkvQGfeMq+T4tjGMu1bhR/v2M812Vi9EiFlyB+i2RlD24ed6sTjwmX4r+gjoKQsjnnWzuysUEdF9TmZX2Gri/g80XXlCHor7QnLxFQemDsE9vGBkddY/mx4b/H+XF3TgoDBEY9zaIhTLgjaT5Zd4zX5U4gvCjVGNykSKgrG51UoG12LmvKhxGarTGua7H2luNfVhzgBC9djj4AN4eF9r3VjHETX3y6sxiWIpUksX2odmCcwXP4zQKHx3Mp6ERV4pfPjxWwYUEhlsQzM19mxl5xXb8jHjIkm/8uyGZSWaU8+Qsr0h/0/PxGvpsY4vNnjknqzOlAiXwtbfyad64tcl2VDvPJDJAmdi0p2JNgEuPf1xNLkOLzavrsMN2I3vtwrfDFaS9JnYeC0jlhsLdTLK4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76bbb0bd-06fe-470f-dd5c-08d74bd3b327 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 09:41:31.0892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vWZPJgBSlJK5YZva0BLnJn5qNwN4fU7Tgxx2fixav+4hcHcWOC2FSEnxH6HsW15TPIbN+b7AnIOG+XE2Ij+kdcfd8wfSZeTVxhXWEAE1d7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3204 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Ori Kam > Sent: Thursday, September 26, 2019 13:22 > To: Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute >=20 > The receive queues list size is based on the size of uint32_t, so when > allocating the memory, the correct value should be used. Or else there is= risk > to corrupt the memory, depending on the queues number, because there is > some pad area for alignment. If the queue number is not large enough, the > issue couldn't be observed. >=20 > Based on Bing fix. >=20 > Fixes: dc9ceff73c99 ("net/mlx5: create advanced RxQ via DevX") > Cc: dekelp@mellanox.com >=20 > Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c in= dex > a1fdeef..0db065a 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1936,7 +1936,7 @@ struct mlx5_rxq_ctrl * > struct mlx5_devx_rqt_attr *rqt_attr =3D NULL; >=20 > rqt_attr =3D rte_calloc(__func__, 1, sizeof(*rqt_attr) + > - queues_n * sizeof(uint16_t), 0); > + queues_n * sizeof(uint32_t), 0); > if (!rqt_attr) { > DRV_LOG(ERR, "port %u cannot allocate RQT > resources", > dev->data->port_id); > -- > 1.8.3.1