From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6AA1A00BE; Tue, 29 Oct 2019 18:53:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BF521BF7F; Tue, 29 Oct 2019 18:53:26 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by dpdk.org (Postfix) with ESMTP id E45001BF7A for <dev@dpdk.org>; Tue, 29 Oct 2019 18:53:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSJaF4BYIVFWRNG7i5wNsqkLjPKKPPFTXvAIhgDmToZxHFbmQJa79WxMWr55DpV12Q4Cx1vwCSfYUr+sQSUANJP22LcAXVj4mhliS0dHf9LDnDEgOkSoRF61B6k6NNloQSuTVbiNmMtsUhU8UaVbUBDRURxGbkAKKCDPcCL5VNq9Mus/vi8wSi7MkkgK0xDx/3GLsbCuQ7peYlukNzfHJYShL+00LRIqqG2ZEeRVfcGHuwBXRaLYQzpxVnp09DZjDqTgcdbzR5p0DcUSdZfcYuSNDBOl9aEn2xuhkot9fkPyg2NWnZ+NH0LSi98DeAiIJI+A50wFeqSGPQkM0hS34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHh+cC/fXXrEFFgdO8qROdDhGj9A6Ssy7h5oZo3qV3g=; b=U96WZFelb/XNt3yn3c7++7NeKsGgWVTJii0wzfT61JVXzxTbFHqF6B4EdI7s977aTm56krDcfgxsKXhCkr1kyKx0V64W8h4etEqv+F8lG9283hh2LHvlG/oDNB05xWVV7viLaymeuPYazBT77VwjNUdL7zwU9qyTcWXgEOJagV9+DAD5td7K5SsSI96TSeteMyRnx6I8Uu4hb1LmNLaRBu/6kmNumdhyIAoGZnc92XIe1KZG7ici8KdiQoVNcR7p3pfTqDHxwgaDK3cEioAsXZ8dMRY9iBxZpp8WG+80BowQeLiOiW6/2pLlMZbvHKE4Tv/++uuVENh5EEW7/EVXsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHh+cC/fXXrEFFgdO8qROdDhGj9A6Ssy7h5oZo3qV3g=; b=VhXOnVlCtw5fI4D0iflFPz9/hF0/V7H7JGlKGPn1dOV5juvvtAoq41TfdXkNhgdcQFwCgNRV0hfoTMD9gOTBa7K7barAFSLVnP8tslIKjLrS1Gry4Hzf+9a2cXWnCJV0Itj6VNSI0OuKlpp+ad8A7ewDBv3Dso1HCw3nTCu/oUk= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3331.eurprd05.prod.outlook.com (10.171.190.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Tue, 29 Oct 2019 17:53:23 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.027; Tue, 29 Oct 2019 17:53:23 +0000 From: Slava Ovsiienko <viacheslavo@mellanox.com> To: Olivier Matz <olivier.matz@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>, Yongseok Koh <yskoh@mellanox.com> Thread-Topic: [PATCH v4] ethdev: extend flow metadata Thread-Index: AQHVjnV4dBh/aEw9UUCRkYoPsCf2Zqdx0FcAgAAVf9A= Date: Tue, 29 Oct 2019 17:53:23 +0000 Message-ID: <AM4PR05MB3265B0D6A2D3A4C6D967EC91D2610@AM4PR05MB3265.eurprd05.prod.outlook.com> References: <1571922495-4588-1-git-send-email-viacheslavo@mellanox.com> <1572201636-16374-1-git-send-email-viacheslavo@mellanox.com> <20191029162522.ozj724j7pz7hz753@platinum> <20191029163344.5mlwhjx6rban6xka@platinum> In-Reply-To: <20191029163344.5mlwhjx6rban6xka@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9ff33826-5d11-4b3c-0af1-08d75c98e4a0 x-ms-traffictypediagnostic: AM4PR05MB3331:|AM4PR05MB3331: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <AM4PR05MB33315DC2E6D55210712A781FD2610@AM4PR05MB3331.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0205EDCD76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(13464003)(189003)(199004)(9686003)(66066001)(316002)(4744005)(25786009)(486006)(107886003)(54906003)(55016002)(14454004)(6246003)(4326008)(6436002)(71200400001)(8936002)(478600001)(81166006)(81156014)(8676002)(11346002)(66556008)(66476007)(2906002)(71190400001)(33656002)(476003)(66946007)(66446008)(229853002)(76116006)(64756008)(7736002)(7696005)(446003)(52536014)(74316002)(6506007)(53546011)(102836004)(76176011)(305945005)(6916009)(186003)(26005)(5660300002)(256004)(86362001)(99286004)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3331; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9Qlk76NgognBOFgF8ofOW2goTvfFlBYTyEDN1qp4xMQBTWDv61jycEaX0QsbmIyKMDWWMRQ3tjzZAK9+eetllcC492RSZcs/N4QAh5G1wPbq+8Gp8DRML0LphcOEN6bOpBl34uuZ4GYn5ne4KAlKl0EHnWKnsL3SV8m/N9Tw0J5S6J9qrxCQr6TpVcIpobpyq6izj/QhWMc6Mhsispp9raF5awyTEcWX9Ib4BtlV/+x1n9s5ss4MzXMixXEpDwOiZ0T4I57WV79IPis/DQhp3EC8OX54N0myinhP0FetZrTMB5Oooq9l/PXpRETCTreRQ0Or4CdHVHdEQlRIDIvS2Y+G/GPsEWnS7CMgHWHQB9H3WUkcpgBr6Y5fWVtnJ7cWWvyHtjl0pu166SF0/8zHrrmbxVTIn7Ahk87KzEwgVPaLXNqsGWQOiBKGtlsprdpw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff33826-5d11-4b3c-0af1-08d75c98e4a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 17:53:23.5623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xj9fJZj2fTpm2G8FHt8eQ1CYOSp87vBoOUHQpUs6A16RJV21+D5pavtqvuE+L7La6eqlnTXUsHJqVyj6cF5W7soAffQjHZD3E6sei3uu9w8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3331 Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Olivier Matz <olivier.matz@6wind.com> > Sent: Tuesday, October 29, 2019 18:34 > To: Slava Ovsiienko <viacheslavo@mellanox.com> > Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Matan > Azrad <matan@mellanox.com>; Ori Kam <orika@mellanox.com>; Yongseok > Koh <yskoh@mellanox.com> > Subject: Re: [PATCH v4] ethdev: extend flow metadata >=20 > On Tue, Oct 29, 2019 at 05:25:22PM +0100, Olivier Matz wrote: > > Hi Slava, > > > > Looks good to me overall. Few minor comments below. [snip] >=20 > I forgot: can you please document the goal/usage of these field and flag > here? Not necessarily a detailed explanation, but a high level view: > what is transported, when it is registered, ... >=20 Even the brief explanation is wordy, because it involves some=20 metadata features history, I will think how I could elaborate the=20 description. With best regards, Slava