From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13AD0A00E6 for ; Wed, 10 Jul 2019 16:19:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 440A1532C; Wed, 10 Jul 2019 16:19:42 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130043.outbound.protection.outlook.com [40.107.13.43]) by dpdk.org (Postfix) with ESMTP id 00A352B99 for ; Wed, 10 Jul 2019 16:19:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QPW6igS3naVwDPbUGOIP4WKEiDza78Y5NpgdFXm1hg=; b=YogJ2nKqxm6rIn8zJKNWWIXnX1W+iJr+XVtgPf5t5wkZUq01zL+9HLCKZFIs8jmjjFXVTeaJHWdsF2RXFuA/1B/yYQIAV0HJjgTadHFOxI8CxggTA6SawyWrZRcDaQaKekwiUiOKnLrD2KWgtMo0t/z3JKo3mUhdorZKzTXlTy8= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3410.eurprd05.prod.outlook.com (10.171.187.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Wed, 10 Jul 2019 14:19:38 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 14:19:38 +0000 From: Slava Ovsiienko To: Jack Min , Raslan Darawsheh , Shahaf Shuler , Yongseok Koh , John McNamara , Marko Kovacevic CC: "dev@dpdk.org" Thread-Topic: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel Thread-Index: AQHVNwhh7PjaCfzN9EqFoqtkgJIWsqbD5TAg Date: Wed, 10 Jul 2019 14:19:38 +0000 Message-ID: References: <20190528020426.18638-1-jackmin@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9cebe0a-5765-4d60-3a82-08d70541a47a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3410; x-ms-traffictypediagnostic: AM4PR05MB3410: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(189003)(199004)(13464003)(25786009)(86362001)(102836004)(26005)(53546011)(446003)(186003)(74316002)(7736002)(486006)(305945005)(476003)(11346002)(6506007)(8936002)(81166006)(81156014)(7696005)(6116002)(4326008)(3846002)(14454004)(8676002)(99286004)(478600001)(33656002)(256004)(66446008)(76116006)(5660300002)(66556008)(66476007)(64756008)(52536014)(66066001)(6436002)(9686003)(55016002)(53936002)(66946007)(6246003)(229853002)(71200400001)(76176011)(2906002)(68736007)(110136005)(71190400001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3410; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: iWRypl3nCIgq2Ea98LeTqVyNOzKh+sbgGszbmmhGCR9yITSHwQN5qfRXbUXzxn6xSh2QDVA1tlefPrAPDWADSiQPoz5qZprKc1OycyX6rxIKovLt8aQ1H3hhQcggS/C/sMeRPS/jBMeW3wK5we9Jhm2uY2tacABwbmMYscQ9qmuOHlJm7jbVrqZQUPYlJmxiPP/hJor4hi9OWl20mTBMt5D6BNyZUjxMzXFwjjBLA/4QGtvBlXj/xO4m+g3h1WtT4kXTIRrW8oY3q4idn+OXMWXfDkK6TwjfjrGVV0YBmgYyGvSWLwyLDa7T5wjmJv7rlUnAglqJ+HrkZfaF1OMIIIWISolBNHGfOwxJs+QSdTT5KFWVBp1gNKhaDbEJtv6CXGScvTpwGMigUT/1qjxhDJz158NTtrWiJldiLBrec5U= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9cebe0a-5765-4d60-3a82-08d70541a47a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 14:19:38.5242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3410 Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaoyu There is a couple of small points to note: 1) It would be good to have the testpmd flow create command sample with new= tunnels in commit log. 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ? It looks like a bug, should the second parameter be "&item_flags" ? (if= so - please, fix all calls of mlx5_flow_tunnel_ip_check())=20 WBR, Slava > -----Original Message----- > From: Xiaoyu Min > Sent: Wednesday, July 10, 2019 13:15 > To: Raslan Darawsheh ; Slava Ovsiienko > ; Shahaf Shuler ; > Yongseok Koh ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel >=20 > Enabled IP-in-IP tunnel type support on DV/DR flow engine. > This includes the following combination: > - IPv4 over IPv4 > - IPv4 over IPv6 > - IPv6 over IPv4 > - IPv6 over IPv6 >=20 > MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure fw > using FLEX Paser profile 0. >=20 > mlxconfig -d -y set FLEX_PARSER_PROFILE_ENABLE=3D0 >=20 > Signed-off-by: Xiaoyu Min > --- > v2: > * updated release note > v3: > * rebased on 19.08-rc1 > --- > doc/guides/nics/mlx5.rst | 15 ++++++++++- > doc/guides/rel_notes/release_19_08.rst | 1 + > drivers/net/mlx5/mlx5_flow.c | 35 ++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_flow.h | 6 ++++- > drivers/net/mlx5/mlx5_flow_dv.c | 37 ++++++++++++++++++++++++++ > 5 files changed, 92 insertions(+), 2 deletions(-) >=20