Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX

[Slava Ovsiienko <viacheslavo@mellanox.com>]

> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Friday, February 21, 2020 9:38
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; ferruh.yigit@intel.com
> Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
> 
> 
> 
> From: Viacheslav Ovsiienko
> > This patch does extra inline packet size check to tune the
> > ConnectX-4LX performance in the legacy Multi-Packet Write mode.
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> Slava, Don't you think we want it for stable releases?
Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML.

> 
> Besides it:
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> >  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rxtx.c
> > b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx.c
> > +++ b/drivers/net/mlx5/mlx5_rxtx.c
> > @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
> >  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
> >  				goto pointer_empw;
> >  			if (MLX5_TXOFF_CONFIG(MPW)) {
> > +				if (dlen > txq->inlen_send)
> > +					goto pointer_empw;
> >  				tlen = dlen;
> >  				if (part == room) {
> >  					/* Open new inline MPW session. */
> > --
> > 1.8.3.1