Re: [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5

[Slava Ovsiienko <viacheslavo@mellanox.com>]

Hi, Patrick.

Not all rdma-core versions provide the 
- mlx5dv_get_clock_info(context, clock_info);
- mlx5dv_ts_to_ns(clock_info, device_timestamp);

With these versions we would get compilation/linkage error.
There should be conditional compilation like it is done with other mlx5dv routines.

With best regards, Slava

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Patrick Keroulas
> Sent: Tuesday, June 9, 2020 17:17
> To: dev@dpdk.org
> Cc: Patrick Keroulas <patrick.keroulas@radio-canada.ca>
> Subject: [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5
> 
> The intention is to produce a pcap with nanosecond precision when
> timestamp offloading is activated on mlx5 NIC.
> 
> The packets forwarded by testpmd hold the raw counter but a pcap requires
> a time unit. Assuming that the NIC clock is already synced with external
> master clock, this patchset simply integrates the nanosecond converter that
> is already implemented by ibverbs. The conversion is performed is pdump rx
> callback.
> 
> Patrick Keroulas (3):
>   net/mlx5: add timestamp-to-ns converter from libibverbs
>   ethdev: add API to convert raw timestamps to nsec
>   net/pcap: dump hardware timestamps
> 
>  drivers/common/mlx5/mlx5_glue.c          | 16 ++++++++++++
>  drivers/common/mlx5/mlx5_glue.h          |  4 +++
>  drivers/net/mlx5/mlx5.c                  |  1 +
>  drivers/net/mlx5/mlx5.h                  |  1 +
>  drivers/net/mlx5/mlx5_ethdev.c           | 30 ++++++++++++++++++++++
>  drivers/net/pcap/rte_eth_pcap.c          | 32 ++++++++++++++++--------
>  lib/librte_ethdev/rte_ethdev.c           | 12 +++++++++
>  lib/librte_ethdev/rte_ethdev.h           | 17 +++++++++++++
>  lib/librte_ethdev/rte_ethdev_core.h      |  5 ++++
>  lib/librte_ethdev/rte_ethdev_version.map |  2 ++
>  lib/librte_mbuf/rte_mbuf_core.h          |  3 ++-
>  lib/librte_pdump/rte_pdump.c             | 15 ++++++++++-
>  12 files changed, 126 insertions(+), 12 deletions(-)
> 
> --
> 2.17.1