From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BF5EA034F; Sat, 2 Nov 2019 09:38:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 521511E56F; Sat, 2 Nov 2019 09:38:42 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by dpdk.org (Postfix) with ESMTP id 6D6781E568 for ; Sat, 2 Nov 2019 09:38:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfTMAB0fJmEfE7PR3DH5IQaBArtSAi08DSSibiMaA3sA3Qj3pEzVg0Yvq4RI+cNisxNOOT43ZutbViphhprgs5WkPBxCnppfqyMlhn0wkciHC5Oc02/W5jUVExXRryKOrN/rxheJ7x48/yBCKjYYJIOQVxKah6AUphjyqyvC7LHE6uTl8CLMq239qg2MzIryljucnXVo98dj39tXtevv3bM7NyMLslyebCSW2sk942Nl/78kytqgO5p12nQPjHLZ9xjA3zg2nwKiOv1/dowFJQ26mjR+H+mnh4U9Oz1HVYLxXXeEtNS/r8OxwV74hFCFCPpTm7tCBXqq6xzYEVjCyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1WavbyNY47OX8hGTVXyVxGecp5AlKSa1ue4mtbl0d8=; b=OQKfQmcPXZq1CdjH0dkdqL0IsozaF8RDJCDrFUBgeKR0RWXdSacQyWGMhc1l/E7FU1IoPOJyrMhzw41jWfQB5sc+YR5ed1Z9Hfjx1XetN2k6fdQdL4HUiGpko17k93EPufELYWyLtnEkQBoDViJrb9QHHRX+eI6tynoLhkgerIHN3t5GjXfoyYXFFWyjQ7/TEgmvrXsrwWCVmiDIgssVqPQUOIskrSRxt+zrAp885yt6yBL3hLumI/q0QS14y0Bs89adnYNy21MqI/rSX/pwvW/qSU3/UmXgxhsJNxIpLsUW969jLKet9/I0RswEL24OycG+1gDEBi5kPAJH79YDOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1WavbyNY47OX8hGTVXyVxGecp5AlKSa1ue4mtbl0d8=; b=gsTlwYLcSy2+7kGfZ8cCsHmBLKL+qavY1OuJA65UMAC7mRWUL7JyU8uB7a8eWwiZn/TGQGL+qOwATfgsM9/I7/GVZks9FtlQOwiMl2uGgxUHSIG6XtG2slerzVwXzd4f67EV0x5++QX29cAF4ntr4g0vkeh7G0CUyydpQ8Ch958= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3442.eurprd05.prod.outlook.com (10.170.126.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Sat, 2 Nov 2019 08:38:40 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c%4]) with mapi id 15.20.2408.024; Sat, 2 Nov 2019 08:38:40 +0000 From: Slava Ovsiienko To: "Liu, Yu Y" , "Wang, Haiyue" , Thomas Monjalon CC: "dev@dpdk.org" , "arybchenko@solarflare.com" , "Yigit, Ferruh" , "jerinjacobk@gmail.com" , "Ye, Xiaolong" , "Kinsella, Ray" , "Sun, Chenmin" , "Damjan Marion (damarion)" Thread-Topic: [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information Thread-Index: AQHVkQY1BkrzvtNkw0WO7M2IFajIc6d3WxAAgAAYC4CAABc7cA== Date: Sat, 2 Nov 2019 08:38:39 +0000 Message-ID: References: <20191031171139.105110-1-haiyue.wang@intel.com> <20191031171139.105110-3-haiyue.wang@intel.com> <20693558.VL3dRorq05@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5341df36-b7f0-4d4e-2547-08d75f700fbf x-ms-traffictypediagnostic: AM4PR05MB3442: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0209425D0A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39850400004)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(13464003)(186003)(446003)(256004)(14444005)(8936002)(81166006)(99286004)(45080400002)(478600001)(229853002)(6436002)(71190400001)(81156014)(6246003)(9686003)(6116002)(486006)(25786009)(3846002)(71200400001)(476003)(2906002)(55016002)(4326008)(76116006)(66476007)(66446008)(66946007)(66556008)(74316002)(33656002)(11346002)(110136005)(7416002)(305945005)(54906003)(86362001)(5660300002)(14454004)(53546011)(64756008)(8676002)(26005)(102836004)(76176011)(52536014)(6506007)(7696005)(316002)(7736002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3442; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W1J6QJOfpt00piz2DPdfDiI5ckC+PshWamjBI+pL77UfUNYHT24/AnIutkYqiakfsQR3oVdmaxg0ZJavw0w37YzUHqeE+UyRwcm+SwuKY2oZDH4mow6AVhunVW+0DuXvZVtOWA2CkLSveP3YAKuof4GXYi6zmXdrzQDsvY6qcUqYNHc3+qogy+c0Fa+Q5R2GD5ChnlX+hfY7VO2BfYi2BE7GVqf4bqCRHA3wV48AxJSgJDIFLWBOJQqDEkFbOW0fMI6+PD02pY75md0l5ZBleUUwCb+RlksNjUdfnWgTE+jp/DqYw6jQqBpt0Xnqsx+bkEGJ48az3d/CqIOKzQoI1dkFUFVcfXl1+eb/DBtMFogXr0f288NvzNu4cV6F8rROdrGArloEVoO4lCaCglMtytZh2V67upy2Pqf/Uy0v3PqoaEmDfMeDUBBmoX2MsKTH x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5341df36-b7f0-4d4e-2547-08d75f700fbf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2019 08:38:39.9416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VVVouEbr/1UOwSYRogh3XjAuHi40EMtwBVMQ8/oVb4VL3sAyKFWfFA804v/csPbevonJZ+FydnVSg4aIzwiD2/4vFRhsoXiDGrHR7qfNbj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3442 Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Liu, Yu Y > Sent: Saturday, November 2, 2019 8:56 > To: Wang, Haiyue ; Thomas Monjalon > > Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > ; jerinjacobk@gmail.com; Ye, Xiaolong > ; Kinsella, Ray ; Sun, > Chenmin ; Slava Ovsiienko > ; Damjan Marion (damarion) > ; Liu, Yu Y > Subject: RE: [PATCH v1 3/3] ethdev: enhance the API for getting burst mod= e > information >=20 > Add Damjan from FD.io for awareness... >=20 > Hi Thomas, >=20 > Long time no see. Sorry I use outlook which is not friendly to community > email. >=20 > >Anyway I will propose to replace this API in the next release. > Will your plan be affected by API/ABI stable plan? > BTW, if you propose new change in next release, it will make DPDK > consumer(FD.io) to change again. > So even if it is not affected to the API/ABI stable plan, do we still hav= e time > to get a solution for everyone in DPDK 19.11 with your > contribution/acceleration? >=20 > > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > Please be rest assured it is not the case. > This request is just from one FD.io project internal bug " tx/rx burst fu= nction > is shown as nil" reported by Chenmin. Why just the presenting string with function name (possible with suffix) is= not enough? I would like to see this API (strings approach) in mlx5 either, dropping t= he entire feature does not look nice, as for me. We could consider some requirements for the name suffices to distinguish wh= ether function uses vector instructions and which ones if any. > My understanding is DPDK behavior was taken as bug for someone in FD.io > project and potentially will mislead other DPDK consumer. Why does FD.io code want to know which vector extension is used by burst ro= utines? Is it going to share/preserve some resources (registers, etc.)? Is it robus= t ? Burst routines might not know whether vector extensions is used (they might= call=20 libraries, even rte_memcpy() can use vectors in implicit fashion). With best regards, Slava > Haiyue is working with Chenmin to address the issue and with your support= it > will be even better. >=20 > Your support will be highly appreciated! >=20 > Thanks & Regards, > Yu Liu >=20 > -----Original Message----- > From: dev On Behalf Of Wang, Haiyue > Sent: Saturday, November 2, 2019 1:30 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > ; jerinjacobk@gmail.com; Ye, Xiaolong > ; Kinsella, Ray ; Sun, > Chenmin ; Slava Ovsiienko > > Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for gettin= g > burst mode information >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Saturday, November 2, 2019 06:46 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > > ; jerinjacobk@gmail.com; Ye, Xiaolong > > ; Kinsella, Ray ; Sun, > > Chenmin ; Slava Ovsiienko > > > > Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting burst > > mode information > > > > Thank you for trying to address comments done late. > > > > 31/10/2019 18:11, Haiyue Wang: > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h >=20 >=20 > > > +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) > > > +#define RTE_ETH_BURST_NEON (1ULL << 3) > > > +#define RTE_ETH_BURST_SSE (1ULL << 4) > > > +#define RTE_ETH_BURST_AVX2 (1ULL << 5) > > > +#define RTE_ETH_BURST_AVX512 (1ULL << 6) > > > > Of course, I still believe that giving a special treatment to vector > > instructions is wrong. > > You did not justify why it needs to be defined in bits instead of > > string. I am not asking again because anyway you don't really reply. I > > think you are executing an order you received and I don't want to > > blame you more. > > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > > No need to reply to this comment. > > Anyway I will propose to replace this API in the next release. >=20 > Never mind, if this design is truly ugly, drop it all now. I also prefer = to do the > best, that's why open source is amazing, thanks! ;-)