From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85498A052E; Tue, 21 Jan 2020 08:04:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8B872C6D; Tue, 21 Jan 2020 08:04:04 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60040.outbound.protection.outlook.com [40.107.6.40]) by dpdk.org (Postfix) with ESMTP id B4FEF235 for ; Tue, 21 Jan 2020 08:04:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkfD8fWuM4vt75yrUsjVLm4mSsk9wlZZ/FbawPwlUYOWxE2OeyFktp/ZYVI3SDyRuT9wMr8/dW5kGxN3W+qa5d51F6i9d3WaXtXmiecPjNjpV34qWgRnBV0xN9Y4I4LtHpwCivLjL2bXF+Tw17+tU/tGBseGOTjwCnpkcdHWKzvTuXFZZ2vcHNqweDUrN73y3t5/3BetOJ7Qwq7klbEi8PTGgbcny2wHsNRi1VYC2dYTtLhiuH3P1A/7Wu39GL68eUmw8tN4CO3BF0nAF/So3jznKn81h9mSdmD4fM//B5hj6S7NWcErqZdluykMi17HgEzn5xtf2GFfgJS9cq/k7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PNliZQhLL6/2sqPgXYuvhzqXMbTLDpzUh9GAaFz05wk=; b=VeSEvRzTsfmwnGw14DnA2s4K9hv001icOAPX90mtmmqW03YX4Ytp/1YiixdhAhgmA0SobqMmz4SEzoN4e1f+IZ6glvZYmB++rsHC+86LD97rqYAvvr3qDQspWzv940umDlMifH2GeekDc7O10gYQxoPjsyM0299t/5CCkaF1KVtSbjIubRMC6IAAgnmNPFCd1KkewWu20Q0Epk8tkPkOU+r5rMrnkwqzEp53Rv5iKHX0N5WJPF+ha3KgfMT7rdda0tA1KqM7mA56gw16tEauPRcIoBFJ8SUbwoS5dZAslFlS91id+crNTapBYwZd7qFltVxEpl09ioMeRdnDrxcxzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PNliZQhLL6/2sqPgXYuvhzqXMbTLDpzUh9GAaFz05wk=; b=nwxg5wO7bQvWATqK4LjyQc0YEcxJm4YDTpBkNWT1hHIMycXLBqTAs4jGiQYtMrOYboEzEqCvv/sosMhO2BnUekbrLDHfD5v0RU94dQrUTtVPahTbsIda4lfQf99N3jiGGtSQ5AC36b43i4sI26l07n7k44Cv9ZaF7HKhfNalx18= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3185.eurprd05.prod.outlook.com (10.171.188.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.19; Tue, 21 Jan 2020 07:04:01 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.024; Tue, 21 Jan 2020 07:04:01 +0000 From: Slava Ovsiienko To: Stephen Hemminger CC: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , Ori Kam , Shahaf Shuler , "olivier.matz@6wind.com" , "thomas@mellanox.net" Thread-Topic: [PATCH v6 3/5] mbuf: create packet pool with external memory buffers Thread-Index: AQHVz9LwGjkbZVzFQ0+s4xJaVuoTGaf0sEbg Date: Tue, 21 Jan 2020 07:04:01 +0000 Message-ID: References: <20191118094938.192850-1-shahafs@mellanox.com> <1579547786-7650-1-git-send-email-viacheslavo@mellanox.com> <1579547786-7650-4-git-send-email-viacheslavo@mellanox.com> <20200120124804.7a56c4e3@hermes.lan> In-Reply-To: <20200120124804.7a56c4e3@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [77.75.144.194] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a431c609-3176-4afa-9854-08d79e40182c x-ms-traffictypediagnostic: AM4PR05MB3185:|AM4PR05MB3185: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(189003)(199004)(53546011)(6506007)(52536014)(186003)(26005)(498600001)(55016002)(4326008)(7696005)(2906002)(8936002)(9686003)(6916009)(81166006)(86362001)(5660300002)(81156014)(8676002)(54906003)(71200400001)(66946007)(66556008)(64756008)(66476007)(76116006)(66446008)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3185; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A9Kez6KKuwG7xdOtSYqlD+m31EwOjE9OXQlXCZ7AYoa2f2ENtP+moVFsNbhwEUQl0SMxghoh8kfnMkFg2Au1f9Ma0IIYESfZ4Rm7wZvft2LoS9x5jMm65yLsJNXKRvIOgAP1LX+WBL79TS8RKA1lCfKP9LSeiG7U8boY10H8qbBzGHynsz1MoYztsVTnO1ChyiU4ohf9itHoxnrta0QP2hk34JJs03Pnudh3ogs1uGVE3k+iNg8naH24a5/+T6JBuaacqDRr3Tv9BAWaXHdDwUE/+voRdp7wYvEy5WmBFh7Pam63uW9rThOPLrqWFC50APAAx5KLieaK4VArKrdr54DE3t5WA7oZdrhLnZtRuaBnraBmUxvKjrqHZHtUMXW5TGaXYED8W5paOql8BNyO/PYC3tF5jYd1Ts094r10IHWRVPYm+buiT+aINzDSzu28 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a431c609-3176-4afa-9854-08d79e40182c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 07:04:01.5576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EoKNgwbYEy4Dml+ljG010EAFEW0HIbFrpH8WtoYXwTZPYm3dGv7Yfnp7ilguK3DsnxQ/wgYMe9eLeLYAmGgewYVHyBs9HVbrQhGgXIZqDzw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3185 Subject: Re: [dpdk-dev] [PATCH v6 3/5] mbuf: create packet pool with external memory buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Monday, January 20, 2020 22:48 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; olivier.matz@6wind.com; thomas@mellanox.net > Subject: Re: [PATCH v6 3/5] mbuf: create packet pool with external memory > buffers >=20 > On Mon, 20 Jan 2020 19:16:24 +0000 > Viacheslav Ovsiienko wrote: >=20 > > + ((user_mbp_priv->flags & > RTE_PKTMBUF_POOL_F_PINNED_EXT_BUF) ? > > + sizeof(struct rte_mbuf_ext_shared_info) : > > + user_mbp_priv->mbuf_data_room_size >=20 > Should rte_pktmbuf_data_room_size() be used, and have it return the right > value for external mbuf? The pool initialization is not completed yet (private structure of mbuf poo= l is not copied yet, so in this point rte_pktmbuf_data_room_size() is unable to= fetch the valid data room size. Beside this, rte_pktmbuf_data_room_size() return= s the valid value for the mbuf with pinned external buffers after pool initializa= tion is done. With best regards, Slava