From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10053.outbound.protection.outlook.com [40.107.1.53]) by dpdk.org (Postfix) with ESMTP id 8F37E1B5BD; Thu, 12 Jul 2018 07:58:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ugV/lFRk7j3qxvKDMYnlsIYPvXJ22Q01mZ8CAB1EjP8=; b=xGPxsV7StW2tZfUSIIftB70exPQYP81A+R8nWF81I9jzjJVj4sfZEIjhInkllJXu1LjrLVP6QqBKCMhdlQA8f+UnR/NcsVDLBha1YeGhoh0FS+D2c47VBJQscnab9/X2S+3ItY/lq7xlZU/MAesuH9q6rJwsh97Q829gUKe8QCI= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Thu, 12 Jul 2018 05:58:11 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1%3]) with mapi id 15.20.0930.022; Thu, 12 Jul 2018 05:58:11 +0000 From: Ori Kam To: "Xu, Rosen" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUGYWFrol0AnxAPk+9mPXqGNnztqSLC2AAgAADX4CAAAOEEA== Date: Thu, 12 Jul 2018 05:58:10 +0000 Message-ID: References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <0E78D399C70DA940A335608C6ED296D73A13DA82@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A13DA82@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3492; 7:J/XUhYjmV5BDd8wTxaXjvlAPCpDgNtXfaYDMqVg4+WOTRrZ6oMLt64ZTSSX81i2F2Go45XZBmoQ11jlIfJTnOacui6WcOX9Hj2H6BXztiAbuWY7Irp8wtcubCobFOetb1oodB5i6IYq9hlFUr4GHRROMsVyC3K50mbnIJ3XelEedJrW5rqLOp8Nf9b96nSTA3O/NVzQmCIeEyxIyBJqVxJqtgDXtyv1VCc11ttgCfrKirnkXmcYTIhkZ9DOI97b/ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9e538d78-c7cc-49c4-a796-08d5e7bc72e3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3492; x-ms-traffictypediagnostic: AM4PR05MB3492: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB3492; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3492; x-forefront-prvs: 0731AA2DE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(136003)(39860400002)(13464003)(189003)(199004)(25786009)(66066001)(14454004)(256004)(9686003)(74316002)(478600001)(55016002)(53936002)(7736002)(68736007)(81166006)(5250100002)(8936002)(229853002)(305945005)(2501003)(6436002)(6246003)(2900100001)(4326008)(2906002)(3846002)(81156014)(11346002)(476003)(97736004)(53546011)(105586002)(99286004)(110136005)(446003)(86362001)(106356001)(7696005)(486006)(6116002)(76176011)(6506007)(33656002)(5660300001)(26005)(186003)(54906003)(102836004)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: m0bJXsvPUFNbGEL8Mj/azgxjgC+wbzQjzozmIc6Gc+30ysk93u+zhEkWAqaMC8v4UqdME2LkztJoQQ316BXKSTRS566JKxN3SLz5N3uJ2CFCiuXzhN3X17sysUFwwLNZHNlFOfjnjYtXUe/tUZUFVVy9cVRu/jAKFBeSq/M/OnJNUpZFqGlzNgU6BIz8m1slNZfOiVF5vv6V+SjrcWt1TAf7AG3ekyaQiCFMkjXPp5ojxEnyghOse4edNZCA+qs/yo1R9cBQMYQrPaLCODLbxljbzLWTK6z/27GNsyqhKSWucLkoom5ELUR7HkeSsVPI3tov2/TyYZjvxn+/oQDaTYFzx1umTvHhNlzskCfZn1s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e538d78-c7cc-49c4-a796-08d5e7bc72e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2018 05:58:10.9072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 05:58:13 -0000 Hi, PSB=20 > -----Original Message----- > From: Xu, Rosen [mailto:rosen.xu@intel.com] > Sent: Thursday, July 12, 2018 8:27 AM > To: Ori Kam ; dev@dpdk.org > Cc: Yigit, Ferruh ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_con= f > initialization >=20 > Hi Ori, >=20 > examples/flow_filtering sample app fails on i40e [1] because i40e require= s > explicit FDIR configuration. >=20 > But rte_flow in and hardware independent ways of describing flow-action, = it > shouldn't require specific config options for specific hardware. >=20 I don't understand why using rte flow require the use of fdir. it doesn't make sense to me, that new API will need old one. > Is there any chance driver select the FDIR config automatically based on > rte_flow rule, unless explicitly a FDIR config set by user? I don't know how the i40e driver is implemented but I know that Mellanox convert the other way around, if fdir is given it is=20 converted to rte_flow. >=20 > [1] > Flow can't be created 1 message: Check the mode in fdir_conf. > EAL: Error - exiting with code: 1 >=20 > > -----Original Message----- > > From: Ori Kam [mailto:orika@mellanox.com] > > Sent: Thursday, July 12, 2018 13:17 > > To: Xu, Rosen ; dev@dpdk.org > > Cc: Yigit, Ferruh ; stable@dpdk.org; Ori Kam > > > > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add > rte_fdir_conf > > initialization > > > > Hi Rosen, > > > > Why do the fdir_conf must be initialized? > > > > What is the issue you are seeing? > > > > Best, > > Ori > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > > > Sent: Thursday, July 12, 2018 5:10 AM > > > To: dev@dpdk.org > > > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > > > ; stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_con= f > > > initialization > > > > > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > > initialization. > > > > > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flo= w > > > API") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Rosen Xu > > > --- > > > examples/flow_filtering/main.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/examples/flow_filtering/main.c > > > b/examples/flow_filtering/main.c index f595034..aa03e23 100644 > > > --- a/examples/flow_filtering/main.c > > > +++ b/examples/flow_filtering/main.c > > > @@ -132,6 +132,12 @@ > > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > > DEV_TX_OFFLOAD_TCP_TSO, > > > }, > > > + .fdir_conf =3D { > > > + .mode =3D RTE_FDIR_MODE_PERFECT, > > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > > + .status =3D RTE_FDIR_REPORT_STATUS, > > > + .drop_queue =3D 127, > > > + }, > > > }; > > > struct rte_eth_txconf txq_conf; > > > struct rte_eth_rxconf rxq_conf; > > > -- > > > 1.8.3.1