From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by dpdk.org (Postfix) with ESMTP id 298D1200 for ; Sun, 7 Oct 2018 18:31:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPsmTkzgoCyVvKHvBkCaNZQ2H+RKV0+uWebeNcX7iPU=; b=ZmJ9ZFhM0/jVoHZJXn6LsQjd3VsUuUHaB2NGU7alpLd1jbOdFL7UVc5KVvvixYF7nk6GerQMiaf2uIm5TmIESwCWRgKwxzDSlkuGb5A7Y53JZYu/JneWx/0iy+zj0pdkhxwN5N5BZn3vgyl0JSI6jr6ypfJBbre0C+3tU3WDQpE= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3474.eurprd05.prod.outlook.com (10.171.187.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Sun, 7 Oct 2018 16:31:55 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202%4]) with mapi id 15.20.1207.024; Sun, 7 Oct 2018 16:31:55 +0000 From: Ori Kam To: Mordechay Haimovsky , Adrien Mazarguil , Shahaf Shuler , "orika@contextream.com" CC: "dev@dpdk.org" , Mordechay Haimovsky Thread-Topic: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name conversion Thread-Index: AQHUXlntGYqtM7iJfUa3N9/wGg5Us6UT+VcA Date: Sun, 7 Oct 2018 16:31:55 +0000 Message-ID: References: <1538926667-23009-1-git-send-email-motih@mellanox.com> <1538929311-31815-1-git-send-email-motih@mellanox.com> In-Reply-To: <1538929311-31815-1-git-send-email-motih@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3474; 6:vnnRbt+8xfOallABY7E05GILi4tE3l5wByAY4YwLqOrC8dkm+bUN/7hx0nUY/SS041Xw2i+K+/7ttnxeOkcUgkye71cGXtHrfbE01GBpYxvw8QVK5v0wyLp5z2Oa4W+z1LkePLZWE5b0KXdqduzDgUEw/7nT8+c5sbXslE1/j8Ar7Gr9CAegXROCX/MUlc3zHdlZVkOxMRPV2PGEtRLdVH0YSkqNZfXA/8/NLVeMtINjG2XaW3aBL+Fq5zOQPgHclW3gFM9mK9tU3HuMufLv5xOGHzJ2gRw78cTfm3lRYLnM8jHqVZVIXG3Xqb9/8xSUEq8I7eZ5pkC0QXFF9kXNSVuOwwKLzxKVuX6WaFk43yW1anPXtBeRGLtxlXjVAe1sWjs96L5ZX19W28QJ6KdiQICiePWSquZHVEHotHlbP6iNGNwop5VPzpLXIFescwqbpZojeltlKG4jDuupFZvCNg==; 5:d6S991lOPtBloFhk1pjSQ0d/qjDUPR2RT//6dHO0yTBB8yKlO4avKms5CSaKu5toO6FS1aoP3LoN0gxJL8evCTJvtbhoSKLdVBiI3S/KcrBGOgBM7LRKuU716761ldBiqzJJtJHc5ETuBfj2we5DnVSyNt7N/NuM+UvcVkUGHc8=; 7:jDIZ4wDAaSD3lsTlQe3zcjQomCM0k0aFQ0yTu9gCO2BDwOFYQrm24fMuH5nEY1eCvZVIr2XyRvZ1TwB8ELZcxTYJZQFE46tC8/ETzqPYWQ3IWZd24p4GjpJOGEtq6vOstzTp6ZvepV4W0CMs4+xDtmS4jZPDqLrUTZ/OKy/wCP7T7wiCnWmpIrhO9MAYHfMSKPEZrDWK+U1d3uIdOV802LPtPtHRcOKU1hg7sSqsmmoOCY/IWWsULDvn6WCrilxk x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 76753fc8-bf72-4d3b-f9e0-08d62c72656c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3474; x-ms-traffictypediagnostic: AM4PR05MB3474: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:AM4PR05MB3474; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3474; x-forefront-prvs: 0818724663 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(396003)(136003)(376002)(13464003)(189003)(199004)(25786009)(53936002)(55016002)(4326008)(107886003)(33656002)(9686003)(71190400001)(71200400001)(14444005)(256004)(97736004)(6436002)(8936002)(229853002)(6246003)(68736007)(105586002)(5660300001)(106356001)(81156014)(476003)(2900100001)(74316002)(478600001)(7736002)(5250100002)(305945005)(486006)(7696005)(81166006)(6506007)(53546011)(446003)(11346002)(76176011)(86362001)(102836004)(3846002)(6116002)(2906002)(14454004)(99286004)(66066001)(2501003)(26005)(186003)(110136005)(54906003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3474; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: hv3jN20aXi9cdZ1tnLxwpgJpTTH0DnyGfymT993eDiDrP0An/j3R1ArUwJonWyvcVanTtfrfwwaDU3mLZIES/D5omDVVMT3M6Ec15yjyBSKxBobgzcl2iPvtKBJryvnAEdKzaBhtKXB1m0ysqmXsbkV22+R+i84teHxmUkoTgtj1EVWrEA/JLj+B6ZqMY7chhrGOmfF6WQiyO1kdOgX97ACyif289ciJ1O7o38C3JOxh5mMYTh9cFg0bpEVQ++GNSINCTS/yH2Cp0+ReVrzzyJzGKbjvxx7k0XKb7cGrix5rsgGxDIXujW18i8/YbWv6IkBF/A9sHvv3GSXWrJUY3fX/Cg4Ak5bVA7nzP+wVI8k= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76753fc8-bf72-4d3b-f9e0-08d62c72656c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2018 16:31:55.8100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3474 Subject: Re: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2018 16:31:58 -0000 > -----Original Message----- > From: dev On Behalf Of Mordechay Haimovsky > Sent: Sunday, October 7, 2018 7:22 PM > To: Adrien Mazarguil ; Shahaf Shuler > ; orika@contextream.com > Cc: dev@dpdk.org; Mordechay Haimovsky > Subject: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name > conversion >=20 > This patch fixes a typecast bug found in rte_flow_conv_name routine > used in rte_flow item/action name conversion. >=20 > Fixes: 0c2640cbfa7a ("ethdev: add flow API item/action name conversion") >=20 > Signed-off-by: Moti Haimovsky > --- > v1: > Fixed wrong hash number in "Fixes" message. > --- > lib/librte_ethdev/rte_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > index 9c56a97..21a4286 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -767,7 +767,7 @@ enum rte_flow_conv_item_spec_type { > { rte_flow_desc_action, RTE_DIM(rte_flow_desc_action), }, > }; > const struct desc_info *const info =3D &info_rep[!!is_action]; > - unsigned int type =3D (uintptr_t)src; > + unsigned int type =3D *(const unsigned int *)src; >=20 > if (type >=3D info->num) > return rte_flow_error_set > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori