From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by dpdk.org (Postfix) with ESMTP id F0E575592 for ; Wed, 17 Oct 2018 07:11:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=03gAKH24dF3WimLRbs7vVElscHlv2kKCpFssOaG62CU=; b=CyfPIVMm+23NBgyEBmu8Bpi6cVqptDebv0HCgoomN547dMpx/xW+xVs/nxBt6W3wZ1181xvqEDFb822vGvw/EXdbRRdqH5dvqVnhoQB2RkR5pQir/Eb1hlnBJiMRpZay5gAjBp1USeGTpb47Az0wbV0kJnwFMTGa321SlZt/rzQ= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB1602.eurprd05.prod.outlook.com (10.165.245.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.26; Wed, 17 Oct 2018 05:11:29 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202%4]) with mapi id 15.20.1228.027; Wed, 17 Oct 2018 05:11:29 +0000 From: Ori Kam To: Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" Thread-Topic: [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow Thread-Index: AQHUZb4253JTlEw6sECbjdrVVyILSKUi5CBQ Date: Wed, 17 Oct 2018 05:11:29 +0000 Message-ID: References: <20181017020739.11203-1-yskoh@mellanox.com> In-Reply-To: <20181017020739.11203-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB1602; 6:QzdkWRdDE2EHkywAzTBwD9F5RwkqNSPHRhQI9rUp2KHPGtlpNgoHFKI9i+O6gGk+6QZfd11Vd4vPY4FFTp2iu7Ds7QN9tBp8yoFEcSDTm/wSTxcKySuItk3O2Dto81k/LPcTp87ttsysTezQCSVAYt0NGhGZEz30JyCmVyqddDje3WYD9ti1I6quyHQOjXwM63KFoLYaXD6M91olhg73ebQMZ7BYJXNk7WfbySULYa7Ybc7xQ0HewszcOU4JArgyp1Ufnq1zH9Tdm3Sxxv1JoyNjPk+jjfFpRskwbJd/DX2toDaTjHZiV4LrcvC+/DkWXqdoBqsbsJlaEh0xwCzbIHvmy+rWKJeXwQxeCXS1A1sr43H0dlL6ob+62u7NxStNizmIbW1tPAtnLRi/4J3fWfH4o8I+gW/Zo2hV1McdsrDe6IQh9w622O32mqE5ly96/2t5vaNQ6udtNQZ5uEyd2w==; 5:IcrQMxm9kvOPzuV5ddnW6zHVIYhlh6xQDZXWchn99iR6fP8JpKApMTb10qTk15MyuQQH2unXOqJLOcdBY0/RSwmZ1tK3kTBnhVjQO3VYAOeBiYJ2HXj4KCzZpjUsRSC+pPiiuHNQjYmnH3/9PQljCo/zu0FyokMRtd/jT5qezVI=; 7:qoR2KlB5zMTKS7wHU+IFmO8s8hTwkO8KDgWwcmwJrKH8D/gmyp/QoSucqHuvox83Z76NhcRSHBWBUzsB+ijtl3mTglP08qG1U46lN6l3QF9m1E4QoV+yhHqpAurwqzZaxJ8PSdt4SGrzt/+ADPa8mXoVJtGoVjDu+QF1DyGn/UKvKcfOXZotb/I5nIW93TvzoQtv4YboEpu2WxzWcSgKAoiJ/sw7z23WkUnCuDC61x5+l478i0CLkdkWh/fS7Kbg x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2057b618-6c54-4257-0b58-08d633eeff64 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB1602; x-ms-traffictypediagnostic: AM4PR05MB1602: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991090); SRVR:AM4PR05MB1602; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1602; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(136003)(39860400002)(396003)(346002)(13464003)(189003)(199004)(55016002)(53936002)(7696005)(71190400001)(105586002)(99286004)(229853002)(76176011)(6436002)(71200400001)(4326008)(25786009)(11346002)(305945005)(7736002)(74316002)(5660300001)(106356001)(33656002)(86362001)(26005)(14454004)(8676002)(6636002)(256004)(8936002)(5250100002)(486006)(14444005)(81166006)(97736004)(2900100001)(81156014)(186003)(2906002)(476003)(68736007)(6246003)(6116002)(446003)(9686003)(102836004)(66066001)(6506007)(316002)(478600001)(53546011)(110136005)(15650500001)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1602; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9dRzp0VwZyACw081g8LT3VLF5hoKGlLo9fcNHiToCz1K4nm+QRNIpbgDq/buUDvbzjifO33KdMH2LYRhNmaeA2cC6GFvF9SM7wAhv4m9prQQ4gme7qVDa6qcJ9QRFVxe4FwiKIfUBuDuegIxYdl72iKOeUwxyFIX/zlp/nyr6TWbj741/FGaFkZGmUoC85JbTojN0ZbuYZR15QohZMtqvbj+593Ba/7js5+F7t2pauEh+pw0ZmltQOxs2ekTDM4ISsTwumti06z8WpozUmoX8MG+JiiUH2XQdjwfsnF5C4ihFDzWbTfP9ZAp7oAEl2Cy6QZH1WFlMQgAdQbBYq7AdZLcsVG0qrhg3zRxSxuh3AA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2057b618-6c54-4257-0b58-08d633eeff64 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 05:11:29.8752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1602 Subject: Re: [dpdk-dev] [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 05:11:32 -0000 > -----Original Message----- > From: Yongseok Koh > Sent: Wednesday, October 17, 2018 5:08 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow >=20 > In case that the library doesn't support DV flow, if enabled by > 'dv_flow_en=3D1', print out a warning message and disable it. >=20 > Fixes: 51e72d386c99 ("net/mlx5: add runtime parameter to enable Direct > Verbs") > Cc: orika@mellanox.com >=20 > Signed-off-by: Yongseok Koh > Acked-by: Ori Kam > --- > drivers/net/mlx5/mlx5.c | 6 ++++++ > drivers/net/mlx5/mlx5_flow.c | 20 +++++++------------- > 2 files changed, 13 insertions(+), 13 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 795a219771..70b8626126 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1016,6 +1016,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > cs_desc.counter_type, cs_desc.num_of_cs, > cs_desc.attributes); > #endif > +#ifndef HAVE_IBV_FLOW_DV_SUPPORT > + if (config.dv_flow_en) { > + DRV_LOG(WARNING, "DV flow is not supported"); > + config.dv_flow_en =3D 0; > + } > +#endif > config.ind_table_max_size =3D > attr.rss_caps.max_rwq_indirection_table_size; > /* > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index bd70fce248..04e287f160 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1673,25 +1673,19 @@ const struct mlx5_flow_driver_ops > mlx5_flow_null_drv_ops =3D { > * Pointer to the flow attributes. > * > * @return > - * flow driver type if supported, MLX5_FLOW_TYPE_MAX otherwise. > + * flow driver type, MLX5_FLOW_TYPE_MAX otherwise. > */ > static enum mlx5_flow_drv_type > -flow_get_drv_type(struct rte_eth_dev *dev __rte_unused, > - const struct rte_flow_attr *attr) > +flow_get_drv_type(struct rte_eth_dev *dev, const struct rte_flow_attr *a= ttr) > { > - struct priv *priv __rte_unused =3D dev->data->dev_private; > + struct priv *priv =3D dev->data->dev_private; > enum mlx5_flow_drv_type type =3D MLX5_FLOW_TYPE_MAX; >=20 > - if (attr->transfer) { > + if (attr->transfer) > type =3D MLX5_FLOW_TYPE_TCF; > - } else { > -#ifdef HAVE_IBV_FLOW_DV_SUPPORT > - type =3D priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : > - MLX5_FLOW_TYPE_VERBS; > -#else > - type =3D MLX5_FLOW_TYPE_VERBS; > -#endif > - } > + else > + type =3D priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : > + MLX5_FLOW_TYPE_VERBS; > return type; > } >=20 > -- > 2.11.0 Acked-by: Ori Kam Thanks, Ori