From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10079.outbound.protection.outlook.com [40.107.1.79]) by dpdk.org (Postfix) with ESMTP id 0E0691B150 for ; Thu, 3 Jan 2019 15:21:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B6ivyLPnuzpE4AnHdD6gethG78/52rGHRcxkquJpHH0=; b=tmy1jE4tLUYHttRgiRJXP8B1y71LGqBw+AHRG4l8gA3Fc9qm1hZmaqe61p2rEgpkzUcjPX3dN+yVwFQ1pkqzVhUqUwcs0xpUxHQujc19UbTLn+0gh+MgetZHfe0ovJcgFgCJFvSOHoTORXVwi/UatlhDrOrkrczUQJIlquK0AHA= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3185.eurprd05.prod.outlook.com (10.171.186.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Thu, 3 Jan 2019 14:20:58 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::e086:6fd:7477:c605]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::e086:6fd:7477:c605%3]) with mapi id 15.20.1495.005; Thu, 3 Jan 2019 14:20:58 +0000 From: Ori Kam To: Dekel Peled , Adrien Mazarguil CC: "dev@dpdk.org" , Dekel Peled , Jack Min Thread-Topic: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation Thread-Index: AQHUo2Zo0Pi5qnvBEk2VMA5MYPdtLaWdl1rw Date: Thu, 3 Jan 2019 14:20:58 +0000 Message-ID: References: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3185; 6:bHUmuvM+QPN5Zo3dOoF6OwXtBotHL67iHAaYx8au8Qn2P7k5wXocPV8vMb+c4lVVDS4F6+YCu431YEMDcWkIdGqsZBacrAz4bworquz6R5GwrXCv2YU+o2rnz155uWeW01HBQveufEtxARPbx7znvCUP6pJho3I8U6iEdX0/NS+ZbxIC/N02F+kea19J6adMjOjzKeHw8fjhYwBZMD4ALf+Wg1dBpDpBGk9fB+lSq0l5wF80SoLRMjBK4bDQ36JTufmH9F/xvqP1Po7ZL1ujSW3ByheaKoycpJIRpVPEeBw+PPZg8V/iTNlQxTJUlBxHlDLUxGxEYp1qL2C4gRL/qq/K6hbdm/ilGEC8kygv2inKxBI6Th3JP2hZZqPKNguQsaQmXmqmDi9L4+N+tlPCniqSea3KZ0F2WbHN7I2hc37+JKsmuUQXQ98gTWeUteJyaccnCheAyvlm+3LQQN2p5A==; 5:dBN5uUf1fewYAGrcX9ejZJLVUsC2x/jW9Z8T3bs7reSrGMr+6YhOpnzWPp/GqWWUHQgAqwEd6z7RX6lN7tBq2Zky2tg2Zzjgfn4BjVVJljHwk+4jLC8bsnhkt5eOEht+O4XVjJEpBQcPxznZlhqVaXCwnJrVipRddh/QXrbrqizM0IPmVIddB1UwRD8Xb65wPdT/r0SydKE8Hrm3SlqjUA==; 7:c+YTOlAWLI9owEaPoErpFS3DjoWpkncM5efl/3L0axZYdSGVFOgEa6b340y9AKitveWs8tWH+yzltV/GsJ9xyW1rN3GLR8j7T4ccBFNBy7SJNqwDFq51MkI8weg/Zwzjoc1LYxT3iWrjBRUbpYP6Bg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: a2126f3c-a72b-42e7-690b-08d67186ae40 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3185; x-ms-traffictypediagnostic: AM4PR05MB3185: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3185; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3185; x-forefront-prvs: 0906E83A25 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(39860400002)(396003)(13464003)(189003)(199004)(74316002)(99286004)(53546011)(7696005)(6436002)(476003)(86362001)(97736004)(68736007)(8936002)(71200400001)(6246003)(110136005)(54906003)(81166006)(6116002)(3846002)(71190400001)(55016002)(9686003)(53936002)(102836004)(6506007)(11346002)(76176011)(446003)(26005)(6346003)(186003)(81156014)(316002)(478600001)(14454004)(5660300001)(105586002)(66066001)(229853002)(305945005)(486006)(256004)(4326008)(7736002)(33656002)(2906002)(107886003)(106356001)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3185; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jhb1jHAmvLZ16EJLUiYfCA97NNkT+Mw2XR0yHhoWxNrpXOGemdr8rq/WVQtbpfA97rGeDlge1KxTsNpsiFkHFQcpPg0CG1Uic06DzZwVHRMETVfBW51qeEc/Mv/oPrET6YFgYjAKxXnd0Kv+uJ5Dh6no2XbFfql69fVhMTODlDWc1ZGQX8ZCCBPjC3gfS+kmf9H0WdpPTM9Bp390o6sUuBnfLyqvKLSRTYYj/u+vUtamcDOlrB1oxAbBqJL8Vj5F+EsEvrBqXQWK2Z70W3iiMFnlnw11Lfc99qg+mpbra2Y7F+G+s7lfIRlRhhUg9Ywy spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2126f3c-a72b-42e7-690b-08d67186ae40 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2019 14:20:58.2126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3185 Subject: Re: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 14:21:00 -0000 PSB > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, January 3, 2019 3:09 PM > To: Adrien Mazarguil > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > ; Jack Min > Subject: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions > documentation >=20 > This patch fixes a typo in SET_MAC_DST action description. > It also adds restriction note for set MAC src/dst actions description. >=20 > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") > Cc: jackmin@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index c186375..df1ac2f 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2314,7 +2314,10 @@ in pattern, Some PMDs will reject rule because > behaviour will be undefined. > Action: ``SET_MAC_SRC`` > ^^^^^^^^^^^^^^^^^^^^^^^ >=20 > -Set source MAC address > +Set source MAC address in the outermost Ethernet header. This line is incorrect in case we have encap action the modified MAC will b= e the inner. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. >=20 > .. _table_rte_flow_action_set_mac_src: >=20 > @@ -2329,7 +2332,10 @@ Set source MAC address > Action: ``SET_MAC_DST`` > ^^^^^^^^^^^^^^^^^^^^^^^ >=20 > -Set source MAC address > +Set destination MAC address in the outermost Ethernet header. This line is incorrect in case we have encap action the modified MAC will b= e the inner. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. >=20 > .. _table_rte_flow_action_set_mac_dst: >=20 > -- > 1.8.3.1 Thanks, Ori