From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0079.outbound.protection.outlook.com [104.47.0.79]) by dpdk.org (Postfix) with ESMTP id 842E91B4ED; Thu, 12 Jul 2018 12:53:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8IzaTHhoBLmvSGOsHOJqF/hUpcfz2EQiCtfCZIzSwbk=; b=GW9a8vOSe3V95ma8aZxbKNpYMXVFf9r4wlBDSkqeta8nFwKGFSYaYQcl6qSGtdkPBWZ/2c2fXLHPcKxPfd42e1NAr+I+vCz7NyzQfDrIQmMhIANgiNzFTyy09j43owmfR+EMiDOAkYcqi5QZpvgQvNj/qR21+I4rDt1LwRvZ8Lo= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3426.eurprd05.prod.outlook.com (10.171.187.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Thu, 12 Jul 2018 10:53:31 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1%3]) with mapi id 15.20.0930.022; Thu, 12 Jul 2018 10:53:31 +0000 From: Ori Kam To: Shahaf Shuler , Yongseok Koh CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "stephen@networkplumber.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix compilation for rdma-core v19 Thread-Index: AQHUGa2QunlBHf7ZCE+Lw9aoMnZbzqSLaSGA Date: Thu, 12 Jul 2018 10:53:31 +0000 Message-ID: References: <20180712065653.29801-1-shahafs@mellanox.com> In-Reply-To: <20180712065653.29801-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3426; 7:hxNacQpGVEKvuOAWkFlD1iWXBqEGL1fNGf6/sTHa60Bk9dBIBhAElciy2/1+0zRLtLgwvGfxFgYlRoJeoW3zg1sYXCzv2hDRhuCkK9JhFqpikqYpOS/MZBC0MkJm5ySAG/FLgAokXOkj8UcyARKdlFBRMyskIFB85/tLTC23W6oPXrP9Fsa8sJxLB2JrUZywbK5Cak0B8C/stApVwv1oYNO6qINGSxYj6eioBPcaISaND2Xk6dAyL70HbFT4FyUq x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c20dd5c9-e2de-41ca-ff16-08d5e7e5b527 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3426; x-ms-traffictypediagnostic: AM4PR05MB3426: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB3426; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3426; x-forefront-prvs: 0731AA2DE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(39850400004)(346002)(376002)(136003)(396003)(366004)(189003)(199004)(13464003)(86362001)(8676002)(102836004)(5250100002)(110136005)(9686003)(81156014)(305945005)(2900100001)(8936002)(55016002)(6636002)(105586002)(26005)(54906003)(256004)(6436002)(486006)(81166006)(106356001)(476003)(14444005)(14454004)(11346002)(446003)(97736004)(316002)(74316002)(66066001)(3846002)(99286004)(68736007)(2906002)(7736002)(229853002)(6506007)(53546011)(5660300001)(6116002)(25786009)(6246003)(53936002)(33656002)(7696005)(76176011)(478600001)(4326008)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3426; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: DoxiUK2EUEp80IrNkCsDPW4OYE4/0TOKxwNvVV4CbWpbExrCpgzKkQ6h3xnmo7A5d7lu7F6cnDqB54kxoEnOmyJXLH/amj8zvAyfvMl5h8RPhacGw+OOyMmDwZPSCxt4dk47aTZ4yZjKJCbPcCdFS1j7zC04N+RVDeNWPeX0ZaStDP2CIp+JapyKWq0ZYcWxdzdetCKpMf8wUYH1BrFYX5m9FoLHuLL0k5P2ESylPYNekefS0En4S4p7fzMsKEOYjdRuiRowFTIsDIzXG1Mr8KRsrJigb/R20x2FOlbfZokkETfI9i0rhqgVTFUUq3BtkPsrhzaloin0514JdTSfF4NPEg0LztIvQFZ2uWvNdew= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c20dd5c9-e2de-41ca-ff16-08d5e7e5b527 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2018 10:53:31.4146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3426 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 10:53:34 -0000 > -----Original Message----- > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > Sent: Thursday, July 12, 2018 9:57 AM > To: Yongseok Koh > Cc: dev@dpdk.org; ferruh.yigit@intel.com; stephen@networkplumber.org; > stable@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5: fix compilation for rdma-core v19 >=20 > The flow counter support introduced by > commit 9a761de8ea14 ("net/mlx5: flow counter support") was intend to > work only with MLNX_OFED_4.3 as the upstream rdma-core > libraries were lack such support. >=20 > On rdma-core v19 the support for the flow counters was added but with > different user APIs, hence causing compilation issues on the PMD. >=20 > This patch fix the compilation errors by forcing the flow counters > to be enabled only with MLNX_OFED APIs. > Once MLNX_OFED and rdma-core APIs will be aligned, a proper patch to > support the new API will be submitted. >=20 > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > Cc: stable@dpdk.org > Cc: orika@mellanox.com >=20 > Reported-by:Stephen Hemminger > Reported-by: Ferruh Yigit > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 9e274964b4..d86c6bbab9 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -150,7 +150,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto- > config-h.sh > $Q sh -- '$<' '$@' \ > HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \ > infiniband/verbs.h \ > - enum IBV_FLOW_SPEC_ACTION_COUNT \ > + type 'struct ibv_counter_set_init_attr' \ > $(AUTOCONF_OUTPUT) > $Q sh -- '$<' '$@' \ > HAVE_RDMA_NL_NLDEV \ > -- > 2.12.0 Acked-by: Ori Kam