From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) by dpdk.org (Postfix) with ESMTP id BC5C71DA4; Tue, 24 Jul 2018 08:27:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ank1N8g2Snl4Dh6zetN4BfbIPtkuuRmarewPwLnouVw=; b=I+eFFygPCbqP4uiQ2a9ACkHEHQ44rk+TRf2YQNKdm3J7XPoQmBwaj9cvrQJmOu7R4jZGx+5uFLONUR39yuCc6uJG0JLddscSF4cWAryyQso/rgO3TjYIWhonQ0CQRhursuZXuYzwwQnpeRhYH9UqqtIT8LtcQuwVyzuuGefLP4o= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3475.eurprd05.prod.outlook.com (10.171.187.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Tue, 24 Jul 2018 06:27:07 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::6d55:c970:605a:4106%4]) with mapi id 15.20.0973.022; Tue, 24 Jul 2018 06:27:07 +0000 From: Ori Kam To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Yongseok Koh , Shahaf Shuler CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter Thread-Index: AQHUIlVy8woYIg4iJEqemlUVWef+CKSd6ewQ Date: Tue, 24 Jul 2018 06:27:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3475; 6:6y7EpycG2XVix+TdnngzoBf3yHm4axhXebqOPhrKLG2qSxq0DdruMx6cY9GFNicQeJ/eb0/ZX+H6q2j9B5oOMYAVEj58u7HDWgbosymAw3qKwyYuiDIbSHnvceLCzl3MmZwisaVL6iBjQyv5jmEujq7i7RyNeeeRjiGDbpoRul/lzCCPJ7rMYGpELgG7LHo5Oe3gzwlUxOia2CUeyqODiOJU4Nk0KHFD80WZGFv/ToGXkgj8gWNPYdM6Gh0hCEZY/zmPg5AaTeyoj4tODfmzjbt3TFM5fLenr9By2uQr6uR5WqbMxyQlTmxiZfa/riPFDDhn8IA4p6NYS3TUZxM0Rhyc61xd+cTZ+6jSXecMKRaXrqdu/WASi6VbD2g+6mVoyLmM3yMhscGaFNxnU8D2JKtrXlosMY5Pmx7Dh0rpCJjt41YQ4ypB69PtFnMtQjZr+9SYbrMQARV097h5JDix4Q==; 5:ITKznFt+98uRbx5JMEysXLwsSWAwzSu8fLmEgijd+cpP9p1X4HciMeMsEP0dzENL3ZDqnotQekmwRzh5Ta9eSX4tvxkBjhRGPRz3IZ3fJRGICTJ7RZZjKVgJERdTVMXDzLs/y55W9HyNpLuVeok7l+54rlkKrnJHv2yg4de2D3c=; 7:TextlAs5nphuZrDl/aB3m8obGh0sUO7Z3LgZ03p4jlZpALQAo1sixEW5FEbz1rSCNR1wD1NDMyaJj32jfuUcE2i5F7kHY22YpHj3GB+ncIlvXvmfN4q1r3ixBL+0JLQxQij7saBLrWCF9ZDMhLzEKZPYW/8VWYRsLcxWSpdWpMsH7InrgxlRk91oW1BMtAjRM6v1oooK154mqQiPBYL7qW1a08inaPOSKiiZRk2DSbc+LQ4uwPrmV7gnksRLgAQy x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9f0be134-173c-423c-04dd-08d5f12e7b25 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3475; x-ms-traffictypediagnostic: AM4PR05MB3475: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB3475; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3475; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(366004)(376002)(346002)(396003)(13464003)(189003)(199004)(99286004)(106356001)(256004)(5250100002)(66066001)(7736002)(2906002)(6116002)(3846002)(6436002)(8676002)(2501003)(476003)(86362001)(486006)(25786009)(5660300001)(11346002)(74316002)(9686003)(478600001)(6636002)(305945005)(316002)(81166006)(53936002)(68736007)(81156014)(110136005)(26005)(53546011)(76176011)(186003)(6506007)(6246003)(97736004)(55016002)(33656002)(14454004)(105586002)(4326008)(446003)(7696005)(229853002)(8936002)(102836004)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3475; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Q+4UxCJ7PjQeqX05G0T5l2xZcLJ2vUAI/IEZSpSVyiM1wgQ/rqNw5Kj4aZtPiQDUc0/VzYLhClGlbSGq6IRi82ZrORuWLy37vaZMg3FURVe4/wZWfezfLS+BUdOkC651ZygqRTC9DxASLuw3x4AhB/RcAciREuBXIwo34yT2HCvbWIJlgms5hOUa14Elb249OyNKicch0z9X91gqPL/Peypg18J5OuQXK+FZGaZxwpJX8Ve28gUlxLth5eBMq9ejs6IXXe2ax6KwHNM1jNnk/CnaalDpJsdAi1Kc4Z4yCCSwu7cLlG8zyIrrlIKmqZSJo1NCgFnNuwwoWYpaM5YFaubcEvOWdSrz0z4BjQWyz4c= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f0be134-173c-423c-04dd-08d5f12e7b25 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 06:27:07.8645 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3475 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 06:27:10 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro > Sent: Monday, July 23, 2018 10:19 AM > To: dev@dpdk.org; Yongseok Koh ; Shahaf Shuler > > Cc: stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter >=20 > In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing the > sub flow engine to reject the rule. >=20 > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: stable@dpdk.org >=20 > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_trigger.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_trigger.c > b/drivers/net/mlx5/mlx5_trigger.c > index 4d2078bbd..d02a626ae 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -300,9 +300,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) > struct rte_flow_item_vlan vlan_spec =3D { > .tci =3D rte_cpu_to_be_16(vlan), > }; > - struct rte_flow_item_vlan vlan_mask =3D { > - .tci =3D 0xffff, > - }; > + struct rte_flow_item_vlan vlan_mask =3D > + rte_flow_item_vlan_mask; >=20 > ret =3D mlx5_ctrl_flow_vlan(dev, &bcast, &bcast, > &vlan_spec, &vlan_mask); > @@ -339,9 +338,8 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) > struct rte_flow_item_vlan vlan_spec =3D { > .tci =3D rte_cpu_to_be_16(vlan), > }; > - struct rte_flow_item_vlan vlan_mask =3D { > - .tci =3D 0xffff, > - }; > + struct rte_flow_item_vlan vlan_mask =3D > + rte_flow_item_vlan_mask; >=20 > ret =3D mlx5_ctrl_flow_vlan(dev, &unicast, > &unicast_mask, > -- Acked-by: Ori Kam Thanks, > 2.18.0