From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30060.outbound.protection.outlook.com [40.107.3.60]) by dpdk.org (Postfix) with ESMTP id 4CABC201; Wed, 21 Nov 2018 15:55:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bl2EkjPho3XJjGDGXITUU7/iDklmaczqi423DGwCsc=; b=WQEEvG5yPwNwWNfxFYWVn7514DGGrq5UjuO2nsBBYSu0ddXpiBsDSgY3psvsFWDPxwXWjN54jjaNQHfuzIbaK+pDnw9gLRADIIvS6ClzSWwhPkOjdEQO8FHXRdHG+qMZtbXhL5XyJDNzScttTOyj3DGwmyCPKHISPfgveiNxVz0= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3252.eurprd05.prod.outlook.com (10.171.186.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.25; Wed, 21 Nov 2018 14:55:25 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::1533:fa4a:5f23:cd47]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::1533:fa4a:5f23:cd47%2]) with mapi id 15.20.1339.027; Wed, 21 Nov 2018 14:55:25 +0000 From: Ori Kam To: Saleh Alsouqi , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix mpls bos bit default value Thread-Index: AQHUgakdjk1xgdIP9k2rr4+HA2lgcKVaUPDQ Date: Wed, 21 Nov 2018 14:55:25 +0000 Message-ID: References: <20181121144709.18805-1-salehals@mellanox.com> In-Reply-To: <20181121144709.18805-1-salehals@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3252; 6:Z+kGPDBEeMIY9WWi+7whKClTTaJDxqsUq4C77YSxCc27F9GHSm4U26hE9xC8kCitQmNMGYYrUDJZuyElj60Squ24W+ztONYdNdt/1+WxdOTFjEHJl5l+CloB41yFNYZa9wE04GMmxaW2DPmPjHS0yzDBGOemns6AOnekOFfQO+0wuwjwNLlKeknVB+otlqwdWqMNEAzCkwnBbm3MpaSb9/e5gEHcf7c6Qn9shvS1sVKxwCrgoP/03KRMFJxrClNb/edYBoGtKjKq8EsZY8ouzfr4b62annegTu+wkjxJT4ub/3Y7PWCVAQWIxuV+2Iygfa7O3RBLftObYizYXChnSprlVSoJabE429YBkHPFN80XzpYvmnmd5UQw7+bLMVfVIdOmvCH6ybUw21n6mpnBL2UoyffPfCSfI680NO4YdARiPPqbudyeX9eygvUiJLClb8D9EhEmmVDLzJivvauZ+w==; 5:+acaUj7aDLwqS3NsWk9Khie4zSze3NG9VjgNRYW52nTHtUctSg5VtoBb0EIDsd4cKimlGHzlHKliufxgpFRcoMzJDC4/V2m4LpBEX5W9dnhgx0Ft/A3H8+XF06MmNP0y8PajGtSCM9IBJzgqHt/ty75mYhf3q9NEmRqAgmMG8JU=; 7:6agsF4Y0aGw35Xyw7eC2y++dgpfkPyBIqcalufY6objASpB4aRjNLaCd7MwPZdnYmhS7l5EAyjsahldNJk1qPlpAsgNjmp3oBZqiYi1oBMoYlrbm/GWs7VBr5kntRAdej2GOgGaPkfPKso17XBpCpQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b2517048-024b-442d-85e6-08d64fc15ee9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3252; x-ms-traffictypediagnostic: AM4PR05MB3252: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231442)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3252; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3252; x-forefront-prvs: 08635C03D4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39860400002)(396003)(136003)(189003)(199004)(13464003)(6436002)(2900100001)(7696005)(76176011)(8676002)(99286004)(81156014)(81166006)(186003)(26005)(478600001)(25786009)(8936002)(33656002)(5660300001)(97736004)(11346002)(446003)(486006)(476003)(71200400001)(71190400001)(256004)(106356001)(6116002)(3846002)(2906002)(105586002)(74316002)(53936002)(9686003)(305945005)(66066001)(68736007)(2201001)(6246003)(55016002)(110136005)(229853002)(54906003)(6506007)(316002)(2501003)(53546011)(86362001)(102836004)(14454004)(4326008)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3252; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: bhKDwIrP9NVgq1s/DK6RCUD1zb7/N/L7mlRdkex/sBH/4yEL8Bjwi2XoAXd+P8MiwsjBql0ergMMeWpEfEPw6zwirTKK1Cz/k0LicLDZ9YM9RXP/l9klJfwLe+ntOAzmxoVzxtXqYuT57drNCbfZVJouhnQUILdcP7M2LbTJa0GLn3+Oke+YEu6otoHm9UlXU1Bbn8PdJMXlZvYEBlvI40dKq2rF0dksPu0GMN06LhIJBX6y1gHNrqCNff+eT8ioFwXszTa68XTRHWlyabQaYOR5Vk7RR5fuLbfrXNJ5k+6IW/AhPv3Bho5xb9c58pFFG6nzdVaic3CjHMipKy9qcLwg7ZuKI96e479l4QlT8iQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2517048-024b-442d-85e6-08d64fc15ee9 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2018 14:55:25.8680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3252 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls bos bit default value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 14:55:27 -0000 > -----Original Message----- > From: Saleh Alsouqi > Sent: Wednesday, November 21, 2018 4:47 PM > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org; Ori Kam ; stable@dpdk.org > Subject: [PATCH] app/testpmd: fix mpls bos bit default value >=20 > The Bottom-of-Stack (bos) bit of MPLS indicates > whether its the last MPLS layer (1) or not (0). >=20 > Indicating that the encapsulating MPLS is the > last MPLS layer in the packet as the default > behavior is more appropriate since multiple > encapsulation actions is not supported. >=20 > Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") > cc: stable@dpdk.org >=20 > Signed-off-by: Saleh AlSouqi > --- > app/test-pmd/cmdline_flow.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 23ea7cc82..5c0108fa7 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -3808,6 +3808,7 @@ parse_vc_action_mplsogre_encap(struct context > *ctx, const struct token *token, > header +=3D sizeof(gre); > memcpy(mpls.label_tc_s, mplsogre_encap_conf.label, > RTE_DIM(mplsogre_encap_conf.label)); > + mpls.label_tc_s[2] |=3D 0x1; > memcpy(header, &mpls, sizeof(mpls)); > header +=3D sizeof(mpls); > action_encap_data->conf.size =3D header - > @@ -3998,6 +3999,7 @@ parse_vc_action_mplsoudp_encap(struct context > *ctx, const struct token *token, > header +=3D sizeof(udp); > memcpy(mpls.label_tc_s, mplsoudp_encap_conf.label, > RTE_DIM(mplsoudp_encap_conf.label)); > + mpls.label_tc_s[2] |=3D 0x1; > memcpy(header, &mpls, sizeof(mpls)); > header +=3D sizeof(mpls); > action_encap_data->conf.size =3D header - > -- > 2.14.1 Acked-by: Ori Kam Thanks, Ori