From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <orika@mellanox.com>
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
(mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62])
by dpdk.org (Postfix) with ESMTP id 3C5E71B889
for <dev@dpdk.org>; Thu, 18 Apr 2019 07:15:41 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=eWVh+xSpXZ9HmYhNWX2c9FYoaXlFaa/HR0O9CRFQrhA=;
b=Wdws56LmzvlWAImohWUgouXLu2HXhAg94ywyN2LRT+1vSlUpaECUYrmkNcs4R9SKOrlbFT27UOO7SRguoCeZKL8eNOjQHgq09ZPtfrfPaT6zSgNngfeqwxUD/pLIK+/w1/WR+PKDIFSDfPA7Ibe4jRIXuZnwzqUWYpXsGRevQZc=
Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by
AM4PR05MB3298.eurprd05.prod.outlook.com (10.171.187.155) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1813.12; Thu, 18 Apr 2019 05:15:40 +0000
Received: from AM4PR05MB3425.eurprd05.prod.outlook.com
([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com
([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019
05:15:40 +0000
From: Ori Kam <orika@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
CC: Shahaf Shuler <shahafs@mellanox.com>, Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>, Moti Haimovsky
<motih@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch
Thread-Index: AQHU8wbp7Zd1uBBuNUC2THS4K2DfD6ZBJfAAgAA/KeA=
Date: Thu, 18 Apr 2019 05:15:40 +0000
Message-ID: <AM4PR05MB3425983C290EA7E00CE13B61DB260@AM4PR05MB3425.eurprd05.prod.outlook.com>
References: <1555276357-4892-1-git-send-email-orika@mellanox.com>
<1555276357-4892-10-git-send-email-orika@mellanox.com>
<20190418012807.GF31179@mtidpdk.mti.labs.mlnx>
In-Reply-To: <20190418012807.GF31179@mtidpdk.mti.labs.mlnx>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=orika@mellanox.com;
x-originating-ip: [185.175.35.255]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b05cca1f-cc7a-4ced-34d6-08d6c3bce62f
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);
SRVR:AM4PR05MB3298;
x-ms-traffictypediagnostic: AM4PR05MB3298:
x-microsoft-antispam-prvs: <AM4PR05MB32984A32D5FA0FA6E4A7BD9EDB260@AM4PR05MB3298.eurprd05.prod.outlook.com>
x-forefront-prvs: 0011612A55
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(39860400002)(366004)(136003)(376002)(346002)(396003)(189003)(199004)(13464003)(7736002)(4326008)(86362001)(33656002)(76176011)(68736007)(102836004)(6862004)(8936002)(55016002)(53546011)(6506007)(486006)(446003)(229853002)(7696005)(6246003)(6436002)(305945005)(2906002)(11346002)(66066001)(9686003)(81156014)(81166006)(74316002)(26005)(186003)(3846002)(6116002)(53936002)(8676002)(476003)(478600001)(97736004)(256004)(71200400001)(71190400001)(54906003)(5660300002)(6636002)(316002)(52536014)(25786009)(14454004)(99286004)(7756004);
DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3298;
H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: e1ThnBUTDhXkTYn2t+XPnDKpUHWbLwqrAPGU9sS/auB3ZPrO6/lQ2dF224M3mQLLGO/ECAzpb5ypSAWQk+80wgNwSSMsRtRoRZEXtHmJVWmyW7Ug5/TbBz7BQsjyZLyoF94PdhTReG7EUSQjrNj4by6yR6Nnp0YhAn/kAJHgvtpfTi5g5XlNMGP7feBm+qckIuiB73DX7d2IuEOInQGdYrYhdOgFogmbj2k1gJJBF97Y5NmGswsise4ZjV/zL8Vp0LheTU4sohU9fOArP414riGc7D7pn5JHbD3pkPJYg9WbqZ4+XHDnP4ul4R+nKKPfXYtKVRtau0I0qLfb4jklu3BAzMY0salsno5C1x4XxocOaCY5DpUpllA6yTttYlmh8OhUmzZlGpXilsyF41V4pttx1sMDRwIPqy3SE4We8aM=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b05cca1f-cc7a-4ced-34d6-08d6c3bce62f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 05:15:40.1234 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3298
Subject: Re: [dpdk-dev] [PATCH 9/9] net/mlx5: add drop action to Direct
Verbs E-Switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2019 05:15:41 -0000
Hi Yongseok,
PSB=20
> -----Original Message-----
> From: Yongseok Koh
> Sent: Thursday, April 18, 2019 4:28 AM
> To: Ori Kam <orika@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>; Moti
> Haimovsky <motih@mellanox.com>; dev@dpdk.org
> Subject: Re: [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Swit=
ch
>=20
> On Sun, Apr 14, 2019 at 09:12:37PM +0000, Ori Kam wrote:
> > This commit adds support for drop action when creating E-Switch flow
> > using DV.
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5.c | 9 +++++++++
> > drivers/net/mlx5/mlx5.h | 1 +
> > drivers/net/mlx5/mlx5_flow_dv.c | 26 ++++++++++++++++----------
> > drivers/net/mlx5/mlx5_glue.c | 12 ++++++++++++
> > drivers/net/mlx5/mlx5_glue.h | 1 +
> > 5 files changed, 39 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> > index 938ba1c..e3c6d24 100644
> > --- a/drivers/net/mlx5/mlx5.c
> > +++ b/drivers/net/mlx5/mlx5.c
> > @@ -357,6 +357,7 @@ struct mlx5_dev_spawn_data {
> > goto error;
> > }
> > sh->fdb_ns =3D ns;
> > + sh->drop_action =3D mlx5_glue->dr_create_flow_action_drop();
> > }
> > #endif
> > sh->dv_refcnt++;
> > @@ -377,6 +378,10 @@ struct mlx5_dev_spawn_data {
> > mlx5_glue->dr_destroy_ns(sh->fdb_ns);
> > sh->fdb_ns =3D NULL;
> > }
> > + if (sh->drop_action) {
> > + mlx5_glue->destroy_flow_action(sh->drop_action);
> > + sh->drop_action =3D NULL;
> > + }
> > return err;
> > #else
> > (void)priv;
> > @@ -417,6 +422,10 @@ struct mlx5_dev_spawn_data {
> > mlx5_glue->dr_destroy_ns(sh->fdb_ns);
> > sh->fdb_ns =3D NULL;
> > }
> > + if (sh->drop_action) {
> > + mlx5_glue->destroy_flow_action(sh->drop_action);
> > + sh->drop_action =3D NULL;
> > + }
> > #endif
> > pthread_mutex_destroy(&sh->dv_mutex);
> > #else
> > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> > index 016984d..fd85b9d 100644
> > --- a/drivers/net/mlx5/mlx5.h
> > +++ b/drivers/net/mlx5/mlx5.h
> > @@ -275,6 +275,7 @@ struct mlx5_ibv_shared {
> > /* RX Direct Rules tables. */
> > void *tx_ns; /* TX Direct Rules name space handle. */
> > struct mlx5_flow_tbl_resource tx_tbl[MLX5_MAX_TABLES];
> > + void *drop_action; /* Pointer to drop action. */
>=20
> Better to mention esw here?
> E.g. esw_drop_action.
>=20
Sure.
> > /* TX Direct Rules tables/ */
> > LIST_HEAD(matchers, mlx5_flow_dv_matcher) matchers;
> > LIST_HEAD(encap_decap, mlx5_flow_dv_encap_decap_resource)
> encaps_decaps;
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> > index d4dc439..4a8e894 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -4062,6 +4062,7 @@ struct field_modify_info modify_tcp[] =3D {
> > {
> > struct mlx5_flow_dv *dv;
> > struct mlx5_flow *dev_flow;
> > + struct mlx5_priv *priv =3D dev->data->dev_private;
> > int n;
> > int err;
> >
> > @@ -4069,17 +4070,22 @@ struct field_modify_info modify_tcp[] =3D {
> > dv =3D &dev_flow->dv;
> > n =3D dv->actions_n;
> > if (flow->actions & MLX5_FLOW_ACTION_DROP) {
> > - dv->hrxq =3D mlx5_hrxq_drop_new(dev);
> > - if (!dv->hrxq) {
> > - rte_flow_error_set
> > - (error, errno,
> > -
> RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
> > - "cannot get drop hash queue");
> > - goto error;
> > + if (flow->transfer)
> > + dv->actions[n++] =3D priv->sh->drop_action;
> > + else {
> > + dv->hrxq =3D mlx5_hrxq_drop_new(dev);
> > + if (!dv->hrxq) {
> > + rte_flow_error_set
> > + (error, errno,
> > +
> RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
> > + NULL,
> > + "cannot get drop hash
> queue");
> > + goto error;
> > + }
> > + dv->actions[n++] =3D
> > + mlx5_glue-
> >dv_create_flow_action_dest_ibv_qp
> > + (dv->hrxq->qp);
> > }
> > - dv->actions[n++] =3D
> > - mlx5_glue-
> >dv_create_flow_action_dest_ibv_qp
> > - (dv->hrxq->qp);
>=20
> This seems to be conflicting to your previous fix, which is:
> "net/mlx5: fix release of jump to queue action"
>=20
> Please rebase.
>=20
Sure.
> Thanks,
> Yongseok
>=20
> > } else if (flow->actions &
> > (MLX5_FLOW_ACTION_QUEUE |
> MLX5_FLOW_ACTION_RSS)) {
> > struct mlx5_hrxq *hrxq;
> > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.=
c
> > index 117190f..b32cd09c 100644
> > --- a/drivers/net/mlx5/mlx5_glue.c
> > +++ b/drivers/net/mlx5/mlx5_glue.c
> > @@ -394,6 +394,16 @@
> > }
> >
> > static void *
> > +mlx5_glue_dr_create_flow_action_drop(void)
> > +{
> > +#ifdef HAVE_MLX5DV_DR_ESWITCH
> > + return mlx5dv_dr_create_action_drop();
> > +#else
> > + return NULL;
> > +#endif
> > +}
> > +
> > +static void *
> > mlx5_glue_dr_create_flow_tbl(void *ns, uint32_t level)
> > {
> > #ifdef HAVE_MLX5DV_DR
> > @@ -861,6 +871,8 @@
> > mlx5_glue_dr_create_flow_action_dest_flow_tbl,
> > .dr_create_flow_action_dest_vport =3D
> > mlx5_glue_dr_create_flow_action_dest_vport,
> > + .dr_create_flow_action_drop =3D
> > + mlx5_glue_dr_create_flow_action_drop,
> > .dr_create_flow_tbl =3D mlx5_glue_dr_create_flow_tbl,
> > .dr_destroy_flow_tbl =3D mlx5_glue_dr_destroy_flow_tbl,
> > .dr_create_ns =3D mlx5_glue_dr_create_ns,
> > diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.=
h
> > index 26f5cb3..1d06583 100644
> > --- a/drivers/net/mlx5/mlx5_glue.h
> > +++ b/drivers/net/mlx5/mlx5_glue.h
> > @@ -147,6 +147,7 @@ struct mlx5_glue {
> > struct ibv_cq *(*cq_ex_to_cq)(struct ibv_cq_ex *cq);
> > void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl);
> > void *(*dr_create_flow_action_dest_vport)(void *ns, uint32_t vport);
> > + void *(*dr_create_flow_action_drop)();
> > void *(*dr_create_flow_tbl)(void *ns, uint32_t level);
> > int (*dr_destroy_flow_tbl)(void *tbl);
> > void *(*dr_create_ns)(struct ibv_context *ctx,
> > --
> > 1.8.3.1
> >
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id DD4F0A00E6
for <public@inbox.dpdk.org>; Thu, 18 Apr 2019 07:15:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9A1F91B91E;
Thu, 18 Apr 2019 07:15:43 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
(mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62])
by dpdk.org (Postfix) with ESMTP id 3C5E71B889
for <dev@dpdk.org>; Thu, 18 Apr 2019 07:15:41 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=eWVh+xSpXZ9HmYhNWX2c9FYoaXlFaa/HR0O9CRFQrhA=;
b=Wdws56LmzvlWAImohWUgouXLu2HXhAg94ywyN2LRT+1vSlUpaECUYrmkNcs4R9SKOrlbFT27UOO7SRguoCeZKL8eNOjQHgq09ZPtfrfPaT6zSgNngfeqwxUD/pLIK+/w1/WR+PKDIFSDfPA7Ibe4jRIXuZnwzqUWYpXsGRevQZc=
Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by
AM4PR05MB3298.eurprd05.prod.outlook.com (10.171.187.155) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1813.12; Thu, 18 Apr 2019 05:15:40 +0000
Received: from AM4PR05MB3425.eurprd05.prod.outlook.com
([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com
([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019
05:15:40 +0000
From: Ori Kam <orika@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
CC: Shahaf Shuler <shahafs@mellanox.com>, Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>, Moti Haimovsky
<motih@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch
Thread-Index: AQHU8wbp7Zd1uBBuNUC2THS4K2DfD6ZBJfAAgAA/KeA=
Date: Thu, 18 Apr 2019 05:15:40 +0000
Message-ID:
<AM4PR05MB3425983C290EA7E00CE13B61DB260@AM4PR05MB3425.eurprd05.prod.outlook.com>
References: <1555276357-4892-1-git-send-email-orika@mellanox.com>
<1555276357-4892-10-git-send-email-orika@mellanox.com>
<20190418012807.GF31179@mtidpdk.mti.labs.mlnx>
In-Reply-To: <20190418012807.GF31179@mtidpdk.mti.labs.mlnx>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=orika@mellanox.com;
x-originating-ip: [185.175.35.255]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b05cca1f-cc7a-4ced-34d6-08d6c3bce62f
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);
SRVR:AM4PR05MB3298;
x-ms-traffictypediagnostic: AM4PR05MB3298:
x-microsoft-antispam-prvs: <AM4PR05MB32984A32D5FA0FA6E4A7BD9EDB260@AM4PR05MB3298.eurprd05.prod.outlook.com>
x-forefront-prvs: 0011612A55
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(39860400002)(366004)(136003)(376002)(346002)(396003)(189003)(199004)(13464003)(7736002)(4326008)(86362001)(33656002)(76176011)(68736007)(102836004)(6862004)(8936002)(55016002)(53546011)(6506007)(486006)(446003)(229853002)(7696005)(6246003)(6436002)(305945005)(2906002)(11346002)(66066001)(9686003)(81156014)(81166006)(74316002)(26005)(186003)(3846002)(6116002)(53936002)(8676002)(476003)(478600001)(97736004)(256004)(71200400001)(71190400001)(54906003)(5660300002)(6636002)(316002)(52536014)(25786009)(14454004)(99286004)(7756004);
DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3298;
H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: e1ThnBUTDhXkTYn2t+XPnDKpUHWbLwqrAPGU9sS/auB3ZPrO6/lQ2dF224M3mQLLGO/ECAzpb5ypSAWQk+80wgNwSSMsRtRoRZEXtHmJVWmyW7Ug5/TbBz7BQsjyZLyoF94PdhTReG7EUSQjrNj4by6yR6Nnp0YhAn/kAJHgvtpfTi5g5XlNMGP7feBm+qckIuiB73DX7d2IuEOInQGdYrYhdOgFogmbj2k1gJJBF97Y5NmGswsise4ZjV/zL8Vp0LheTU4sohU9fOArP414riGc7D7pn5JHbD3pkPJYg9WbqZ4+XHDnP4ul4R+nKKPfXYtKVRtau0I0qLfb4jklu3BAzMY0salsno5C1x4XxocOaCY5DpUpllA6yTttYlmh8OhUmzZlGpXilsyF41V4pttx1sMDRwIPqy3SE4We8aM=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b05cca1f-cc7a-4ced-34d6-08d6c3bce62f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 05:15:40.1234 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3298
Subject: Re: [dpdk-dev] [PATCH 9/9] net/mlx5: add drop action to Direct
Verbs E-Switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190418051540.LILZklRmmmGz_k2-QmXh1EcsKQ132BbiLxVKKswLGVw@z>
Hi Yongseok,
PSB=20
> -----Original Message-----
> From: Yongseok Koh
> Sent: Thursday, April 18, 2019 4:28 AM
> To: Ori Kam <orika@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>; Moti
> Haimovsky <motih@mellanox.com>; dev@dpdk.org
> Subject: Re: [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Swit=
ch
>=20
> On Sun, Apr 14, 2019 at 09:12:37PM +0000, Ori Kam wrote:
> > This commit adds support for drop action when creating E-Switch flow
> > using DV.
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5.c | 9 +++++++++
> > drivers/net/mlx5/mlx5.h | 1 +
> > drivers/net/mlx5/mlx5_flow_dv.c | 26 ++++++++++++++++----------
> > drivers/net/mlx5/mlx5_glue.c | 12 ++++++++++++
> > drivers/net/mlx5/mlx5_glue.h | 1 +
> > 5 files changed, 39 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> > index 938ba1c..e3c6d24 100644
> > --- a/drivers/net/mlx5/mlx5.c
> > +++ b/drivers/net/mlx5/mlx5.c
> > @@ -357,6 +357,7 @@ struct mlx5_dev_spawn_data {
> > goto error;
> > }
> > sh->fdb_ns =3D ns;
> > + sh->drop_action =3D mlx5_glue->dr_create_flow_action_drop();
> > }
> > #endif
> > sh->dv_refcnt++;
> > @@ -377,6 +378,10 @@ struct mlx5_dev_spawn_data {
> > mlx5_glue->dr_destroy_ns(sh->fdb_ns);
> > sh->fdb_ns =3D NULL;
> > }
> > + if (sh->drop_action) {
> > + mlx5_glue->destroy_flow_action(sh->drop_action);
> > + sh->drop_action =3D NULL;
> > + }
> > return err;
> > #else
> > (void)priv;
> > @@ -417,6 +422,10 @@ struct mlx5_dev_spawn_data {
> > mlx5_glue->dr_destroy_ns(sh->fdb_ns);
> > sh->fdb_ns =3D NULL;
> > }
> > + if (sh->drop_action) {
> > + mlx5_glue->destroy_flow_action(sh->drop_action);
> > + sh->drop_action =3D NULL;
> > + }
> > #endif
> > pthread_mutex_destroy(&sh->dv_mutex);
> > #else
> > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> > index 016984d..fd85b9d 100644
> > --- a/drivers/net/mlx5/mlx5.h
> > +++ b/drivers/net/mlx5/mlx5.h
> > @@ -275,6 +275,7 @@ struct mlx5_ibv_shared {
> > /* RX Direct Rules tables. */
> > void *tx_ns; /* TX Direct Rules name space handle. */
> > struct mlx5_flow_tbl_resource tx_tbl[MLX5_MAX_TABLES];
> > + void *drop_action; /* Pointer to drop action. */
>=20
> Better to mention esw here?
> E.g. esw_drop_action.
>=20
Sure.
> > /* TX Direct Rules tables/ */
> > LIST_HEAD(matchers, mlx5_flow_dv_matcher) matchers;
> > LIST_HEAD(encap_decap, mlx5_flow_dv_encap_decap_resource)
> encaps_decaps;
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> > index d4dc439..4a8e894 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -4062,6 +4062,7 @@ struct field_modify_info modify_tcp[] =3D {
> > {
> > struct mlx5_flow_dv *dv;
> > struct mlx5_flow *dev_flow;
> > + struct mlx5_priv *priv =3D dev->data->dev_private;
> > int n;
> > int err;
> >
> > @@ -4069,17 +4070,22 @@ struct field_modify_info modify_tcp[] =3D {
> > dv =3D &dev_flow->dv;
> > n =3D dv->actions_n;
> > if (flow->actions & MLX5_FLOW_ACTION_DROP) {
> > - dv->hrxq =3D mlx5_hrxq_drop_new(dev);
> > - if (!dv->hrxq) {
> > - rte_flow_error_set
> > - (error, errno,
> > -
> RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
> > - "cannot get drop hash queue");
> > - goto error;
> > + if (flow->transfer)
> > + dv->actions[n++] =3D priv->sh->drop_action;
> > + else {
> > + dv->hrxq =3D mlx5_hrxq_drop_new(dev);
> > + if (!dv->hrxq) {
> > + rte_flow_error_set
> > + (error, errno,
> > +
> RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
> > + NULL,
> > + "cannot get drop hash
> queue");
> > + goto error;
> > + }
> > + dv->actions[n++] =3D
> > + mlx5_glue-
> >dv_create_flow_action_dest_ibv_qp
> > + (dv->hrxq->qp);
> > }
> > - dv->actions[n++] =3D
> > - mlx5_glue-
> >dv_create_flow_action_dest_ibv_qp
> > - (dv->hrxq->qp);
>=20
> This seems to be conflicting to your previous fix, which is:
> "net/mlx5: fix release of jump to queue action"
>=20
> Please rebase.
>=20
Sure.
> Thanks,
> Yongseok
>=20
> > } else if (flow->actions &
> > (MLX5_FLOW_ACTION_QUEUE |
> MLX5_FLOW_ACTION_RSS)) {
> > struct mlx5_hrxq *hrxq;
> > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.=
c
> > index 117190f..b32cd09c 100644
> > --- a/drivers/net/mlx5/mlx5_glue.c
> > +++ b/drivers/net/mlx5/mlx5_glue.c
> > @@ -394,6 +394,16 @@
> > }
> >
> > static void *
> > +mlx5_glue_dr_create_flow_action_drop(void)
> > +{
> > +#ifdef HAVE_MLX5DV_DR_ESWITCH
> > + return mlx5dv_dr_create_action_drop();
> > +#else
> > + return NULL;
> > +#endif
> > +}
> > +
> > +static void *
> > mlx5_glue_dr_create_flow_tbl(void *ns, uint32_t level)
> > {
> > #ifdef HAVE_MLX5DV_DR
> > @@ -861,6 +871,8 @@
> > mlx5_glue_dr_create_flow_action_dest_flow_tbl,
> > .dr_create_flow_action_dest_vport =3D
> > mlx5_glue_dr_create_flow_action_dest_vport,
> > + .dr_create_flow_action_drop =3D
> > + mlx5_glue_dr_create_flow_action_drop,
> > .dr_create_flow_tbl =3D mlx5_glue_dr_create_flow_tbl,
> > .dr_destroy_flow_tbl =3D mlx5_glue_dr_destroy_flow_tbl,
> > .dr_create_ns =3D mlx5_glue_dr_create_ns,
> > diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.=
h
> > index 26f5cb3..1d06583 100644
> > --- a/drivers/net/mlx5/mlx5_glue.h
> > +++ b/drivers/net/mlx5/mlx5_glue.h
> > @@ -147,6 +147,7 @@ struct mlx5_glue {
> > struct ibv_cq *(*cq_ex_to_cq)(struct ibv_cq_ex *cq);
> > void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl);
> > void *(*dr_create_flow_action_dest_vport)(void *ns, uint32_t vport);
> > + void *(*dr_create_flow_action_drop)();
> > void *(*dr_create_flow_tbl)(void *ns, uint32_t level);
> > int (*dr_destroy_flow_tbl)(void *tbl);
> > void *(*dr_create_ns)(struct ibv_context *ctx,
> > --
> > 1.8.3.1
> >