DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: simei <simei.su@intel.com>,
	"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
	 "jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC,v3] ethdev: extend RSS offload types
Date: Tue, 30 Jul 2019 06:06:56 +0000	[thread overview]
Message-ID: <AM4PR05MB34259F373A478955408A7B83DBDC0@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1564368251-112891-1-git-send-email-simei.su@intel.com>

Hi Simei,



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of simei
> Sent: Monday, July 29, 2019 5:44 AM
> To: qi.z.zhang@intel.com; jingjing.wu@intel.com; ferruh.yigit@intel.com;
> Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Cc: dev@dpdk.org; simei.su@intel.com
> Subject: [dpdk-dev] [RFC,v3] ethdev: extend RSS offload types
> 
> From: Simei Su <simei.su@intel.com>
> 
> Make it easier to represent to define macro values as (1ULL << ###).
> 
> This RFC reserves several bits as input set selection from bottom
> of the 64 bits. The flow type is combined with input set to
> represent rss types.
> 


Why reserve from the bottom? and not from the first available space?

> for example:
>     ETH_RSS_IPV4 | ETH_RSS_INSET_L3_SRC: hash on src ip address only
>     ETH_RSS_IPV4_UDP | ETH_RSS_INSET_L4_DST: hash on src/dst IP and
> 				            dst UDP port
>     ETH_RSS_L2_PAYLOAD | ETH_RSS_INSET_L2_DST: hash on dst mac address
> 

What happens when the user set ETH_RSS_IPV4? From what I understand from your RFC this will do nothing
since no bits where enabled, am I correct? 
If I'm correct this may break applications.

> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
>  lib/librte_ethdev/rte_ethdev.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index dc6596b..8af6355 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -508,6 +508,19 @@ struct rte_eth_rss_conf {
>  #define ETH_RSS_GENEVE             (1ULL << RTE_ETH_FLOW_GENEVE)
>  #define ETH_RSS_NVGRE              (1ULL << RTE_ETH_FLOW_NVGRE)
> 
> +/*
> + * The following six macros are used combined with ETH_RSS_* to
> + * represent rss types. The structure rte_flow_action_rss.types is
> + * 64-bit wide and we reserve couple bits here for input set selection
> + * from bottom of the 64 bits.
> + */
> +#define	ETH_RSS_INSET_L2_SRC       (1ULL << 63)
> +#define	ETH_RSS_INSET_L2_DST       (1ULL << 62)
> +#define	ETH_RSS_INSET_L3_SRC       (1ULL << 61)
> +#define	ETH_RSS_INSET_L3_DST       (1ULL << 60)
> +#define	ETH_RSS_INSET_L4_SRC       (1ULL << 59)
> +#define	ETH_RSS_INSET_L4_DST       (1ULL << 58)
> +
>  #define ETH_RSS_IP ( \
>  	ETH_RSS_IPV4 | \
>  	ETH_RSS_FRAG_IPV4 | \
> --
> 1.8.3.1

Thanks,
Ori Kam

  reply	other threads:[~2019-07-30  6:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 11:37 [dpdk-dev] [RFC] " simei
2019-07-26  0:35 ` [dpdk-dev] [RFC,v2] " simei
2019-07-26 10:21   ` Ferruh Yigit
2019-07-29  2:44   ` [dpdk-dev] [RFC,v3] " simei
2019-07-30  6:06     ` Ori Kam [this message]
2019-07-30  7:42       ` Adrien Mazarguil
2019-08-01  4:54     ` [dpdk-dev] [RFC,v4] " simei
2019-07-29 15:30   ` [dpdk-dev] [RFC,v2] " Stephen Hemminger
2019-07-30 15:50   ` Stephen Hemminger
2019-07-31  2:57     ` Su, Simei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB34259F373A478955408A7B83DBDC0@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).