From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20069.outbound.protection.outlook.com [40.107.2.69]) by dpdk.org (Postfix) with ESMTP id 4222A5F1D; Thu, 12 Jul 2018 07:17:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxUH0Tc67rsP4A8VULkTj0EQwfgpKjjYZJZAgpOu8KU=; b=O9IAaFWI8f4WISwLdTfXH0dJhGlyrQOGHWY/KGQcKgb4tDn+NtpbdPATsCWzzN6v7EWuwXzPUjt73CbQL+wGJnWErmBuFvSB1MnK+cD84qhF540Cfc5fAW1W6kYSHPPHDz3Ip3JUp4095ezrhVfngebxX+vyNLOL2ye7hS+SSDE= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3410.eurprd05.prod.outlook.com (10.171.187.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Thu, 12 Jul 2018 05:17:04 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::40df:8a0e:9661:6cf1%3]) with mapi id 15.20.0930.022; Thu, 12 Jul 2018 05:17:04 +0000 From: Ori Kam To: Rosen Xu , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "stable@dpdk.org" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUGYWFrol0AnxAPk+9mPXqGNnztqSLC2AA Date: Thu, 12 Jul 2018 05:17:04 +0000 Message-ID: References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3410; 7:l+msCCmkcahbfcJhIRDGeLU3vKE3WcukREczh87DQUMozngLdJ/0SbagpYBPqFz0gM7+0DEjInwjXU8HBh2l5bzhesWGQCRCa63zv0a2eeA58HXlcl2Bex0pvVyQLRMtI01XfFKyQf8WSWh2tCFxAYTCUtj86/rAUUf9QA5XDNZRIKu4u5xF9Jy+YQtDqYwpbUlcMZyMLU/Si508qk22p8zh3+RpcBom9D3Hz+035snjt+5PUsUYbhWbBMopMxJX x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 91138b66-5946-4770-e746-08d5e7b6b4e8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3410; x-ms-traffictypediagnostic: AM4PR05MB3410: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM4PR05MB3410; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3410; x-forefront-prvs: 0731AA2DE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39860400002)(136003)(366004)(199004)(189003)(13464003)(53546011)(8936002)(6116002)(102836004)(6246003)(3846002)(7696005)(76176011)(6506007)(33656002)(7736002)(107886003)(74316002)(81156014)(66066001)(53936002)(110136005)(316002)(25786009)(97736004)(186003)(14454004)(54906003)(81166006)(305945005)(5660300001)(106356001)(26005)(2906002)(478600001)(105586002)(5250100002)(256004)(2900100001)(4326008)(99286004)(11346002)(229853002)(2501003)(9686003)(446003)(55016002)(6436002)(86362001)(476003)(68736007)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3410; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZUptujGrQqeanEcs/+JNmpesd+ydBjCGI1D70d20DXNOwqSLjDG1j3fGqyrxJem4S8ZqY1pqTys2a4ACmksVhEqQjG5vRtPvjiWOZjrI5Wc4GOJoUOpmK3rQ89sy4VmeK9J06NZohJFCMIlGecbGqs8NaESxcvfz/RID9fnLHgL+64nPXbDMeLwNX+ygMFsr5zcS9z0v8zoHjU1uTviRtBCC8ITgnDiZfp/Iyiz2Ztjoa6oNcwMa4OvdsdxF/0MOvJ1MTQ9/GEGgtmJWbsIjhCY5x8m1KYD4lhhpsgHsPRRwgHu4zM29NtZa1JNAGw1dthcIt6iUd23Ht8ww1sRUcVG329AbIqc8+tMCfmQUubA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91138b66-5946-4770-e746-08d5e7b6b4e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2018 05:17:04.6558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3410 Subject: Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 05:17:06 -0000 Hi Rosen, Why do the fdir_conf must be initialized? What is the issue you are seeing? Best, Ori > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > Sent: Thursday, July 12, 2018 5:10 AM > To: dev@dpdk.org > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf > initialization >=20 > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. >=20 > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow > API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rosen Xu > --- > examples/flow_filtering/main.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/mai= n.c > index f595034..aa03e23 100644 > --- a/examples/flow_filtering/main.c > +++ b/examples/flow_filtering/main.c > @@ -132,6 +132,12 @@ > DEV_TX_OFFLOAD_SCTP_CKSUM | > DEV_TX_OFFLOAD_TCP_TSO, > }, > + .fdir_conf =3D { > + .mode =3D RTE_FDIR_MODE_PERFECT, > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > + .status =3D RTE_FDIR_REPORT_STATUS, > + .drop_queue =3D 127, > + }, > }; > struct rte_eth_txconf txq_conf; > struct rte_eth_rxconf rxq_conf; > -- > 1.8.3.1