From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by dpdk.org (Postfix) with ESMTP id 3271A5B16 for ; Tue, 9 Oct 2018 09:45:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ja/zyrV5DQ6M827/X/YEM8uZc+EwurYt295n497ufrs=; b=dBzGqqlF7wKC9Jjs9yQvD+5Gi4vmGSc+5I3QUiLks+0cHTffIZloVJVrv40NqqxKuFpRmXL9PO0NXc+ASikToon50t83qGGFhTm28Pgh/fpzLvV0XaegzUPQhwmigddoTLbVILrDDmUhgaAA0Dal6bMOjHSuxDIsZtVymOSDxGU= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3315.eurprd05.prod.outlook.com (10.171.187.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.28; Tue, 9 Oct 2018 07:45:41 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::fdeb:3890:f0f0:2202%4]) with mapi id 15.20.1207.024; Tue, 9 Oct 2018 07:45:41 +0000 From: Ori Kam To: Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH 1/7] net/mlx5: fix wrong flow action macro usage Thread-Index: AQHUXzEIqAkNL04+1UqcScsq6jzJCKUWiYyw Date: Tue, 9 Oct 2018 07:45:41 +0000 Message-ID: References: <20181008180150.39273-1-yskoh@mellanox.com> <20181008180150.39273-2-yskoh@mellanox.com> In-Reply-To: <20181008180150.39273-2-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3315; 6:n0ZNA+lmyqHEcubqzhUlbL5ReGg6FhSAcqASFpKkyr1NPewDmEqzEAN6LTQdfrOlkY67kg0D/o2cSK7BkTb7hwEjR0rop1nLpBt3An+uCSBpdvrGg2fR3sD/Af72d+X5YwNKV8Kz4DWzNiiPLeK5XmkMcjX0L4m14AkIbQkoN3VyoEr4AOk74egt5W8Xj8yAmByqhQHu4Az3hRgdO/uvX96RNjSblpRxltJog1VbdUnomx5/NKVFHwbcmdnPVwZNknXQT4hzBC6HrY+gds0B/JA1Vd+eh0Jpt4KM60pL0V1x/ut0wr0pKh15K6bNsH+Cr4AdmAiv/AD6VfzN025WOBdHv3hF3WLxnAlUcwoYeJxvd56jenHmUgAhUt6P3YYU+5PyePQegNwOuZr4meVyOffTOKbF2597/mI0Pv/EEvRKGKzG5WsJNUXosgpGCeipD+AVmo3BwSE05/bwosypWw==; 5:W/RBjXn4f8jFiirt7CAFdzAKSgUTMabmTfNHNIKLMLsw8epXvXt/Amp+eKGclVc/4dxGMSZfmxPURdxIvst7cW8tMTaH/vOdQ4WQxR0azfcDdGBHVvutnM4S2uS+PABdTWHcF4HsXMtd8WhSJwd+5aAtdhpFxezjxqIsMhevMdA=; 7:R3134Hc1YZpY8lBcvDox4aawpzQF4JjXfJKlmD9rttC5Ae2vOHWiWkNm+QRHVbS0p/sykZL2rpOKoLzJQUrJjFCl5iwq+lsrp+KVAZeaIf/1OX7MA9T9yQOtPshxI2Wz8lHD5xhcAJ6WU+PG4JHmmrw13/CBpJI9B9WjdJ41f9LDj7HvsGxhFConwaifGYo8IAOVeM75hcdJOmjzU5/KZi9DQmGg6A0IgMBLFPU1/WbW1laV83CQ1gO/BhFwatpG x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2d80478c-9d16-4db9-6be0-08d62dbb3698 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3315; x-ms-traffictypediagnostic: AM4PR05MB3315: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051); SRVR:AM4PR05MB3315; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3315; x-forefront-prvs: 08200063E9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(396003)(346002)(39860400002)(376002)(13464003)(189003)(199004)(6506007)(53546011)(7696005)(81156014)(4326008)(76176011)(5660300001)(99286004)(316002)(33656002)(25786009)(71200400001)(71190400001)(6246003)(107886003)(86362001)(7736002)(305945005)(74316002)(8936002)(105586002)(102836004)(106356001)(81166006)(66066001)(256004)(8676002)(6636002)(97736004)(55016002)(5250100002)(2900100001)(6436002)(53936002)(9686003)(476003)(446003)(11346002)(486006)(229853002)(14454004)(186003)(478600001)(2906002)(68736007)(54906003)(110136005)(6116002)(3846002)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3315; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: wkjwSDs0W3LrEaQI5/GuAiWsT3EWW51tBiahqHSqQEcfUscxUiPZ7ZPdmZrITndPq417jy+Na4O4fpGJCDwuepQdwl0eG7yVDhhtIYxXF1pTZORYarIks3vILRIORB4nmmdrikExD0arrxxdh3ab6VJMuxuEpjORu+TVBVcF/PduJTQNtmk8bdAcOf8eiSAXYF5ZbBB+drriReqY3e2uR4Lparg6//akH4w3y50Mg/d7ai0/5lwW3v3tETnsvp/F6P7IVfq5KLyjPkuZIYkYh709LoK2yxmvBctPZZEAW/Ve4nwEBJdmKVv6Izd9Rt2OqKeYTCMKzQAoFu2/s4/ZBs4X9K3nCgS+UuZHeCI8EPc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d80478c-9d16-4db9-6be0-08d62dbb3698 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2018 07:45:41.6346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3315 Subject: Re: [dpdk-dev] [PATCH 1/7] net/mlx5: fix wrong flow action macro usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 07:45:44 -0000 > -----Original Message----- > From: Yongseok Koh > Sent: Monday, October 8, 2018 9:02 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 1/7] net/mlx5: fix wrong flow action macro usage >=20 > Fixes: 5c83c536783c ("net/mlx5: add Direct Verbs final functions") > Cc: Ori Kam >=20 > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_flow.h | 10 ---------- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 2 files changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index a91f9911d..79d4a2619 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -65,16 +65,6 @@ > (MLX5_FLOW_LAYER_INNER_L2 | MLX5_FLOW_LAYER_INNER_L3 | \ > MLX5_FLOW_LAYER_INNER_L4) >=20 > -/* Actions that modify the fate of matching traffic. */ > -#define MLX5_FLOW_FATE_DROP (1u << 0) > -#define MLX5_FLOW_FATE_QUEUE (1u << 1) > -#define MLX5_FLOW_FATE_RSS (1u << 2) > - > -/* Modify a packet. */ > -#define MLX5_FLOW_MOD_FLAG (1u << 0) > -#define MLX5_FLOW_MOD_MARK (1u << 1) > -#define MLX5_FLOW_MOD_COUNT (1u << 2) > - > /* Actions */ > #define MLX5_ACTION_DROP (1u << 0) > #define MLX5_ACTION_QUEUE (1u << 1) > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 7d325320a..5678dc35f 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1251,7 +1251,7 @@ flow_dv_apply(struct rte_eth_dev *dev, struct > rte_flow *flow, > LIST_FOREACH(dev_flow, &flow->dev_flows, next) { > struct mlx5_flow_dv *dv =3D &dev_flow->dv; > if (dv->hrxq) { > - if (flow->actions & MLX5_FLOW_FATE_DROP) > + if (flow->actions & MLX5_ACTION_DROP) > mlx5_hrxq_drop_release(dev); > else > mlx5_hrxq_release(dev, dv->hrxq); > -- > 2.11.0 Acked-by: Ori Kam Thanks, Ori Kam