From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82C9BA00C4; Thu, 31 Oct 2019 14:33:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C9071C23D; Thu, 31 Oct 2019 14:33:49 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by dpdk.org (Postfix) with ESMTP id 27CA61C23C for ; Thu, 31 Oct 2019 14:33:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcTe2TrZKWNuiAR+J9Y/K+Mw2U6rpJJ9VOa4J3pvC3Yk75i8R6hWIlNDYD/RXJDYD0hnjjvwx6ocPHSvPNZ6Sc5QW5DcJFjyOF8LI/BC2L5Lkk4Zz6SK5bKI9OAbcPHEH2LgbcRKKqvRuMrh7PzpoFTIqcdvTZHivz7fBm+Zu0tyYaUCmNXjJ15wE1TYivpvablsG9i+vjo1Z1qXrM+rS8sjOIFYv4lxxvBTeY4L07CZwoD14JzLEfVy6WTIFmylNpDmA8qYTd8Klhp7ZXpC72s7InH+DP8gK7PNlcfkMrxKfXrG2s2XmZ/T5FM/c9YFpdL9QUVNBnEnSqVkGXC5/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9z8itjQceR/qXLYJ+5d5uup16eD/WwPWWcAmP/H7jZw=; b=TOitRBgyNcwmz4djbYQQVyPU0mY2dLWAkmPJo+tXHWXx96LNzyFP4qcJs2/x1o67mN0Xv3Ftk8D1ao3r9eMWTJ5aNs82KxFYndcyekzldWGtt80Jc+cceHHfVY3JjE/q31H1yIf4E8DnlyAGBStxB27yTskYbvzJ3qfDQO5jlUy1VczS9By5GFw/DluAPu0oMOGy7SJYqshCBLi/u7oC5Tc9rFqnXVHnBLZToX3/sSXiTa+Ctt6IEXWeAdv5rIW7DbQqimKHplPwSw2ouPBN+rvk7HRT1sLR8aVyePkIi2VIlUco3sLKgaZLxoUXV/cQpVBpQUsUV78ly6YwY1GjGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9z8itjQceR/qXLYJ+5d5uup16eD/WwPWWcAmP/H7jZw=; b=A81VeEyaDpKiG3r06pNqbrvzEDm9Yx5dCDryUM1SEw8KYIHS16SQsVA7i2VG8qX0vLq+BQ5icUcYWuAc+F3uuVknfmbj3VRFaUmqJhGtNf6SncetrKaKP6SHdW38tpCh/OAug7ox7GDDAyl/NRKN5O1Dtk9Ud0BRldIUlD9GROk= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3393.eurprd05.prod.outlook.com (10.171.189.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Thu, 31 Oct 2019 13:33:45 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::70a7:a312:cbc6:d178]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::70a7:a312:cbc6:d178%7]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 13:33:45 +0000 From: Ori Kam To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Thomas Monjalon , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field Thread-Index: AQHVj+vy4iGiTnNGM0KO6Ube7EP3MKd0v6Ew Date: Thu, 31 Oct 2019 13:33:45 +0000 Message-ID: References: <1572455548-23420-2-git-send-email-viacheslavo@mellanox.com> <1572527121-13133-1-git-send-email-viacheslavo@mellanox.com> <1572527121-13133-3-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1572527121-13133-3-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5441c2b4-6f6f-43dd-d0c3-08d75e06f444 x-ms-traffictypediagnostic: AM4PR05MB3393:|AM4PR05MB3393: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(13464003)(189003)(199004)(45080400002)(498600001)(305945005)(7736002)(2906002)(476003)(52536014)(5660300002)(11346002)(53546011)(446003)(3846002)(486006)(14454004)(81166006)(102836004)(26005)(8936002)(76116006)(966005)(66556008)(66946007)(64756008)(66446008)(81156014)(6506007)(66476007)(256004)(74316002)(76176011)(71190400001)(71200400001)(186003)(6116002)(7696005)(14444005)(86362001)(33656002)(66066001)(2501003)(4326008)(25786009)(229853002)(54906003)(110136005)(6436002)(55016002)(9686003)(6306002)(6246003)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3393; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3fryvq+ucjnZAYjD81Nn3sD9f2wd4cyeyY1HpNV7GaapNodllScDiHghUdnL2GJzAbeY973CQS3iOF/mIqhSrRbmi4DhsRxcBmSsZhuirkP5suZBPh/rUEUQ4yjLdcaglAY7R3ilV7Nu/RuEEe1zLla42942UBC3l1D4S6rUUdCmsGvWjQvvTUlxCb8YUdBW9WMY0mMWRxp+9BjxCttGY4P0SUcBoeavHRUC64xPP+gas0mL9Ic8c3TaZ4ZtBdcMHOf5A2B6GmCIOMYuFAP7P6mcg1ekqVNl4ykWiIXeIK4PnTdMcCW14noiaubSp8yrWGWYIPUCm1shrSiEOHBFdInQMpHysKcDaOcsM8qqxA4jwBMg3MykQDsr3Iv8bDo16Q8P1/U3/7kL+YZR9kLI850/VBpYoNrkto0JHy1jotPNuiT5mqMWaF7YZUn4OPjldJFty45hU0Y+ljwYBJsqZbpskJzNPYJQmz42a1QOHGE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5441c2b4-6f6f-43dd-d0c3-08d75e06f444 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 13:33:45.6130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WVN2ej80djQLX7sD8z3sBE60uXy9rCXbmd6+zeIITBxqrRfjs4l4mGeRa7HmXKp2cEMYPbO55LPR9UrHP79KhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3393 Subject: Re: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Thursday, October 31, 2019 3:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > olivier.matz@6wind.com; arybchenko@solarflare.com; Ori Kam > > Subject: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynami= c > field >=20 > The dynamic mbuf fields were introduced by [1]. The egress metadata is > good candidate to be moved from statically allocated field tx_metadata to > dynamic one. Because mbufs are used in half-duplex fashion only, it is > safe to share this dynamic field with ingress metadata. >=20 > The shared dynamic field contains either egress (if application going to > transmit mbuf with tx_burst) or ingress (if mbuf is received with rx_burs= t) > metadata and can be accessed by RTE_FLOW_DYNF_METADATA() macro or > with > rte_flow_dynf_metadata_set() and rte_flow_dynf_metadata_get() helper > routines. PKT_TX_DYNF_METADATA/PKT_RX_DYNF_METADATA flag will be set > along with the data. >=20 > The mbuf dynamic field must be registered by calling > rte_flow_dynf_metadata_register() prior accessing the data. >=20 > The availability of dynamic mbuf metadata field can be checked with > rte_flow_dynf_metadata_avail() routine. >=20 > DEV_TX_OFFLOAD_MATCH_METADATA offload and configuration flag is > removed. > The metadata support in PMDs is engaged on dynamic field registration. >=20 > Metadata feature is getting complex. We might have some set of actions > and items that might be supported by PMDs in multiple combinations, > the supported values and masks are the subjects to query by perfroming > trials (with rte_flow_validate). >=20 > [1] > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatche= s.dp > dk.org%2Fpatch%2F62040%2F&data=3D02%7C01%7Corika%40mellanox.com > %7C59c1c0e65ad7436cb8f708d75e031341%7Ca652971c7d2e4d9ba6a4d14925 > 6f461b%7C0%7C0%7C637081239629362825&sdata=3DA%2Fe1hjy02uGsgK5A > ouK6pF%2BRdju5lcANP3ye3xx6qKs%3D&reserved=3D0 >=20 > Signed-off-by: Viacheslav Ovsiienko > --- >=20 > v7: - updates release notes > v6: - > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatche= s.dp > dk.org%2Fpatch%2F62244%2F&data=3D02%7C01%7Corika%40mellanox.com > %7C59c1c0e65ad7436cb8f708d75e031341%7Ca652971c7d2e4d9ba6a4d14925 > 6f461b%7C0%7C0%7C637081239629362825&sdata=3D72hW3BfXHQ0KGzNq > o3M1TR%2BI4oQdJ5sU4wYzK74rF%2FA%3D&reserved=3D0 >=20 > app/test-pmd/cmdline.c | 3 ++- > app/test-pmd/testpmd.c | 4 ---- > app/test-pmd/testpmd.h | 2 +- > app/test-pmd/util.c | 15 +++++++++------ > app/test/test_mbuf.c | 1 - > doc/guides/prog_guide/rte_flow.rst | 6 +++--- > doc/guides/rel_notes/release_19_11.rst | 5 +++++ > drivers/net/mlx5/mlx5_flow_dv.c | 19 ++++++------------- > drivers/net/mlx5/mlx5_rxtx.c | 22 +++++++++++----------- > drivers/net/mlx5/mlx5_rxtx_vec.h | 6 ------ > drivers/net/mlx5/mlx5_txq.c | 4 ---- > lib/librte_ethdev/rte_ethdev.c | 1 - > lib/librte_ethdev/rte_ethdev.h | 5 ----- > lib/librte_ethdev/rte_flow.h | 19 ++++++++++--------- > lib/librte_mbuf/rte_mbuf.c | 2 -- > lib/librte_mbuf/rte_mbuf_core.h | 19 +------------------ > 16 files changed, 48 insertions(+), 85 deletions(-) >=20 Acked-by: Ori Kam Thanks, Ori