From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60072.outbound.protection.outlook.com [40.107.6.72]) by dpdk.org (Postfix) with ESMTP id 8723E1B597 for ; Wed, 17 Apr 2019 07:18:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b50wjYnOTcw3m959zCoSSMHUaYaJ6/ZAc0qbDeD0Sv8=; b=McDCRq41fy/jFjWs+cHR40U5foRAIh0m0naIywzAUPT8fauxDvCTR1I2KND/LvaFJUv0/EpO2PvQxMFCjsZvrbD90bfPNt2d04tSzflq7r6Xj4CkVtpbLabeIPPlYMpI2fmJXJXmm9WSytZLb+xAVI7M0+ZquDtzos+CJLB18KY= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3300.eurprd05.prod.outlook.com (10.171.186.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 05:18:41 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 05:18:41 +0000 From: Ori Kam To: Yongseok Koh CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU9LVRmk/6791KVEKNpwErMD/G46Y/0IDA Date: Wed, 17 Apr 2019 05:18:41 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> In-Reply-To: <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aac5250e-9c45-4866-c642-08d6c2f427de x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3300; x-ms-traffictypediagnostic: AM4PR05MB3300: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(136003)(39860400002)(376002)(189003)(199004)(13464003)(106356001)(4326008)(102836004)(5660300002)(105586002)(6246003)(305945005)(229853002)(14454004)(6116002)(9686003)(53546011)(7696005)(478600001)(6436002)(186003)(3846002)(66066001)(93886005)(68736007)(55016002)(6636002)(52536014)(486006)(8936002)(74316002)(26005)(6506007)(316002)(54906003)(71200400001)(71190400001)(7736002)(76176011)(11346002)(99286004)(256004)(2906002)(53936002)(6862004)(446003)(25786009)(33656002)(476003)(97736004)(81166006)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3300; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P9XrLGO8ZVoY5lulZZb3szNnJGbMaKsJN1Ww2DzixaYsUNJbX8ig+I9aQWjBY0SyZ3QW0f3Sf4TqeIMwrOpQ6+PymK3B02spcC5BzolGl1kyaJAx3QezPqPDz4yuGHG3rFPaixTiu1GAdimb3Ouo+yW1nljX2/1JH5NG4isFCz7j4OwNDO40NHPy7uNpX5FlD3EhCyhpiVBIhE/Kkr3FbYIQo3lgCSJsno2W4XFeKraz3b2ZLQ3l5mErMhaKvJS5cchddPjpuB22Vl2CmfIkMzuQbaF+XvhjuorHG8UyWYx79b+hD8IRHj7RC66HJ+y5jfXbyZwHQb6Oy6BZQNw7NXOJBLYPPZQ1FzYcT+w20raRvwWtPqE1JFeNxKXwzfTgRLCSbQ5EjPjelY4pv1a0OFChKPsTQHdgYd2c9Ch/bWE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: aac5250e-9c45-4866-c642-08d6c2f427de X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 05:18:41.5103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3300 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 05:18:42 -0000 > -----Original Message----- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:34 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with > Direct Rules >=20 >=20 > > On Apr 16, 2019, at 5:01 PM, Yongseok Koh wrote: > > > > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > >> The meson build was missing the define for Direct Rules. >=20 > And a typo in the title. > menson -> meson >=20 > Also would be better to use 'meson build' instead of 'meson compilation' >=20 > "net/mlx5: fix meson build for Direct Rules" >=20 O.K. > >> > >> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > >> Cc: orika@mellanox.com > >> > >> Signed-off-by: Ori Kam > >> --- > >> drivers/net/mlx5/meson.build | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.bui= ld > >> index a4c684e..0037e15 100644 > >> --- a/drivers/net/mlx5/meson.build > >> +++ b/drivers/net/mlx5/meson.build > >> @@ -111,6 +111,8 @@ if build > >> 'mlx5dv_devx_obj_create' ], > >> [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > >> 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > >> + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > >> + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], > > > > Better to change the inconsistent naming? > > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES > > > > And I want it to be at a similar location to Makefile. Let's put it nex= t to > > HAVE_IBV_FLOW_DV_SUPPORT. > > > > thanks > > Yongseok > > > >> [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > >> 'SUPPORTED_40000baseKR4_Full' ], > >> [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > >> -- > >> 1.8.3.1 > >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6ECC9A00E6 for ; Wed, 17 Apr 2019 07:18:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 460751B5B1; Wed, 17 Apr 2019 07:18:44 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60072.outbound.protection.outlook.com [40.107.6.72]) by dpdk.org (Postfix) with ESMTP id 8723E1B597 for ; Wed, 17 Apr 2019 07:18:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b50wjYnOTcw3m959zCoSSMHUaYaJ6/ZAc0qbDeD0Sv8=; b=McDCRq41fy/jFjWs+cHR40U5foRAIh0m0naIywzAUPT8fauxDvCTR1I2KND/LvaFJUv0/EpO2PvQxMFCjsZvrbD90bfPNt2d04tSzflq7r6Xj4CkVtpbLabeIPPlYMpI2fmJXJXmm9WSytZLb+xAVI7M0+ZquDtzos+CJLB18KY= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3300.eurprd05.prod.outlook.com (10.171.186.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 05:18:41 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 05:18:41 +0000 From: Ori Kam To: Yongseok Koh CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU9LVRmk/6791KVEKNpwErMD/G46Y/0IDA Date: Wed, 17 Apr 2019 05:18:41 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> In-Reply-To: <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aac5250e-9c45-4866-c642-08d6c2f427de x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3300; x-ms-traffictypediagnostic: AM4PR05MB3300: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(136003)(39860400002)(376002)(189003)(199004)(13464003)(106356001)(4326008)(102836004)(5660300002)(105586002)(6246003)(305945005)(229853002)(14454004)(6116002)(9686003)(53546011)(7696005)(478600001)(6436002)(186003)(3846002)(66066001)(93886005)(68736007)(55016002)(6636002)(52536014)(486006)(8936002)(74316002)(26005)(6506007)(316002)(54906003)(71200400001)(71190400001)(7736002)(76176011)(11346002)(99286004)(256004)(2906002)(53936002)(6862004)(446003)(25786009)(33656002)(476003)(97736004)(81166006)(86362001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3300; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P9XrLGO8ZVoY5lulZZb3szNnJGbMaKsJN1Ww2DzixaYsUNJbX8ig+I9aQWjBY0SyZ3QW0f3Sf4TqeIMwrOpQ6+PymK3B02spcC5BzolGl1kyaJAx3QezPqPDz4yuGHG3rFPaixTiu1GAdimb3Ouo+yW1nljX2/1JH5NG4isFCz7j4OwNDO40NHPy7uNpX5FlD3EhCyhpiVBIhE/Kkr3FbYIQo3lgCSJsno2W4XFeKraz3b2ZLQ3l5mErMhaKvJS5cchddPjpuB22Vl2CmfIkMzuQbaF+XvhjuorHG8UyWYx79b+hD8IRHj7RC66HJ+y5jfXbyZwHQb6Oy6BZQNw7NXOJBLYPPZQ1FzYcT+w20raRvwWtPqE1JFeNxKXwzfTgRLCSbQ5EjPjelY4pv1a0OFChKPsTQHdgYd2c9Ch/bWE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: aac5250e-9c45-4866-c642-08d6c2f427de X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 05:18:41.5103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3300 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417051841.mMDlK_tu11oeyp60lc7Ul_Y6IlLPEEbV8AveLHTeICI@z> > -----Original Message----- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:34 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with > Direct Rules >=20 >=20 > > On Apr 16, 2019, at 5:01 PM, Yongseok Koh wrote: > > > > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > >> The meson build was missing the define for Direct Rules. >=20 > And a typo in the title. > menson -> meson >=20 > Also would be better to use 'meson build' instead of 'meson compilation' >=20 > "net/mlx5: fix meson build for Direct Rules" >=20 O.K. > >> > >> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > >> Cc: orika@mellanox.com > >> > >> Signed-off-by: Ori Kam > >> --- > >> drivers/net/mlx5/meson.build | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.bui= ld > >> index a4c684e..0037e15 100644 > >> --- a/drivers/net/mlx5/meson.build > >> +++ b/drivers/net/mlx5/meson.build > >> @@ -111,6 +111,8 @@ if build > >> 'mlx5dv_devx_obj_create' ], > >> [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > >> 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > >> + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > >> + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], > > > > Better to change the inconsistent naming? > > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES > > > > And I want it to be at a similar location to Makefile. Let's put it nex= t to > > HAVE_IBV_FLOW_DV_SUPPORT. > > > > thanks > > Yongseok > > > >> [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > >> 'SUPPORTED_40000baseKR4_Full' ], > >> [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > >> -- > >> 1.8.3.1 > >>