From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by dpdk.org (Postfix) with ESMTP id 453201B4BD for ; Wed, 9 Jan 2019 22:12:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zr8LgK7wWzRNqF+Vkq+w4cKcZd0stpJTvh6cMzB8XRg=; b=syveghHuaWOwoIwN9Ux+LPfNhs3qJCVeOj88FhKmJst4XU8swf6sIpzu6F4rUO6+AedJCPMzV2+SgAfaUbJu3zpVN5lhxFoYSfpLR1s3RhKaKFRJSuFBTtBS/FmTYcq971lMnYKrJQElVHSo5MPHh0ZL23OAtniQWo05m/6fkN4= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3217.eurprd05.prod.outlook.com (10.171.186.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Wed, 9 Jan 2019 21:12:56 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::f44e:1b2:9075:b7a9]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::f44e:1b2:9075:b7a9%4]) with mapi id 15.20.1516.010; Wed, 9 Jan 2019 21:12:56 +0000 From: Ori Kam To: Dekel Peled , Adrien Mazarguil CC: "dev@dpdk.org" , Dekel Peled , Jack Min Thread-Topic: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation Thread-Index: AQHUqBBQVbO22bbKC0mFG/8j4Fbt4aWnb86Q Date: Wed, 9 Jan 2019 21:12:56 +0000 Message-ID: References: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> <1547033879-42061-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1547033879-42061-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [141.226.122.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3217; 6:I2DBaJdcxZFP0S0wzqr0//h3s/YA9Yk9gbdappRJ1DVTCnzsSjVlmU4tYPBrUg9mSesCbTfInTg7e2dMvTxvGud4lozPD7Wk441AGjleqejJb5Z/SEKMpB/wyQY8g/i+Y2WhpKb+T32v20JmeeFn84OK6nIRtKtRTB9BBHuufkP5x3nh9dPleUz7anEeNsy/MgcJupt6MnkKmu93Gm7E0XpRYkDx4isgbqHglGvhX0JMVXMQOU303zNVVwdXdR5Rlwg9DPd7hnxZG6T6gMKnjv5dmBAGxzLXsgqzkGYGUaoMFC3a5m5xoA5nCt8U9N7s7jTVgkBs5S0WXtIgtF/M/7WpUd387HDouoz89bEzYUoL4jTiCaxzlzjgwEAoAoX9MBaNLwXFVrknScBU5T1sEkfv9csC1xc7PkvEeEz8mgV7nYD8Em5Sv6uomuqapOsDRlwLTXEHzI2hgzojyf8l1A==; 5:Xeq1JrSePy1/KDIo9VjAM+YdbFx+hz39c1cr8ZiBCKq5EmGQrdk/C3JNLfXca8qgdwPOWMPopl4BPHo1pVyFOFJlytZTVDDvlsUEnm31pLlR6xNC0FSRsgNbZS7WDZdOjPSCJozuwxDDcMko5onOd8+CdA7yJC5VkBk47ClRWj8Y8XfsIN4U9cFZ0LDOoIeMndeT+bDY3I4Y5xnM/LHKZg==; 7:XPIq/oaoPpDFcCTAO3+kh3MeX2USJlk6yDGFRZlgvk241bEzEReylfDhsqsWudllfuzNqq6FcqEqarWBF+B30zS0pSvQo5e+O1LEPnNVt5IkzI6udohA5nbzt8i3Vbok9pHQv4kd9FOptppBGCS+tQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 944e6320-b8d7-41d4-5f9f-08d676773a1c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3217; x-ms-traffictypediagnostic: AM4PR05MB3217: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(10201501046)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3217; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3217; x-forefront-prvs: 0912297777 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(136003)(346002)(366004)(189003)(199004)(13464003)(97736004)(9686003)(2906002)(33656002)(14454004)(53936002)(86362001)(256004)(7696005)(305945005)(486006)(81156014)(7736002)(81166006)(8936002)(478600001)(6436002)(229853002)(55016002)(68736007)(316002)(4326008)(110136005)(76176011)(66066001)(99286004)(53546011)(476003)(54906003)(6506007)(105586002)(106356001)(71200400001)(71190400001)(5660300001)(26005)(74316002)(186003)(102836004)(6246003)(3846002)(6116002)(25786009)(107886003)(11346002)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3217; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +++FWEjdQyIyaBmL1rztZtKxgLQZZys6nEMGJ7YKMp4fuqVhCKTsHmjt6UBpl+IlXIjHIisNffl5G2+NUyfc7TYAQvbcfYPSEchHXR3SqwiQ5gJAMwDZu5yMs/L7zybDvJmlAAwix6Ch18DHYpY6lxL7dffOf2qLtFxLps3pbUE0mASxks4CikXrIrcE24IYC4kvWXnCFLjmtTELVrueVrcK9BSTxrKS58ixQxyQ+pHXn45ujs6XEiKSiKnGe+Jp1ThzwriLF0jX/lxVdtRSkPHTvS/lzn6aIkuhYLsMz7Qroj4RbvZ+luIdsd7GPTCY spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 944e6320-b8d7-41d4-5f9f-08d676773a1c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2019 21:12:56.7158 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3217 Subject: Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 21:12:58 -0000 > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, January 9, 2019 1:38 PM > To: Adrien Mazarguil > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > ; Jack Min > Subject: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions > documentation >=20 > This patch fixes a typo in SET_MAC_DST action description. > It also adds restriction note for set MAC src/dst actions description. >=20 > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") > Cc: jackmin@mellanox.com >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index c186375..dbf4999 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2314,7 +2314,10 @@ in pattern, Some PMDs will reject rule because > behaviour will be undefined. > Action: ``SET_MAC_SRC`` > ^^^^^^^^^^^^^^^^^^^^^^^ >=20 > -Set source MAC address > +Set source MAC address. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. >=20 > .. _table_rte_flow_action_set_mac_src: >=20 > @@ -2329,7 +2332,10 @@ Set source MAC address > Action: ``SET_MAC_DST`` > ^^^^^^^^^^^^^^^^^^^^^^^ >=20 > -Set source MAC address > +Set destination MAC address. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. >=20 > .. _table_rte_flow_action_set_mac_dst: >=20 > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori