DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: Rosen Xu <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"walter.e.gilmore@intel.com" <walter.e.gilmore@intel.com>,
	"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization
Date: Sun, 22 Jul 2018 06:33:50 +0000	[thread overview]
Message-ID: <AM4PR05MB3425F37FF34F031FA4EB9ACDDB570@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1532159404-88843-1-git-send-email-rosen.xu@intel.com>



> -----Original Message-----
> From: Rosen Xu [mailto:rosen.xu@intel.com]
> Sent: Saturday, July 21, 2018 10:50 AM
> To: dev@dpdk.org
> Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam
> <orika@mellanox.com>; walter.e.gilmore@intel.com; qi.z.zhang@intel.com;
> stable@dpdk.org
> Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization
> 
> Rte_fdir_conf of rte_eth_conf should be initialized before
> port initialization. It is a workaround solution when work
> with Intel I40e.
> 
> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow
> API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> v2 updates:
> ===========
>  - Take more test on I40e
>  - Add comments
> ---
>  examples/flow_filtering/main.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index f595034..73d646c 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -132,6 +132,17 @@
>  				DEV_TX_OFFLOAD_SCTP_CKSUM  |
>  				DEV_TX_OFFLOAD_TCP_TSO,
>  		},
> +		/*
> +		 * Initialize fdir_conf of ete_eth_conf
> +		 * it is a workaround solution when work with Intel I40e
> +		 * and it is not the normal way
> +		 */
> +		.fdir_conf = {
> +			.mode = RTE_FDIR_MODE_PERFECT,
> +			.pballoc = RTE_FDIR_PBALLOC_64K,
> +			.status = RTE_FDIR_REPORT_STATUS,
> +			.drop_queue = 127,
> +		},
>  	};
>  	struct rte_eth_txconf txq_conf;
>  	struct rte_eth_rxconf rxq_conf;
> --
> 1.8.3.1

Just small comment I think work should be replaced with working.
Both in the commit log and code comment.

Acked-by: Ori Kam <orika@mellanox.com>

Thanks,
Ori

  reply	other threads:[~2018-07-22  6:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  2:09 [dpdk-dev] [PATCH] " Rosen Xu
2018-07-12  5:17 ` Ori Kam
2018-07-12  5:26   ` Xu, Rosen
2018-07-12  5:58     ` Ori Kam
2018-07-12  6:22       ` Xu, Rosen
2018-07-17  5:15         ` Ori Kam
2018-07-17  9:57           ` Ferruh Yigit
2018-07-17 13:04             ` Ori Kam
2018-07-17 15:49               ` Ferruh Yigit
2018-07-21  7:50 ` [dpdk-dev] [PATCH v2] " Rosen Xu
2018-07-22  6:33   ` Ori Kam [this message]
2018-07-22 10:37     ` Xu, Rosen
2018-07-22 10:39 ` [dpdk-dev] [PATCH v3] " Rosen Xu
2018-07-23 20:32   ` Ferruh Yigit
2018-07-26 17:42   ` Thomas Monjalon
2018-07-31 12:55     ` Xu, Rosen
2018-07-31 12:52 ` [dpdk-dev] [PATCH v4] " Rosen Xu
2018-08-05 20:13   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB3425F37FF34F031FA4EB9ACDDB570@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=walter.e.gilmore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).