From: Dekel Peled <dekelp@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
Yongseok Koh <yskoh@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: support action with any config object type
Date: Tue, 2 Jul 2019 08:42:41 +0000 [thread overview]
Message-ID: <AM4PR05MB346044F553E065BFF49A6AF7B6F80@AM4PR05MB3460.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <7e07e792-edd4-b946-641d-4cff9cc2c830@solarflare.com>
Thanks, PSB.
> -----Original Message-----
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> Sent: Tuesday, July 2, 2019 11:09 AM
> To: Dekel Peled <dekelp@mellanox.com>; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; wenzhuo.lu@intel.com;
> jingjing.wu@intel.com; bernard.iremonger@intel.com; Yongseok Koh
> <yskoh@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>; arybchenko@solarflare.com
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: support action with any config
> object type
>
> On 01.07.2019 17:10, Dekel Peled wrote:
> > In current implementation, an action which requires parameters must
> > accept them enclosed in a structure.
> > Some actions require a single, trivial type parameter, but it still
> > must be enclosed in a structure.
> > This obligation results in multiple, action-specific structures, each
> > containing a single trivial type parameter.
> >
> > This patch introduces a new approach, allowing an action configuration
> > object of any type, trivial or a structure.
> >
> > This patch introduces, in test-pmd, a new macro ARG_ENTRY_HTON, to
> > allow using a single argument, not enclosed in a structure.
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
> The term "object" confuses me a bit, but I'm not a native speaker so it could
> be just my wrong association. I'd prefer "configuration data".
In previous version I wrote just "action configuration", and changed to "action configuration object" per Adrien's suggestion. I think it is better, but if it causes confusion maybe it should be changed.
Adrien, what do you think? Does "configuration data" carry the correct meaning?
>
> Anyway,
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2019-07-02 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 14:10 Dekel Peled
2019-07-02 8:09 ` Andrew Rybchenko
2019-07-02 8:42 ` Dekel Peled [this message]
2019-07-02 9:57 ` Adrien Mazarguil
2019-07-02 10:11 ` Andrew Rybchenko
2019-07-02 10:15 ` Dekel Peled
2019-07-02 10:17 ` Dekel Peled
2019-07-02 14:17 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-07-02 15:07 ` Andrew Rybchenko
2019-07-02 15:15 ` Adrien Mazarguil
2019-07-03 17:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB346044F553E065BFF49A6AF7B6F80@AM4PR05MB3460.eurprd05.prod.outlook.com \
--to=dekelp@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).